Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
fix(events): stop credential-triggered auto-start of optional daemons
trohitg3b88042bbad9
diff --git a/server/nodes/stripe/stripe_receive.py b/server/nodes/stripe/stripe_receive.pyindex c6689834..4096c1f9 100644--- a/server/nodes/stripe/stripe_receive.py+++ b/server/nodes/stripe/stripe_receive.py@@ -67,8 +67,18 @@ class StripeReceiveNode(WebhookTriggerNode):async def _check_precondition(self) -> Optional[str]:from ._source import get_listen_source- if not get_listen_source()._started:- return "Stripe daemon not running. Add Stripe API key in Credentials and connect."+ source = get_listen_source()+ if source._started:+ return None+ # Deploying a stripeReceive workflow IS the demand signal: start the+ # listen daemon here instead of relying on a credential-triggered+ # auto-start at boot (the status refresh is a passive probe now).+ if not await source.has_credential():+ return "Stripe not connected. Add Stripe API key in Credentials and connect."+ result = await source.start()+ if not (result or {}).get("success", False):+ error = (result or {}).get("error") or "unknown error"+ return f"Stripe daemon failed to start: {error}"return Nonedef shape_output(self, event: WorkflowEvent) -> Dict:diff --git a/server/services/events/lifecycle.py b/server/services/events/lifecycle.pyindex 04928fb4..6cd51d38 100644--- a/server/services/events/lifecycle.py+++ b/server/services/events/lifecycle.py@@ -6,8 +6,8 @@ any :class:`EventSource`. Plugins call it once and register the dict —no per-handler boilerplate.:func:`make_status_refresh` returns a ``register_service_refresh``-callback that auto-reconnects the source when a credential is stored-and mirrors its status into the broadcaster cache.+callback that passively mirrors the source's status into the+broadcaster cache (it never starts the source; see its docstring).Together these collapse ~50 LOC of identical boilerplate per plugininto two function calls.@@ -79,17 +79,16 @@ def make_status_refresh() -> Callable[["StatusBroadcaster"], Awaitable[None]]:"""Return a ``register_service_refresh`` callback.- The callback auto-starts the source if it has stored credentials,- mirrors its status into ``broadcaster._status[status_key]``, and- emits a ``broadcast_type`` broadcast.+ The callback is a passive probe: it mirrors the source's status into+ ``broadcaster._status[status_key]`` and emits a ``broadcast_type``+ broadcast. It never starts the source — a stored credential alone is+ not a reason to run an optional daemon. Sources start on demand:+ user-initiated ``{prefix}_connect`` / login handlers, and trigger-node+ deploy prechecks (e.g. ``StripeReceiveNode._check_precondition``)."""async def refresh(broadcaster: "StatusBroadcaster") -> None:try:- if not getattr(source, "_started", False) and hasattr(source, "has_credential"):- if await source.has_credential(): # type: ignore[attr-defined]- logger.info("[StatusBroadcaster] auto-reconnecting %s", status_key)- await source.start()status = await source.status()broadcaster._status[status_key] = statusawait broadcaster.broadcast({"type": broadcast_type, "data": status})