Skip to content

Self-improving AI Employees for everyone

fix(memory): align memory + chatTrigger param keys with snake_case schema

trohitg3dd7625d9c75
diff --git a/client/src/components/ParameterRenderer.tsx b/client/src/components/ParameterRenderer.tsx
index cad5d034..6fe52b4a 100644
--- a/client/src/components/ParameterRenderer.tsx
+++ b/client/src/components/ParameterRenderer.tsx
@@ -1633,8 +1633,17 @@ const ParameterRenderer: React.FC<ParameterRendererProps> = ({
);
}
- // Special case for sessionId parameter - show auto-derived session ID in placeholder
- if (parameter.name === 'sessionId' && connectedAgentId) {
+ // Special case for the session-id parameter on a Memory node:
+ // show the auto-derived session id (the connected agent's node
+ // id) as the placeholder so the user can see what default the
+ // backend will use without typing anything. Schema-canonical
+ // name is `session_id` (Pydantic snake_case); the legacy
+ // `sessionId` is matched too so pre-migration workflows keep
+ // rendering the placeholder.
+ if (
+ (parameter.name === 'session_id' || parameter.name === 'sessionId') &&
+ connectedAgentId
+ ) {
const effectivePlaceholder = connectedAgentId;
return (
diff --git a/client/src/components/parameterPanel/MiddleSection.tsx b/client/src/components/parameterPanel/MiddleSection.tsx
index 6a2b7cd2..a5de63b3 100644
--- a/client/src/components/parameterPanel/MiddleSection.tsx
+++ b/client/src/components/parameterPanel/MiddleSection.tsx
@@ -127,14 +127,16 @@ const MiddleSection: React.FC<MiddleSectionProps> = ({
// For Memory nodes: track the connected agent's ID for auto-session display
const [connectedAgentId, setConnectedAgentId] = useState<string | null>(null);
- // Clear memory handler
+ // Clear memory handler. Schema-canonical keys are snake_case
+ // (post-Wave-11 plugin Pydantic models); accept legacy camelCase
+ // on the read side for old workflow imports.
const handleClearMemory = async () => {
setIsProcessing(true);
try {
- const sessionId = parameters.sessionId || 'default';
+ const sessionId = parameters.session_id || parameters.sessionId || 'default';
const result = await clearMemory(sessionId, clearLongTermMemory);
if (result.success && result.default_content) {
- onParameterChange('memoryContent', result.default_content);
+ onParameterChange('memory_content', result.default_content);
}
} finally {
setIsProcessing(false);
@@ -182,13 +184,17 @@ const MiddleSection: React.FC<MiddleSectionProps> = ({
const { data: userSettings } = useUserSettingsQuery();
// Apply the global memory_window_size default to new Memory nodes. Only
- // fires when a Memory node is opened AND the node hasn't had windowSize
- // set yet (brand-new instance).
+ // fires when a Memory node is opened AND the node hasn't had window_size
+ // set yet (brand-new instance). Plugin schema field is snake_case;
+ // legacy camelCase is also recognized so we don't overwrite a value
+ // saved before the migration.
useEffect(() => {
if (!isMemoryNode) return;
const globalWindowSize = userSettings?.memory_window_size;
- if (globalWindowSize !== undefined && parameters.windowSize === undefined) {
- onParameterChange('windowSize', globalWindowSize);
+ const alreadySet =
+ parameters.window_size !== undefined || parameters.windowSize !== undefined;
+ if (globalWindowSize !== undefined && !alreadySet) {
+ onParameterChange('window_size', globalWindowSize);
}
// Same dep set as the previous imperative effect — only wake up on
// node change, not on every parameter edit.
@@ -215,9 +221,13 @@ const MiddleSection: React.FC<MiddleSectionProps> = ({
const connectedMemorySessionId = useMemo<string | null>(() => {
if (!memoryEdgeSourceId) return null;
- const configured: string = memoryParamsData?.sessionId || '';
+ // Schema-canonical session_id; legacy camelCase fallback so older
+ // workflow imports keep showing the user-configured value rather
+ // than silently falling back to nodeId.
+ const configured: string =
+ memoryParamsData?.session_id || memoryParamsData?.sessionId || '';
return configured && configured !== 'default' ? configured : nodeId;
- }, [memoryEdgeSourceId, memoryParamsData?.sessionId, nodeId]);
+ }, [memoryEdgeSourceId, memoryParamsData?.session_id, memoryParamsData?.sessionId, nodeId]);
const compactionStatsQuery = useQuery<{
session_id: string;
@@ -606,7 +616,7 @@ const MiddleSection: React.FC<MiddleSectionProps> = ({
This will reset the conversation history to its initial state. This action cannot be undone.
</AlertDialogDescription>
</AlertDialogHeader>
- {parameters.longTermEnabled && (
+ {(parameters.long_term_enabled ?? parameters.longTermEnabled) && (
<label className="flex cursor-pointer items-center gap-2 text-sm text-foreground">
<Checkbox
checked={clearLongTermMemory}
diff --git a/server/services/agents/service.py b/server/services/agents/service.py
index 4a068626..4d7792c6 100644
--- a/server/services/agents/service.py
+++ b/server/services/agents/service.py
@@ -250,7 +250,10 @@ class DeepAgentService:
if database:
params = await database.get_node_parameters(memory_data['node_id']) or {}
- params['memoryContent'] = updated
+ # Schema-canonical key. Drop any pre-migration
+ # camelCase mirror so the saved params stay clean.
+ params['memory_content'] = updated
+ params.pop('memoryContent', None)
await database.save_node_parameters(memory_data['node_id'], params)
log_execution_time(logger, "deep_agent", start_time, time.time())
diff --git a/server/services/ai.py b/server/services/ai.py
index 727108ab..5ee4c848 100644
--- a/server/services/ai.py
+++ b/server/services/ai.py
@@ -1896,10 +1896,13 @@ class AIService:
except Exception as e:
logger.warning(f"[LangGraph Memory] Failed to archive to vector store: {e}")
- # Save updated markdown to node parameters
+ # Save updated markdown to node parameters. Schema-
+ # canonical key is snake_case; drop any pre-migration
+ # camelCase mirror so the saved params stay clean.
memory_node_id = memory_data['node_id']
current_params = await self.database.get_node_parameters(memory_node_id) or {}
- current_params['memoryContent'] = updated_content
+ current_params['memory_content'] = updated_content
+ current_params.pop('memoryContent', None)
await self.database.save_node_parameters(memory_node_id, current_params)
logger.info(f"[LangGraph Memory] Saved markdown to memory node '{memory_node_id}'")
@@ -2335,10 +2338,13 @@ class AIService:
except Exception as e:
logger.warning(f"[ChatAgent Memory] Failed to archive to vector store: {e}")
- # Save updated markdown to node parameters
+ # Save updated markdown to node parameters. Schema-
+ # canonical key is snake_case; drop any pre-migration
+ # camelCase mirror so the saved params stay clean.
memory_node_id = memory_data['node_id']
current_params = await self.database.get_node_parameters(memory_node_id) or {}
- current_params['memoryContent'] = updated_content
+ current_params['memory_content'] = updated_content
+ current_params.pop('memoryContent', None)
await self.database.save_node_parameters(memory_node_id, current_params)
logger.info(f"[ChatAgent Memory] Saved markdown to memory node '{memory_node_id}'")
diff --git a/server/services/event_waiter.py b/server/services/event_waiter.py
index cbb6d0d1..84af85da 100644
--- a/server/services/event_waiter.py
+++ b/server/services/event_waiter.py
@@ -361,12 +361,15 @@ def build_chat_filter(params: Dict) -> Callable[[Dict], bool]:
"""Build filter function for chat messages from console input.
Args:
- params: Node parameters with 'sessionId' field
+ params: Node parameters with 'session_id' field (camelCase
+ 'sessionId' also accepted for legacy imports).
Returns:
Filter function that checks if event session_id matches
"""
- session_id = params.get('sessionId', 'default')
+ # The chatTrigger Pydantic model emits 'session_id' in JSON Schema;
+ # accept both for backward compat with pre-migration workflows.
+ session_id = params.get('session_id') or params.get('sessionId', 'default')
def matches(data: Dict) -> bool:
event_session = data.get('session_id', 'default')
diff --git a/server/services/plugin/edge_walker.py b/server/services/plugin/edge_walker.py
index e5ce5229..afcab46c 100644
--- a/server/services/plugin/edge_walker.py
+++ b/server/services/plugin/edge_walker.py
@@ -150,20 +150,33 @@ async def _build_memory_entry(
log_prefix: str,
) -> Dict[str, Any]:
memory_params = await database.get_node_parameters(memory_node_id) or {}
- configured_session = memory_params.get("sessionId", "")
+ # Plugin Pydantic models emit JSON Schema property names in
+ # snake_case (post-Wave-11; see simple_memory.py "now that aliases
+ # are gone"). Reads also accept the pre-migration camelCase keys so
+ # legacy workflow imports keep working until users re-save.
+ configured_session = memory_params.get("session_id") or memory_params.get("sessionId", "")
if configured_session and configured_session != "default":
session_id = configured_session
else:
session_id = agent_node_id
+ default_content = "# Conversation History\n\n*No messages yet.*\n"
entry = {
"node_id": memory_node_id,
"session_id": session_id,
- "window_size": int(memory_params.get("windowSize", 10)),
- "memory_content": memory_params.get(
- "memoryContent", "# Conversation History\n\n*No messages yet.*\n",
+ "window_size": int(memory_params.get("window_size") or memory_params.get("windowSize", 10)),
+ "memory_content": (
+ memory_params.get("memory_content")
+ or memory_params.get("memoryContent")
+ or default_content
+ ),
+ "long_term_enabled": (
+ memory_params.get("long_term_enabled")
+ if "long_term_enabled" in memory_params
+ else memory_params.get("longTermEnabled", False)
+ ),
+ "retrieval_count": int(
+ memory_params.get("retrieval_count") or memory_params.get("retrievalCount", 3)
),
- "long_term_enabled": memory_params.get("longTermEnabled", False),
- "retrieval_count": int(memory_params.get("retrievalCount", 3)),
}
logger.debug(
f"{log_prefix} Connected memory node: session={session_id} "