Skip to content

Self-improving AI Employees for everyone

fix(agents): enforce local ownership for legacy workflow creation

trohitg4f73cb10f368
diff --git a/server/routers/agents.py b/server/routers/agents.py
index 9e189506..4f3121fd 100644
--- a/server/routers/agents.py
+++ b/server/routers/agents.py
@@ -53,7 +53,7 @@ async def create_agent(body: CreateAgent, request: Request):
async def authorize(session):
workflow = (await session.execute(select(Workflow).where(Workflow.id == body.workflow_id))).scalar_one_or_none()
- if workflow is None or ((workflow.data or {}).get("owner_id") and str(workflow.data["owner_id"]) != principal):
+ if workflow is None or str((workflow.data or {}).get("owner_id") or "owner") != principal:
raise HTTPException(status_code=404, detail="Workflow not found")
# Receipts do not confer access if ownership changes after creation.
diff --git a/server/routers/browser_agents.py b/server/routers/browser_agents.py
index 7dd37e30..2796e65e 100644
--- a/server/routers/browser_agents.py
+++ b/server/routers/browser_agents.py
@@ -31,7 +31,7 @@ async def create_browser_agent(body: CreateBrowserAgent, request: Request):
async def authorize(session):
saved = (await session.execute(select(Workflow).where(Workflow.id == body.workflow_id))).scalar_one_or_none()
- if saved is None or (saved.data.get("owner_id") and str(saved.data["owner_id"]) != principal):
+ if saved is None or str((saved.data or {}).get("owner_id") or "owner") != principal:
raise HTTPException(status_code=404, detail="Workflow not found")
# A cached mutation receipt must not bypass authorization after access
diff --git a/server/tests/routers/test_agent_creation.py b/server/tests/routers/test_agent_creation.py
index a2d89a86..1f430aa0 100644
--- a/server/tests/routers/test_agent_creation.py
+++ b/server/tests/routers/test_agent_creation.py
@@ -5,7 +5,7 @@ from uuid import uuid4
import pytest
from fastapi import HTTPException
-from routers import agents
+from routers import agents, browser_agents
from tests.nodes._agent_builder_harness import ( # noqa: F401 -- pytest registers imported fixtures
builder_fixture, database_fixture, save_graph, saved,
)
@@ -18,6 +18,7 @@ def request(owner="owner"):
@pytest.fixture
def creation(database, builder, monkeypatch):
monkeypatch.setattr(agents, "container", SimpleNamespace(database=lambda: database))
+ monkeypatch.setattr(browser_agents, "container", SimpleNamespace(database=lambda: database))
monkeypatch.setenv("NEW_AGENT_RUNTIME_V1_ENABLED", "true")
return builder
@@ -62,6 +63,22 @@ async def test_receipt_never_bypasses_owner_check(database, creation):
assert len(creation.frames) == 1
[email protected]("bundle", [False, True])
+async def test_ownerless_legacy_workflow_still_belongs_to_local_owner(database, creation, bundle):
+ await save_graph(database, {"nodes": [], "edges": []})
+ body = agents.CreateAgent(workflow_id="7", node_type="aiAgent", mutation_id=uuid4())
+ with pytest.raises(HTTPException) as caught:
+ if bundle:
+ await browser_agents.create_browser_agent(browser_agents.CreateBrowserAgent(
+ workflow_id="7", mutation_id=uuid4()), request("stranger"))
+ else:
+ await agents.create_agent(body, request("stranger"))
+ assert caught.value.status_code == 404
+ assert (await saved(database))["nodes"] == []
+ assert creation.frames == []
+
+
@pytest.mark.asyncio
@pytest.mark.parametrize("kind,initial", [("shell", {}), ("browser_agent", {}), ("aiAgent", {"temperature": "invalid"})])
async def test_rejected_creation_has_no_nodes_parameters_or_edges(database, creation, kind, initial):