Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
fix: resolve code-side findings from the documentation drift audit
trohitg51fce1462bab
diff --git a/.gitignore b/.gitignoreindex 78b897f8..52b7fa4f 100644--- a/.gitignore+++ b/.gitignore@@ -11,6 +11,7 @@ node_modulesdistdist-ssr*.local+test-temp*/# External design handoff bundle (reference-only; merged copy lives in docs-internal/design-system/)design_handoff_theme_system/diff --git a/cli/commands/deploy/providers/aws.py b/cli/commands/deploy/providers/aws.pyindex cdbb84fe..8d65bf37 100644--- a/cli/commands/deploy/providers/aws.py+++ b/cli/commands/deploy/providers/aws.py@@ -1,10 +1,12 @@-"""aws-cli adapter -- placeholder (the AWS Terraform module is a follow-on).--Implements the ``ProviderCli`` shape so the resolver/wiring is uniform, but-aborts with a clear message until the ``cli/terraform/aws/`` module lands. The-real adapter will mirror gcp.py: ``aws sts get-caller-identity`` for auth, the-default credential chain for Terraform, region from ``aws configure get region``-/ ``$AWS_REGION``, and a security-group + EC2 instance module.+"""aws-cli adapter -- still a placeholder.++The ``cli/terraform/aws/`` module has landed (validated t3.micro setup), but+this adapter has not been wired to it yet. It implements the ``ProviderCli``+shape so the resolver/wiring is uniform, and aborts with a clear message+(exit 1) when selected. The real adapter will mirror gcp.py: ``aws sts+get-caller-identity`` for auth, the default credential chain for Terraform,+region from ``aws configure get region`` / ``$AWS_REGION``, and the existing+security-group + EC2 instance module."""from __future__ import annotationsdiff --git a/client/src/components/AIAgentNode.tsx b/client/src/components/AIAgentNode.tsxindex 0d251c01..6c32beb4 100644--- a/client/src/components/AIAgentNode.tsx+++ b/client/src/components/AIAgentNode.tsx@@ -58,8 +58,8 @@ const AIAgentNode: React.FC<NodeProps<NodeData>> = ({ id, type, data, isConnectaconst spec = useNodeSpec(type || 'aiAgent');const handles: SpecHandle[] = (spec?.handles as SpecHandle[] | undefined) ?? [];const accentColor = spec?.color || 'var(--node-agent)';- const width = (spec?.uiHints as any)?.width ?? 300;- const height = (spec?.uiHints as any)?.height ?? 200;+ const width = spec?.uiHints?.width ?? 300;+ const height = spec?.uiHints?.height ?? 200;const defaultLabel = spec?.displayName || type || 'Agent';const subtitle = spec?.subtitle ?? '';diff --git a/client/src/components/parameterPanel/MiddleSection.tsx b/client/src/components/parameterPanel/MiddleSection.tsxindex 7e5afbf6..7fda7f3b 100644--- a/client/src/components/parameterPanel/MiddleSection.tsx+++ b/client/src/components/parameterPanel/MiddleSection.tsx@@ -552,7 +552,7 @@ const MiddleSection: React.FC<MiddleSectionProps> = ({<div className="relative flex h-full flex-1 flex-col overflow-hidden">{/* Description - hide for code editor nodes (Python, Skill), masterSkill,and the todo editor (each renders its own full-panel header). */}- {!needsCodeEditorLayout && !isMasterSkillNode && !isContextNode && !isMemoryToolNode && !isTodoEditorNode && !isTaskManagerNode && !isMonitorNode && !isProcessManagerNode && !isGalleryNode && !isCanvasNode && (+ {!needsCodeEditorLayout && !isMasterSkillNode && !isContextNode && !isMemoryToolNode && !isDataNode && !isTodoEditorNode && !isTaskManagerNode && !isMonitorNode && !isProcessManagerNode && !isGalleryNode && !isCanvasNode && (<div className="shrink-0 border-b border-border-default bg-bg-panel px-6 pt-4 pb-2"><p className="m-0 text-base leading-[1.5] text-fg-muted">{nodeDefinition.description}diff --git a/client/src/contexts/WebSocketContext.tsx b/client/src/contexts/WebSocketContext.tsxindex 15b3ab15..6b22b6d8 100644--- a/client/src/contexts/WebSocketContext.tsx+++ b/client/src/contexts/WebSocketContext.tsx@@ -751,13 +751,9 @@ export const WebSocketProvider: React.FC<{ children: React.ReactNode }> = ({ chiconst currentWorkflowId = currentWorkflow?.id;const [isConnected, setIsConnected] = useState(false);- // `isReady` flips true only AFTER the init burst inside `ws.onopen`- // completes (api-key probes, terminal/chat/console history). Queries- // that depend on backend-served catalogue data (NodeSpec catalogue,- // node groups, node parameters, user settings, credential panels)- // gate on `isReady` instead of `isConnected` so they fire once,- // post-burst, instead of racing the serial awaits and arriving in- // arbitrary order.+ // `isReady` flips true as soon as the socket opens and the pending-send+ // queue drains (Wave 32: no init burst). Catalogue/spec queries gate on+ // it rather than `isConnected` so queued sends replay first.const [isReady, setIsReady] = useState(false);const [reconnecting, setReconnecting] = useState(false);const [androidStatus, setAndroidStatus] = useState<AndroidStatus>(defaultAndroidStatus);@@ -2075,8 +2071,8 @@ export const WebSocketProvider: React.FC<{ children: React.ReactNode }> = ({ chi// First click "did nothing" because catalogue / nodeSpec / credentials// queries gate on `isReady` and stayed disabled. The cache (warmed// from localStorage via PersistQueryClientProvider for `nodeSpec` /- // `nodeGroups` / `pluginCatalogue` / `skillContent`) carries the- // visible state until refreshes land.+ // `nodeGroups` — see lib/queryPersist.ts) carries the visible state+ // until refreshes land.//// Wave 32 also dropped the legacy hardcoded `probeApiKey` loop over// `['openai', 'anthropic', 'gemini', 'google_maps', 'android_remote']`.diff --git a/client/src/types/INodeProperties.ts b/client/src/types/INodeProperties.tsindex a0fb59c3..bf0b7c87 100644--- a/client/src/types/INodeProperties.ts+++ b/client/src/types/INodeProperties.ts@@ -276,6 +276,14 @@ export interface INodeUIHints {* `resolveNodeDescription` — the adapter drops uiHints' siblings and this* value must match what the server will actually allow. */executionTimeoutMs?: number;+ /** Canvas node box size in px, declared by the plugin (agents via+ * `STD_SIZE`, social send/receive). `AIAgentNode` reads them; absent+ * hints fall back to 300x200. */+ width?: number;+ height?: number;+ /** InputSection: the start node's user-authored JSON blob is the+ * upstream "output" to show (Wave 10.G.5). */+ hasInitialDataBlob?: boolean;}export interface INodeTypeDescription {diff --git a/docs-internal/canvas_node.md b/docs-internal/canvas_node.mdindex 1c599770..d8911e09 100644--- a/docs-internal/canvas_node.md+++ b/docs-internal/canvas_node.md@@ -68,7 +68,7 @@ despite `component_kind="tool"`.Two deliberate overrides of what the group/base would otherwise derive:-- `ui_hints = {"isCanvasPanel": True, "isToolPanel": True, "isConfigNode": False}` —+- `ui_hints = {"isCanvasPanel": True, "isConfigNode": False}` —the `tool` group auto-derives `isConfigNode: True`, but the Canvas node's`input-main` is a real runtime dataflow edge, so it must present as anormal node (no parent-input inheritance). Explicit wins overdiff --git a/docs-internal/node-logic-flows/ai_agents/masterSkill.md b/docs-internal/node-logic-flows/ai_agents/masterSkill.mdindex 3097c2a1..b80c0aa8 100644--- a/docs-internal/node-logic-flows/ai_agents/masterSkill.md+++ b/docs-internal/node-logic-flows/ai_agents/masterSkill.md@@ -29,7 +29,7 @@ in the auto-add-skill edge dispatcher.|--------|-----------------|----------|---------|| `output-tool` (source, top, label "Skill", role `skill`) | skill | yes (only handle) | Connect to an agent's `input-skill` |-No `input-main`, no `main` output. uiHints: `isToolPanel`,+No `input-main`, no `main` output. uiHints:`isMasterSkillEditor`, `hideRunButton`, `hideInputSection`,`hideOutputSection`; `isConfigNode` auto-derived from the `tool` group(the executor excludes it from execution layers).diff --git a/docs-internal/node-logic-flows/ai_tools/dataSource.md b/docs-internal/node-logic-flows/ai_tools/dataSource.mdindex 75ee4ec5..cac63c78 100644--- a/docs-internal/node-logic-flows/ai_tools/dataSource.md+++ b/docs-internal/node-logic-flows/ai_tools/dataSource.md@@ -28,7 +28,7 @@ drags and the [`visionAnalyze`](./visionAnalyze.md) tool.|--------|-----------------|----------|---------|| `output-tool` (source, top, label "Data") | tools | yes (only way to use it) | Connect to an agent's `input-tools`; the agent calls `data(...)` |-No `input-main`. uiHints: `isToolPanel`, `isDataPanel` (renders+No `input-main`. uiHints: `isDataPanel` (renders`client/src/components/parameterPanel/DataPanel.tsx`), `hideInputSection`,`hideOutputSection`, `hideRunButton`; `isConfigNode` auto-derived from the`tool` group. A framework-side execution with only `Params` (no tool args)diff --git a/docs-internal/node-logic-flows/ai_tools/visionAnalyze.md b/docs-internal/node-logic-flows/ai_tools/visionAnalyze.mdindex 49ff7ad6..0a6a56cd 100644--- a/docs-internal/node-logic-flows/ai_tools/visionAnalyze.md+++ b/docs-internal/node-logic-flows/ai_tools/visionAnalyze.md@@ -27,7 +27,7 @@ blocks land.|--------|-----------------|----------|---------|| `output-tool` (source, top, label "Vision") | tools | yes | Connect to an agent's `input-tools`; the agent calls `vision(...)` |-No `input-main`. uiHints: `isToolPanel`, `hideInputSection`,+No `input-main`. uiHints: `hideInputSection`,`hideOutputSection`, `hideRunButton`; `isConfigNode` auto-derived. A directexecution (Params only, no tool args) raises `NodeUserError("The vision toolneeds an image argument; connect it to an agent's tools ...")`.diff --git a/docs-internal/plugin_system.md b/docs-internal/plugin_system.mdindex 712c5470..f8827487 100644--- a/docs-internal/plugin_system.md+++ b/docs-internal/plugin_system.md@@ -70,7 +70,7 @@ class SpecializedAgentBase(ActionNode, abstract=True):| `group` | Tuple of palette groupings (first is primary). || `component_kind` | Frontend dispatch: `square` / `trigger` / `agent` / `tool` / `model` / `start` / `generic`. || `handles` | React Flow handle topology (`input-main`, `output-main`, …). |-| `ui_hints` | Dict of panel flags (`hasCodeEditor`, `isMemoryPanel`, `isMasterSkillEditor`, `isToolPanel`, `hasSkills`, `isConfigNode`, `outputMode: "terminal"` for CLI-wrapper nodes whose textual output must render preformatted, …). See "Auto-derived uiHints" below — `isConfigNode` is set automatically for `('memory', 'tool')` group plugins. Live flag list = the `known` set in `test_node_spec.py`. |+| `ui_hints` | Dict of panel flags (`hasCodeEditor`, `isMemoryPanel`, `isMasterSkillEditor`, `isDataPanel`, `hasSkills`, `isConfigNode`, `outputMode: "terminal"` for CLI-wrapper nodes whose textual output must render preformatted, …). See "Auto-derived uiHints" below — `isConfigNode` is set automatically for `('memory', 'tool')` group plugins. Live flag list = the `known` set in `test_node_spec.py`. || `annotations` | Pipedream-style: `destructive` / `readonly` / `open_world`. || `credentials` | Sequence of `Credential` subclasses the node uses. More than one is supported — see [Multi-credential nodes](#multi-credential-nodes). || `Params` | Pydantic `BaseModel` — user-facing parameters. Used for both UI rendering and AI tool schemas. |diff --git a/server/config/credential_providers.json b/server/config/credential_providers.jsonindex 9fb27d51..4fbc7dbf 100644--- a/server/config/credential_providers.json+++ b/server/config/credential_providers.json@@ -872,23 +872,19 @@"status": "gcloud_status"},"instructions": "Click 'Login with Google Cloud' — the gcloud CLI (auto-installed, ~100 MB on first use) opens your default browser itself for Google sign-in and completes via a localhost callback (browser must run on this machine; the badge flips when the CLI finishes). Credentials are stored by gcloud under OpenCompany's data directory — isolated from any gcloud you may have installed yourself — and OpenCompany never keeps them."+ },+ "deepl": {+ "extends": "_ai_base",+ "name": "DeepL",+ "category": "ai",+ "category_label": "AI Providers",+ "instructions": "Create an API key at deepl.com/your-account/keys. Free and Pro keys both work — a free key ends in ':fx' and the node routes it to the free host automatically.",+ "fields": [+ {+ "key": "apiKey",+ "placeholder": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx[:fx]"+ }+ ]}- },- "deepl": {- "extends": "_ai_base",- "name": "DeepL",- "category": "ai",- "category_label": "AI Providers",- "instructions": "Create an API key at deepl.com/your-account/keys. Free and Pro keys both work — a free key ends in ':fx' and the node routes it to the free host automatically.",- "fields": [- {- "key": "deepl",- "label": "API Key",- "type": "password",- "secret": true,- "placeholder": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx[:fx]",- "required": true- }- ]}}diff --git a/server/nodes/search/duckduckgo_search/__init__.py b/server/nodes/search/duckduckgo_search/__init__.pyindex c53c2402..dcc7e70e 100644--- a/server/nodes/search/duckduckgo_search/__init__.py+++ b/server/nodes/search/duckduckgo_search/__init__.py@@ -49,7 +49,7 @@ class DuckDuckGoSearchNode(ToolNode):{"name": "input-main", "kind": "input", "position": "left", "label": "Input", "role": "main"},{"name": "output-tool", "kind": "output", "position": "top", "label": "Tool", "role": "tools"},)- ui_hints = {"isToolPanel": True, "hideRunButton": True}+ ui_hints = {"hideRunButton": True}annotations = {"destructive": False, "readonly": True, "open_world": True}task_queue = TaskQueue.REST_APIdiff --git a/server/nodes/skill/master_skill/__init__.py b/server/nodes/skill/master_skill/__init__.pyindex 2a361712..637a1114 100644--- a/server/nodes/skill/master_skill/__init__.py+++ b/server/nodes/skill/master_skill/__init__.py@@ -46,7 +46,6 @@ class MasterSkillNode(ActionNode):component_kind = "tool"handles = ({"name": "output-tool", "kind": "output", "position": "top", "label": "Skill", "role": "skill"},)ui_hints = {- "isToolPanel": True,"isMasterSkillEditor": True,"hideRunButton": True,"hideInputSection": True,diff --git a/server/nodes/tool/agent_builder/__init__.py b/server/nodes/tool/agent_builder/__init__.pyindex fbf40854..602610a0 100644--- a/server/nodes/tool/agent_builder/__init__.py+++ b/server/nodes/tool/agent_builder/__init__.py@@ -842,7 +842,7 @@ class AgentBuilderNode(ToolNode):{"name": "input-main", "kind": "input", "position": "left", "label": "Input", "role": "main"},{"name": "output-tool", "kind": "output", "position": "top", "label": "Tool", "role": "tools"},)- ui_hints = {"isToolPanel": True, "hideRunButton": True}+ ui_hints = {"hideRunButton": True}annotations = {"destructive": False, "readonly": False, "open_world": True}task_queue = TaskQueue.DEFAULTdiff --git a/server/nodes/tool/calculator_tool/__init__.py b/server/nodes/tool/calculator_tool/__init__.pyindex 4415246f..5141d561 100644--- a/server/nodes/tool/calculator_tool/__init__.py+++ b/server/nodes/tool/calculator_tool/__init__.py@@ -74,7 +74,7 @@ class CalculatorToolNode(ToolNode):{"name": "input-main", "kind": "input", "position": "left", "label": "Input", "role": "main"},{"name": "output-tool", "kind": "output", "position": "top", "label": "Tool", "role": "tools"},)- ui_hints = {"isToolPanel": True, "hideRunButton": True}+ ui_hints = {"hideRunButton": True}annotations = {"destructive": False, "readonly": True, "open_world": False}Params = CalculatorParamsdiff --git a/server/nodes/tool/canvas/__init__.py b/server/nodes/tool/canvas/__init__.pyindex 19a52c4b..13d9f40b 100644--- a/server/nodes/tool/canvas/__init__.py+++ b/server/nodes/tool/canvas/__init__.py@@ -173,7 +173,6 @@ class CanvasNode(ToolNode):# auto-derivation.ui_hints = {"isCanvasPanel": True,- "isToolPanel": True,"isConfigNode": False,}# Overrides ToolNode's readonly default — canvas writes the durable board.diff --git a/server/nodes/tool/current_time_tool/__init__.py b/server/nodes/tool/current_time_tool/__init__.pyindex aee295b5..9c70d2f1 100644--- a/server/nodes/tool/current_time_tool/__init__.py+++ b/server/nodes/tool/current_time_tool/__init__.py@@ -36,7 +36,7 @@ class CurrentTimeToolNode(ToolNode):{"name": "input-main", "kind": "input", "position": "left", "label": "Input", "role": "main"},{"name": "output-tool", "kind": "output", "position": "top", "label": "Tool", "role": "tools"},)- ui_hints = {"isToolPanel": True, "hideRunButton": True}+ ui_hints = {"hideRunButton": True}annotations = {"destructive": False, "readonly": True, "open_world": False}task_queue = TaskQueue.DEFAULTdiff --git a/server/nodes/tool/data_source/__init__.py b/server/nodes/tool/data_source/__init__.pyindex b365ec47..567a8d1d 100644--- a/server/nodes/tool/data_source/__init__.py+++ b/server/nodes/tool/data_source/__init__.py@@ -221,7 +221,6 @@ class DataSourceNode(ToolNode):},)ui_hints = {- "isToolPanel": True,"isDataPanel": True,"hideInputSection": True,"hideOutputSection": True,diff --git a/server/nodes/tool/simple_memory/__init__.py b/server/nodes/tool/simple_memory/__init__.pyindex 15176ffd..065701a5 100644--- a/server/nodes/tool/simple_memory/__init__.py+++ b/server/nodes/tool/simple_memory/__init__.py@@ -191,7 +191,6 @@ class SimpleMemoryNode(ToolNode):},)ui_hints = {- "isToolPanel": True,"isMemoryPanel": True,"isMemoryToolPanel": True,# Kept as a wire-compatibility hint for older clients. V2 clientsdiff --git a/server/nodes/tool/task_manager/__init__.py b/server/nodes/tool/task_manager/__init__.pyindex ff787b76..1ea02bc6 100644--- a/server/nodes/tool/task_manager/__init__.py+++ b/server/nodes/tool/task_manager/__init__.py@@ -69,7 +69,6 @@ class TaskManagerNode(ToolNode):{"name": "output-tool", "kind": "output", "position": "top", "label": "Tool", "role": "tools"},)ui_hints = {- "isToolPanel": True,"isTaskManagerPanel": True,"hideInputSection": True,"hideOutputSection": True,diff --git a/server/nodes/tool/write_todos/__init__.py b/server/nodes/tool/write_todos/__init__.pyindex ec46c972..4badeb56 100644--- a/server/nodes/tool/write_todos/__init__.py+++ b/server/nodes/tool/write_todos/__init__.py@@ -73,7 +73,7 @@ class WriteTodosNode(ToolNode):{"name": "input-main", "kind": "input", "position": "left", "label": "Input", "role": "main"},{"name": "output-tool", "kind": "output", "position": "top", "label": "Tool", "role": "tools"},)- ui_hints = {"isToolPanel": True, "hideRunButton": True, "isTodoEditor": True}+ ui_hints = {"hideRunButton": True, "isTodoEditor": True}annotations = {"destructive": False, "readonly": False, "open_world": False}task_queue = TaskQueue.DEFAULTdiff --git a/server/nodes/vision/vision_analyze/__init__.py b/server/nodes/vision/vision_analyze/__init__.pyindex 31e9d9e2..db5c8a09 100644--- a/server/nodes/vision/vision_analyze/__init__.py+++ b/server/nodes/vision/vision_analyze/__init__.py@@ -168,7 +168,6 @@ class VisionAnalyzeNode(ToolNode):},)ui_hints = {- "isToolPanel": True,"hideInputSection": True,"hideOutputSection": True,"hideRunButton": True,diff --git a/server/nodes/whatsapp/_events.py b/server/nodes/whatsapp/_events.pyindex aef9fe11..0cd0305a 100644--- a/server/nodes/whatsapp/_events.py+++ b/server/nodes/whatsapp/_events.py@@ -20,9 +20,10 @@ Per RFC plugin_authoring_rfc.md §6.4:Wire format (Wave 12 D4 — legacy ``whatsapp_status`` raw frame retired):- Status: typed CloudEvents envelope on ``plugin_connection_status``(FE routes by ``envelope.source``).- - Message / newsletter / history: still dual-emit on their legacy- wire keys until the matching FE handlers migrate to envelope-aware- readers (follow-up D4 round).+ - Message / newsletter / history: one-way legacy WS frames on their+ ``whatsapp_*`` wire keys (no envelope twin). The FE handlers still+ route on those keys; migrating them to envelope-aware readers is a+ follow-up D4 round."""from __future__ import annotationsdiff --git a/server/services/temporal/activities.py b/server/services/temporal/activities.pyindex 66c99101..fc3b801c 100644--- a/server/services/temporal/activities.py+++ b/server/services/temporal/activities.py@@ -577,7 +577,8 @@ async def evaluate_trigger_filter_activity(payload: Dict[str, Any]) -> bool:async def pause_workflow_on_failure_activity(payload: Dict[str, Any]) -> Dict[str, Any]:"""Circuit breaker: pause a controlled deployment after a failed run.- Scheduled by MachinaWorkflow's failure path (patch-gated). All policy+ Scheduled by MachinaWorkflow's failure path (no ``workflow.patched``+ guard: the schedule is unconditional for trigger-spawned runs). All policylives in ``services.deployment.handlers.pause_generation_on_failure``— including the WORKFLOW_CONTROL_PAUSE_ON_FAILURE knob, evaluated onthe activity side so flipping it never touches recorded workflowdiff --git a/server/services/temporal/agent_activities.py b/server/services/temporal/agent_activities.pyindex 8aad4769..bb8a2635 100644--- a/server/services/temporal/agent_activities.py+++ b/server/services/temporal/agent_activities.py@@ -692,7 +692,8 @@ async def prepare_agent_payload(context: Dict[str, Any]) -> Dict[str, Any]:Mirrors the prep half of ``services.ai.AIService.execute_agent``,minus the agent loop (which lives in ``AgentWorkflow.run`` for the- F4.B Temporal path and ``services.ai._run_agent_loop`` in-process):+ F4.B Temporal path and ``services.agent_runtime.run_native_agent_loop``+ in-process):1. Read node parameters from DB via ``database.get_node_parameters``.2. Walk edges via ``services.plugin.edge_walker.collect_agent_connections``diff --git a/server/services/temporal/agent_workflow.py b/server/services/temporal/agent_workflow.pyindex fd588b6e..a2543ea9 100644--- a/server/services/temporal/agent_workflow.py+++ b/server/services/temporal/agent_workflow.py@@ -1,7 +1,7 @@"""F4.B: ``AgentWorkflow`` — Temporal child workflow for AI agent loops.-Workflow-orchestrated alternative to the in-process ``_run_agent_loop``-inside ``services/ai.py``: each LLM turn is an activity, each tool call+Workflow-orchestrated alternative to the in-process ``run_native_agent_loop``+in ``services/agent_runtime.py``: each LLM turn is an activity, each tool callis a per-type activity (registered via ``BaseNode.as_activity()``,F4.A), and memory persistence happens per turn so a workflow failuremid-loop doesn't lose progress.@@ -29,7 +29,7 @@ User decisions baked in (plan §15):- Memory appends per turn (not on completion).- Tool activity failure (after retries) returns an error to the LLM asa ``ToolMessage`` and the agent continues — matches the in-process- ``_run_agent_loop`` behaviour.+ ``run_native_agent_loop`` behaviour.Determinism:- ``sandboxed=False`` so we can import frozen registry dicts@@ -2433,7 +2433,7 @@ def _serialise_tool_result(result: Any) -> str:"""Return a string body for a ``ToolMessage``.Mirrors the in-process tool-call serialisation in- ``services/ai.py:_run_agent_loop``: feed the LLM the handler's raw+ ``services/agent_runtime.py:run_native_agent_loop``: feed the LLM the handler's rawreturn value (``json.dumps(result, default=str)``), NOT the Temporalactivity envelope. The F4.A per-type activity wraps the handlerresult as ``{"success": bool, "result": {...}, "node_id": ...,diff --git a/server/services/temporal/workflow.py b/server/services/temporal/workflow.pyindex 1517eb5f..76bf613b 100644--- a/server/services/temporal/workflow.py+++ b/server/services/temporal/workflow.py@@ -138,12 +138,12 @@ _SAFE_FROZEN_ROUTING = {# by the 2-minute heartbeat timeout (activities self-heartbeat every# 30s), not by lifetime caps.# Circuit breaker: a failed trigger-spawned run schedules the-# workflow_control.pause_on_failure.v1 activity so the deployment pauses+# workflow_control.pause_on_failure activity so the deployment pauses# (user fixes + resumes) instead of the trigger firing into the same# error indefinitely. The WORKFLOW_CONTROL_PAUSE_ON_FAILURE knob is# evaluated on the activity side, so flipping config never touches-# recorded workflow commands; this patch only gates the activity-# scheduling itself for replay compatibility with older histories.+# recorded workflow commands. The scheduling itself is not behind a+# workflow.patched guard.# start_to_close for node activities. Generous by# design: a single node step (agent turn batch, browser op, long shell# command) may run for hours; worker-death detection is the heartbeatdiff --git a/server/tests/credentials/test_credential_catalogue_shape.py b/server/tests/credentials/test_credential_catalogue_shape.pynew file mode 100644index 00000000..d06be6fc--- /dev/null+++ b/server/tests/credentials/test_credential_catalogue_shape.py@@ -0,0 +1,96 @@+"""Pytest invariant: every catalogue provider lives under ``providers``.++``services.credential_registry.CredentialRegistry`` reads ONLY+``raw["providers"]`` from ``config/credential_providers.json``. A provider+object accidentally written as a sibling of ``providers`` at the JSON root+parses fine, passes ``json.load``, and simply never becomes a credential+tile — which is exactly how DeepL shipped without one. This test locks the+file's top-level shape and cross-checks the registered credential classes+against the resolved catalogue so the mistake fails CI instead of silently+dropping a provider from the modal.+"""++from __future__ import annotations++import json+from pathlib import Path++import pytest+++pytestmark = pytest.mark.credentials+++SERVER_DIR = Path(__file__).resolve().parents[2]+CONFIG_PATH = SERVER_DIR / "config" / "credential_providers.json"++# The only keys the file may carry at its root. Metadata + the two+# sections the registry actually reads (``categories`` / ``providers``).+EXPECTED_TOP_LEVEL_KEYS = frozenset({"version", "last_updated", "_description", "categories", "providers"})+++def _load_raw() -> dict:+ return json.loads(CONFIG_PATH.read_text(encoding="utf-8"))+++class TestTopLevelShape:+ def test_top_level_keys_are_exactly_the_expected_set(self):+ raw = _load_raw()+ actual = frozenset(raw.keys())+ stray = actual - EXPECTED_TOP_LEVEL_KEYS+ missing = EXPECTED_TOP_LEVEL_KEYS - actual+ assert not stray, (+ f"Unexpected top-level keys in credential_providers.json: {sorted(stray)}. "+ "Provider objects must live under 'providers' — the registry never reads root-level siblings."+ )+ assert not missing, f"Missing top-level keys in credential_providers.json: {sorted(missing)}"++ def test_no_provider_shaped_object_at_root(self):+ """A root-level object carrying ``fields`` / ``kind`` / ``extends`` is+ a provider that fell outside ``providers``."""+ raw = _load_raw()+ provider_markers = {"fields", "kind", "extends", "category"}+ for key, value in raw.items():+ if key == "providers" or not isinstance(value, dict):+ continue+ if key == "categories":+ continue+ assert not (provider_markers & set(value)), (+ f"Root-level key {key!r} looks like a provider entry ({sorted(provider_markers & set(value))}); "+ "move it inside 'providers'."+ )+++class TestRegisteredCredentialsHaveCatalogueTiles:+ def test_deepl_resolves_through_the_real_registry(self):+ from services.credential_registry import CredentialRegistry++ registry = CredentialRegistry() # fresh instance, not the singleton+ entry = registry.get_provider("deepl")+ assert entry is not None, "DeepL must resolve from providers via CredentialRegistry.get_provider"+ assert entry["name"] == "DeepL"+ # ``extends: _ai_base`` merges ``fields`` BY KEY, so the child must+ # override the base's ``apiKey`` field rather than declare a second+ # key — otherwise the tile renders two inputs.+ assert [f["key"] for f in entry["fields"]] == ["apiKey"]+ assert entry["fields"][0]["secret"] is True+ assert entry["fields"][0]["placeholder"].endswith("[:fx]")+ ids = [p["id"] for p in registry.get_all_providers()]+ assert "deepl" in ids++ def test_every_registered_credential_with_a_catalogue_key_is_under_providers(self):+ """For each ``Credential`` subclass id in ``CREDENTIAL_REGISTRY``: if the+ JSON mentions that id as a key ANYWHERE at the root, it must be the+ ``providers`` section that carries it. Registered credentials without+ any catalogue entry are allowed (some are declared inline by nodes+ that share another provider's stored key)."""+ import nodes # noqa: F401 — triggers plugin discovery + credential registration+ from services.plugin.credential import CREDENTIAL_REGISTRY++ raw = _load_raw()+ providers = raw["providers"]+ misplaced = sorted(cid for cid in CREDENTIAL_REGISTRY if cid in raw and cid not in providers)+ assert not misplaced, f"Credential ids present at the JSON root instead of under 'providers': {misplaced}"+ # DeepL specifically must have a tile.+ assert "deepl" in CREDENTIAL_REGISTRY+ assert "deepl" in providersdiff --git a/server/tests/nodes/test_data_source_node.py b/server/tests/nodes/test_data_source_node.pyindex 5811366e..937e8849 100644--- a/server/tests/nodes/test_data_source_node.py+++ b/server/tests/nodes/test_data_source_node.py@@ -64,7 +64,6 @@ class TestSpecInvariants:def test_ui_hints(self):hints = DataSourceNode.ui_hints- assert hints["isToolPanel"] is Trueassert hints["isDataPanel"] is Trueassert hints["hideRunButton"] is Truediff --git a/server/tests/services/test_tool_input_security.py b/server/tests/services/test_tool_input_security.pyindex ee9468ed..6239ee0c 100644--- a/server/tests/services/test_tool_input_security.py+++ b/server/tests/services/test_tool_input_security.py@@ -48,7 +48,7 @@ class _ConfiguredToolNode(ToolNode, abstract=True):"role": "tools",},)- ui_hints = {"isToolPanel": True}+ ui_hints = {"hideRunButton": True}Params = _ConfiguredToolParamsToolInput = _ConfiguredToolParamsOutput = _ConfiguredToolOutputdiff --git a/server/tests/test_node_spec.py b/server/tests/test_node_spec.pyindex 5e61e20d..1c2090c0 100644--- a/server/tests/test_node_spec.py+++ b/server/tests/test_node_spec.py@@ -928,11 +928,10 @@ class TestNodeSpecContractInvariants:"isMemoryToolPanel","isContextPanel","isDataPanel",- "isToolPanel","requiresContext","systemManaged",# writeTodos: render the editable Current Todos manager in the- # middle section (in addition to isToolPanel).+ # middle section."isTodoEditor","isMonitorPanel","isTaskManagerPanel",@@ -947,7 +946,6 @@ class TestNodeSpecContractInvariants:# request budget instead of keeping its own list of slow types."executionTimeoutMs","showLocationPanel",- "isAndroidToolkit","isChatTrigger","isConsoleSink","hasSkills",@@ -1124,20 +1122,6 @@ class TestWave10GContractInvariants:hints = spec.get("uiHints") or {}assert hints.get("hasSkills") is True, f"{t}: componentKind=agent must declare uiHints.hasSkills=True"- def test_every_tool_kind_declares_isToolPanel(self):- """Every dedicated tool node (componentKind='tool') must emit- `uiHints.isToolPanel=True` so MiddleSection renders the- ToolSchemaEditor. Dual-purpose nodes (group includes 'tool' but- componentKind='square') don't show the editor — they render as- normal squares and become tools only when wired to an agent's- input-tools handle."""- for t in self._plugin_types():- spec = get_node_spec(t)- if spec.get("componentKind") != "tool":- continue- hints = spec.get("uiHints") or {}- assert hints.get("isToolPanel") is True, f"{t}: componentKind=tool must declare uiHints.isToolPanel=True"-def test_google_workspace_nodes_have_operation_gating(self):"""Drive / Sheets / Tasks / Contacts / Gmail all have an`operation` discriminator; at least one sub-field must hide