Skip to content

Self-improving AI Employees for everyone

fix(plugin): register node class before metadata projection

trohitg95249a1676a2
diff --git a/server/services/node_registry.py b/server/services/node_registry.py
index ad5b7114..08d37a86 100644
--- a/server/services/node_registry.py
+++ b/server/services/node_registry.py
@@ -96,10 +96,13 @@ def registered_node_types() -> frozenset[str]:
def register_node_class(node_cls: type) -> None:
"""Store a :class:`services.plugin.BaseNode` subclass reference.
- Called from ``BaseNode.__init_subclass__`` after the eager
- ``register_node(...)`` write. Lets Wave 11.F's Temporal worker walk
- ``_NODE_CLASS_REGISTRY.values()`` to collect ``cls.as_activity()``
- for registration, without re-discovering via the filesystem.
+ Called from ``BaseNode.__init_subclass__`` BEFORE the eager
+ ``register_node(...)`` write so that ``_metadata_dict()`` (which
+ runs as the ``metadata`` argument) can resolve the plugin folder
+ via :func:`get_node_class` to locate ``icon.svg``. Also lets
+ Wave 11.F's Temporal worker walk ``_NODE_CLASS_REGISTRY.values()``
+ to collect ``cls.as_activity()`` for registration, without
+ re-discovering via the filesystem.
"""
if not getattr(node_cls, "type", ""):
return
diff --git a/server/services/plugin/base.py b/server/services/plugin/base.py
index 8ddcca4a..9984742a 100644
--- a/server/services/plugin/base.py
+++ b/server/services/plugin/base.py
@@ -177,7 +177,14 @@ class BaseNode:
if "hide_output_handle" not in cls.__dict__:
cls.hide_output_handle = True
# Eager registry write — same four registries as @register_node.
+ # ORDER MATTERS: register_node_class MUST precede register_node so
+ # that cls._metadata_dict() (evaluated as the metadata argument)
+ # can resolve the plugin folder via get_node_class(cls.type) inside
+ # get_plugin_icon_path. Without this order the icon falls through
+ # to visuals.json — defeating the per-plugin icon.svg endpoint
+ # (RFC §6.5 / Phase 6).
from services.node_registry import register_node, register_node_class
+ register_node_class(cls)
register_node(
type=cls.type,
metadata=cls._metadata_dict(),
@@ -185,7 +192,6 @@ class BaseNode:
output_model=cls.Output if cls.Output is not _EmptyOutput else None,
handler=cls._make_legacy_handler(),
)
- register_node_class(cls)
# ---- metadata projection ---------------------------------------------