Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
fix(mobile): route Gemini Express credentials through Vertex
trohitga3d3513f68e6
diff --git a/docs/mobile-workspace.md b/docs/mobile-workspace.mdindex 3ebfa29f..1de5412b 100644--- a/docs/mobile-workspace.md+++ b/docs/mobile-workspace.md@@ -61,6 +61,8 @@ Both Mobile Agent and Android use this order:The selected model serves every mobile-use stage. OpenAI, Anthropic and Gemini are supported. An unsupported or missing global selection gives an actionable error; it never silently selects a different provider. Credentials always come from stored provider settings. Android’s AI-visible tool schema remains prompt-only, so an agent cannot override model selection or saved execution limits through tool arguments.+Gemini backend selection follows the main AI agent: Vertex AI Express credentials use Vertex, and Developer API credentials use the Gemini Developer API. The isolated phone worker receives an explicit backend setting derived from the stored credential; it does not inherit an unrelated host setting. Terminal events include `model_backend=vertex_express` or `model_backend=gemini_developer`, without printing the credential. A rejected Android tool result is shown as a failed node, even though the handled error is returned to its calling AI agent.+## Runtime files and Git`mobile_root()` currently resolves a relative `DATA_DIR` against the backend process’s working directory. With source development launched from `server/` and `DATA_DIR=.opencompany`, the installed phone is therefore under `server/.opencompany/mobile/`. This differs from the application’s canonical repository-relative data resolver. An absolute `DATA_DIR` avoids this ambiguity. Do not move an existing installation or switch its data directory while the backend is running.diff --git a/server/nodes/mobile/_diagnostics.py b/server/nodes/mobile/_diagnostics.pyindex 9dd6b05f..6874fda5 100644--- a/server/nodes/mobile/_diagnostics.py+++ b/server/nodes/mobile/_diagnostics.py@@ -15,7 +15,7 @@ _logger = logging.Logger("opencompany.mobile.diagnostics")_logger.setLevel(logging.INFO)_logger.propagate = False_fields = {"operation", "duration_ms", "error_type", "code", "serial", "run_id", "node_id", "workflow_id", "state",- "execution_id", "provider", "model", "stage", "http_status", "provider_status", "steps", "exit_code", "engine_trace"}+ "execution_id", "provider", "model", "model_backend", "stage", "http_status", "provider_status", "steps", "exit_code", "engine_trace"}def event(name: str, *, failed: bool = False, **fields) -> None:diff --git a/server/nodes/mobile/_node.py b/server/nodes/mobile/_node.pyindex 0e3b3854..966813e9 100644--- a/server/nodes/mobile/_node.py+++ b/server/nodes/mobile/_node.py@@ -104,7 +104,13 @@ async def resolve_model(ctx: NodeContext, params: MobileParams | None = None) ->raise NodeUserError("Connect the selected model provider in Settings before running Mobile")model = selected_model or await get_default_model_async(provider_ref, database)provider, variable = adapters[provider_ref]- return {"provider": provider, "model": model, "model_env": {variable: key}}+ model_env = {variable: key}+ if provider_ref == "gemini":+ from services.llm.vertex import is_vertex_express_key++ # Match native Gemini routing; do not inherit a host's backend mode.+ model_env["GOOGLE_GENAI_USE_VERTEXAI"] = "true" if is_vertex_express_key(key) else "false"+ return {"provider": provider, "model": model, "model_env": model_env}class MobileUseAgent(ActionNode):diff --git a/server/nodes/mobile/_runtime.py b/server/nodes/mobile/_runtime.pyindex fd942b9f..9343abe2 100644--- a/server/nodes/mobile/_runtime.py+++ b/server/nodes/mobile/_runtime.py@@ -614,6 +614,8 @@ class MobileRuntime:scope = {"run_id": (self.active or {}).get("run_id"), "workflow_id": (self.active or {}).get("workflow_id"),"node_id": (self.active or {}).get("node_id"), "execution_id": (self.active or {}).get("execution_id"),"provider": config.get("provider"), "model": config.get("model")}+ if config.get("provider") == "google":+ scope["model_backend"] = "vertex_express" if config.get("model_env", {}).get("GOOGLE_GENAI_USE_VERTEXAI") == "true" else "gemini_developer"event("engine_starting", **scope)async def read():diff --git a/server/nodes/mobile/_tool.py b/server/nodes/mobile/_tool.pyindex a22a6db3..67e7c9de 100644--- a/server/nodes/mobile/_tool.py+++ b/server/nodes/mobile/_tool.py@@ -39,6 +39,14 @@ class AndroidTool(ToolNode):ToolInput = AndroidTaskInputOutput = MobileOutput+ @classmethod+ def interpret_result(cls, result):+ # Agent tool invocation flattens failures to {"error": ...}. Do not+ # report a rejected Android task as a successful Temporal activity.+ if isinstance(result, dict) and "success" not in result and result.get("error"):+ return False, result, str(result["error"])+ return super().interpret_result(result)+@Operation("execute")async def execute_op(self, ctx: NodeContext, params: AndroidTaskInput | MobileParams) -> dict:config = ctx.raw.get("_tool_config")diff --git a/server/tests/test_android_tool.py b/server/tests/test_android_tool.pyindex 09c76184..8160b12d 100644--- a/server/tests/test_android_tool.py+++ b/server/tests/test_android_tool.py@@ -21,6 +21,13 @@ def test_android_is_discoverable_as_a_tool():AndroidTaskInput(prompt="Open settings", workflow_id="other")+def test_android_tool_failure_is_not_reported_as_success():+ result = {"error": "The model provider denied access. (HTTP 403)"}+ assert AndroidTool.interpret_result(result) == (False, result, result["error"])+ success = {"response": "Done", "run_id": "run", "outcome": "completed"}+ assert AndroidTool.interpret_result(success) == (True, success, None)++async def test_tool_uses_saved_limits_and_existing_mobile_pipeline(monkeypatch):runtime = SimpleNamespace(run=AsyncMock(return_value={"response": "Done", "run_id": "test", "outcome": "completed"}),ensure_broker=AsyncMock(return_value="http://127.0.0.1/private"))diff --git a/server/tests/test_mobile_integration.py b/server/tests/test_mobile_integration.pyindex 53f65e8a..6efce51c 100644--- a/server/tests/test_mobile_integration.py+++ b/server/tests/test_mobile_integration.py@@ -32,7 +32,7 @@ async def test_connector_uses_saved_model_and_only_selected_key(monkeypatch):monkeypatch.setattr(registry, "get_node_class", lambda _: SimpleNamespace(component_kind="model"))monkeypatch.setattr(constants, "detect_ai_provider", lambda *_: "gemini")config = await _node.resolve_model(context())- assert config == {"provider": "google", "model": "chosen-model", "model_env": {"GOOGLE_API_KEY": "resolved-secret"}}+ assert config == {"provider": "google", "model": "chosen-model", "model_env": {"GOOGLE_API_KEY": "resolved-secret", "GOOGLE_GENAI_USE_VERTEXAI": "false"}}auth.get_api_key.assert_awaited_once_with("gemini", "default")diff --git a/server/tests/test_mobile_models.py b/server/tests/test_mobile_models.pyindex c8d7e049..0826f198 100644--- a/server/tests/test_mobile_models.py+++ b/server/tests/test_mobile_models.py@@ -33,7 +33,7 @@ async def test_global_selection_is_read_fresh_and_ignores_drag_defaults(models):db, auth = modelsparams = MobileParams(provider="openrouter", model="old-drag-default")result = await resolve_model(context(), params)- assert result == {"provider": "google", "model": "global-vision", "model_env": {"GOOGLE_API_KEY": "selected-key"}}+ assert result == {"provider": "google", "model": "global-vision", "model_env": {"GOOGLE_API_KEY": "selected-key", "GOOGLE_GENAI_USE_VERTEXAI": "false"}}db.get_user_settings.assert_awaited_once_with("default")auth.get_api_key.assert_awaited_once_with("gemini", "default")db.get_user_settings.return_value = {"default_llm_provider": "openai", "default_llm_model": "new-global"}@@ -86,3 +86,24 @@ async def test_missing_key_is_actionable(models):async def test_blank_custom_model_uses_provider_default(models):result = await resolve_model(context(), MobileParams(model_source="custom", provider="openai"))assert result["model"] == "provider-default"++[email protected]("key,mode", [("AQ.synthetic-express-key", "true"), ("AIza-synthetic-developer-key", "false")])[email protected]("source", ["global", "custom", "connected"])+async def test_gemini_backend_matches_saved_key_type(models, monkeypatch, key, mode, source):+ import constants+ db, auth = models+ auth.get_api_key.return_value = key+ ctx = context()+ params = MobileParams()+ if source == "custom":+ params = MobileParams(model_source="custom", provider="gemini", model="chosen-model")+ elif source == "connected":+ monkeypatch.setattr(constants, "detect_ai_provider", lambda *_: "gemini")+ db.get_node_parameters.return_value = {"model": "chosen-model"}+ ctx.nodes = [{"id": "model", "type": "geminiChatModel"}]+ ctx.edges = [{"source": "model", "target": "phone", "targetHandle": "input-model"}]+ monkeypatch.setenv("GOOGLE_GENAI_USE_VERTEXAI", "false" if mode == "true" else "true")+ result = await resolve_model(ctx, params)+ assert result["provider"] == "google"+ assert result["model_env"] == {"GOOGLE_API_KEY": key, "GOOGLE_GENAI_USE_VERTEXAI": mode}