Skip to content

Self-improving AI Employees for everyone

fix: remove duplicate Temporal status broadcasts that overwrite node output

trohitgc33bb365e71c
diff --git a/server/routers/workflow.py b/server/routers/workflow.py
index fc583360..e03a009e 100644
--- a/server/routers/workflow.py
+++ b/server/routers/workflow.py
@@ -153,7 +153,7 @@ async def broadcast_status_for_temporal(request: BroadcastStatusRequest):
This endpoint allows Temporal activities to send status updates
to connected WebSocket clients during workflow execution.
"""
- print(f"[Broadcast] {request.node_id} -> {request.status} (workflow={request.workflow_id})")
+ logger.debug(f"Broadcast: {request.node_id} -> {request.status} (workflow={request.workflow_id})")
broadcaster = get_status_broadcaster()
await broadcaster.update_node_status(
@@ -176,9 +176,7 @@ async def execute_node_for_temporal(
This is a simplified endpoint for Temporal activities to call.
It extracts context and delegates to the existing execute_node method.
"""
- print(f"[Temporal Endpoint] Received request for node: {request.node_id} (type={request.node_type})")
- print(f"[Temporal Endpoint] Data: {request.data}")
- print(f"[Temporal Endpoint] Context keys: {list(request.context.keys())}")
+ logger.debug(f"Temporal execute_node: {request.node_id} (type={request.node_type})")
context = request.context
try:
diff --git a/server/services/temporal/activities.py b/server/services/temporal/activities.py
index c79e91a5..3b5a783b 100644
--- a/server/services/temporal/activities.py
+++ b/server/services/temporal/activities.py
@@ -142,25 +142,12 @@ class NodeExecutionActivities:
result["node_type"] = node_type
result["timestamp"] = datetime.now().isoformat()
- # Broadcast result status
+ # Status is already broadcast by the WebSocket handler (handle_execute_node)
+ # which calls both update_node_status and update_node_output.
+ # Do NOT duplicate here - late-arriving broadcasts overwrite output data.
if result.get("success"):
- await self._broadcast_status(
- node_id=node_id,
- status="success",
- data={
- "result": result.get("result"),
- "execution_time": result.get("execution_time"),
- },
- workflow_id=workflow_id,
- )
activity.logger.info(f"Node {node_id} completed successfully")
else:
- await self._broadcast_status(
- node_id=node_id,
- status="error",
- data={"error": result.get("error")},
- workflow_id=workflow_id,
- )
activity.logger.warning(f"Node {node_id} failed: {result.get('error')}")
# Heartbeat for activity liveness