Skip to content

Self-improving AI Employees for everyone

fix(temporal): a re-arm refreshes a known listener's snapshot (1b.32)

trohitgded22c7dcbc8
diff --git a/docs-internal/temporal-workflow-control.md b/docs-internal/temporal-workflow-control.md
index 7529423e..e95485a1 100644
--- a/docs-internal/temporal-workflow-control.md
+++ b/docs-internal/temporal-workflow-control.md
@@ -652,7 +652,9 @@ the control plane is hardened against Temporal's per-run event-history ceiling
from the persisted graph snapshot — DeploymentManager runtime state,
in-process collectors for non-canary trigger types, and the paused posture
(admission, trigger pause flags, cron schedule pause). Re-arm is idempotent:
- controller `register_trigger` is keyed by listener id, legacy listener
+ controller `register_trigger` is keyed by listener id (a known listener takes
+ only the re-sent parameter snapshot, sanitized at the deploy funnel, so a
+ generation started before the sanitizer drops its raw snapshot), legacy listener
starts use `USE_EXISTING`, cron schedule creation preserves server-owned
pause state, and a Start node fires once per generation (its first fire
records a `generation_start` claim in the runtime mutation ledger, which
diff --git a/server/services/deployment/handlers.py b/server/services/deployment/handlers.py
index 7d69d054..8cb63cde 100644
--- a/server/services/deployment/handlers.py
+++ b/server/services/deployment/handlers.py
@@ -1779,7 +1779,8 @@ async def _rearm_generation(control) -> None:
"""Re-establish process-local deployment state for a durable generation.
Idempotent by construction: canary triggers re-register with the
- controller keyed by listener id (no-op when already known), legacy
+ controller keyed by listener id (a known listener takes only the
+ re-sent, sanitized parameter snapshot), legacy
listener starts use ``id_conflict_policy=USE_EXISTING``, and cron
schedule creation preserves server-owned paused state on redeploy.
In-process collectors for non-canary trigger types are re-armed
diff --git a/server/services/temporal/workflow_control_workflow.py b/server/services/temporal/workflow_control_workflow.py
index b300f1b1..42469a77 100644
--- a/server/services/temporal/workflow_control_workflow.py
+++ b/server/services/temporal/workflow_control_workflow.py
@@ -326,6 +326,12 @@ class WorkflowControlWorkflow:
async def register_trigger(self, spec: Dict[str, Any]) -> None:
listener_id = str(spec["listener_id"])
if listener_id in self._triggers:
+ # A re-arm sends the generation's parameter snapshot again, as the
+ # deploy funnel sanitized it. Take it in place (poll loops hold
+ # this dict); the rest of the first registration stands.
+ snapshot = spec.get("listener_args", {}).get("parameter_snapshot")
+ if snapshot is not None:
+ self._triggers[listener_id].get("listener_args", {})["parameter_snapshot"] = snapshot
return
self._triggers[listener_id] = spec
if spec["workflow_type"] == "PollingTriggerWorkflow":
diff --git a/server/tests/temporal/test_controller_messaging.py b/server/tests/temporal/test_controller_messaging.py
index 3f24c6f6..6287837a 100644
--- a/server/tests/temporal/test_controller_messaging.py
+++ b/server/tests/temporal/test_controller_messaging.py
@@ -280,6 +280,35 @@ async def test_graph_message_preserves_existing_hashable_id_contract(runtime):
assert controller._triggers["listener"]["listener_args"]["nodes"] == graph["nodes"]
+async def test_a_rearm_refreshes_a_known_listeners_snapshot_in_place(runtime):
+ # 1b.32: a generation started before the deploy funnel sanitized its
+ # snapshot drops the raw one at its next re-arm.
+ controller = WorkflowControlWorkflow(control_data(triggers={
+ "listener": {
+ "listener_id": "listener", "workflow_type": "TriggerListenerWorkflow", "trigger_node_id": "trigger",
+ "listener_args": {
+ "nodes": [{"id": "trigger"}], "edges": [],
+ "parameter_snapshot": {"http": {"headers": {"Authorization": "Bearer raw"}}},
+ },
+ },
+ }))
+ stored = controller._triggers["listener"]["listener_args"]
+ rearm = {
+ "listener_id": "listener", "workflow_type": "TriggerListenerWorkflow", "trigger_node_id": "trigger",
+ "listener_args": {"nodes": [], "edges": [], "parameter_snapshot": {"http": {}}},
+ }
+
+ await controller.register_trigger(rearm)
+
+ assert controller._triggers["listener"]["listener_args"] is stored
+ assert stored == {"nodes": [{"id": "trigger"}], "edges": [], "parameter_snapshot": {"http": {}}}
+
+ await controller.register_trigger({**rearm, "listener_args": {"nodes": []}})
+
+ assert stored["parameter_snapshot"] == {"http": {}}
+ assert not runtime
+
+
def test_controller_registers_read_only_control_and_membership_validators():
definitions = WorkflowControlWorkflow.__temporal_workflow_definition.updates
for name in ("set_control_state", "wait_for_checkpoint", "register_execution", "unregister_execution", "replace_graph"):