Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
fix(twitter): refuse Twitter Receive instead of never firing
trohitgedf29a76382c
diff --git a/docs-internal/node-logic-flows/twitter/twitterReceive.md b/docs-internal/node-logic-flows/twitter/twitterReceive.mdindex d024c338..af3811d3 100644--- a/docs-internal/node-logic-flows/twitter/twitterReceive.md+++ b/docs-internal/node-logic-flows/twitter/twitterReceive.md@@ -3,13 +3,23 @@| Field | Value ||------|-------|| **Category** | social / trigger |-| **Backend handler** | Plugin [`server/nodes/twitter/twitter_receive/__init__.py`](../../../server/nodes/twitter/twitter_receive/__init__.py); `execute()` delegates to [`server/services/handlers/triggers.py::handle_trigger_node`](../../../server/services/handlers/triggers.py) (generic). Filter: [`server/nodes/twitter/_filters.py::build_filter`](../../../server/nodes/twitter/_filters.py). Events: [`server/nodes/twitter/_events.py`](../../../server/nodes/twitter/_events.py). |+| **Backend handler** | Plugin [`server/nodes/twitter/twitter_receive/__init__.py`](../../../server/nodes/twitter/twitter_receive/__init__.py); `execute()` refuses with a `NodeUserError` and `validate_graph` refuses Start (see the status note below). Filter: [`server/nodes/twitter/_filters.py::build_filter`](../../../server/nodes/twitter/_filters.py). Events: [`server/nodes/twitter/_events.py`](../../../server/nodes/twitter/_events.py). || **Tests** | [`server/tests/nodes/test_twitter.py`](../../../server/tests/nodes/test_twitter.py) || **Skill (if any)** | none || **Dual-purpose tool** | no (trigger only) |## Purpose+> **Status (2026-10-23, RFC-0005 Phase 0.8): the node refuses to run.** Nothing+> polls Twitter for it: it is not a `PollingTriggerNode`, and+> `dispatch_twitter_event_received` has no caller, so a deployed one never fired+> and a canvas Run waited forever. Start now refuses it with+> `TWITTER_RECEIVE_UNAVAILABLE`, and a canvas Run returns a `NodeUserError`+> pointing to Twitter Search on a Cron Scheduler. Making it work means+> subclassing `PollingTriggerNode` with `fetch_ids` / `fetch_detail` over the X+> API's mentions, search and timeline endpoints (paid and rate-limited). The+> rest of this card describes the intended design.+Wait for a Twitter/X event (mention, search match, or timeline update) and emitit as the workflow trigger payload. The trigger is polling-based (X API v2 hasno push webhooks on the free tier); polling is driven by the deployment layerdiff --git a/server/nodes/twitter/twitter_receive/__init__.py b/server/nodes/twitter/twitter_receive/__init__.pyindex 72b8a484..9842c9ce 100644--- a/server/nodes/twitter/twitter_receive/__init__.py+++ b/server/nodes/twitter/twitter_receive/__init__.py@@ -1,4 +1,11 @@-"""Twitter Receive — Wave 11.C migration (polling trigger)."""+"""Twitter Receive — Wave 11.C migration (polling trigger).++Nothing polls Twitter for this node yet: it is not a+``PollingTriggerNode`` and its dispatcher (``_events.dispatch_twitter_event_received``)+has no caller, so a deployed one never fired and a canvas Run waited+forever. Until a poller exists, Start refuses it (``validate_graph``) and+a canvas Run answers with the reason (RFC-0005 Phase 0.8).+"""from __future__ import annotations@@ -6,10 +13,17 @@ from typing import Any, Dict, Literal, Optionalfrom pydantic import BaseModel, ConfigDict, Field-from services.plugin import NodeContext, Operation, TaskQueue, TriggerNode+import time++from services.plugin import NodeContext, NodeUserError, Operation, TaskQueue, TriggerNodefrom .._credentials import TwitterCredential+_UNAVAILABLE = (+ "Twitter Receive cannot run yet: nothing polls Twitter for it, so it would never fire. "+ "To act on new tweets, run Twitter Search from a Cron Scheduler."+)+class TwitterReceiveParams(BaseModel):trigger_type: Literal["mentions", "search", "timeline"] = Field(@@ -52,20 +66,18 @@ class TwitterReceiveNode(TriggerNode):Params = TwitterReceiveParamsOutput = TwitterReceiveOutput+ @classmethod+ def validate_graph(cls, node_id: str, graph: Dict[str, Any]) -> list[Dict[str, Any]]:+ return [{"code": "TWITTER_RECEIVE_UNAVAILABLE", "node_id": node_id, "message": _UNAVAILABLE}]+async def execute(self,node_id: str,parameters: Dict[str, Any],context: NodeContext,) -> Dict[str, Any]:- from services.handlers.triggers import handle_trigger_node-- return await handle_trigger_node(- node_id=node_id,- node_type=self.type,- parameters=parameters,- context=context.raw,- )+ error = NodeUserError(_UNAVAILABLE)+ return self._wrap_error(start_time=time.time(), error=str(error), error_type="NodeUserError", extra=error.as_dict())@Operation("wait")async def wait(self, ctx: NodeContext, params: TwitterReceiveParams) -> TwitterReceiveOutput:diff --git a/server/tests/nodes/test_twitter.py b/server/tests/nodes/test_twitter.pyindex 49ecaf1f..6473eb39 100644--- a/server/tests/nodes/test_twitter.py+++ b/server/tests/nodes/test_twitter.py@@ -14,8 +14,8 @@ External boundaries mocked:fields the handler reads (``.data`` etc.).- ``auth_service.get_oauth_tokens('twitter')`` is fed via``patched_container(auth_oauth_tokens={...})``.- - ``event_waiter`` is patched at both the executor dispatch site and the- generic trigger handler for ``twitterReceive``.+ - ``twitterReceive`` refuses to run until a poller exists, so its tests+ check the refusal."""from __future__ import annotations@@ -484,85 +484,22 @@ class TestTwitterUser:# ============================================================================-def _make_waiter_stub(*, canned_event=None):- """Fake event_waiter module for the trigger path."""- waiter_obj = MagicMock(name="Waiter")- waiter_obj.id = "waiter-twitter-id"-- stub = MagicMock(name="event_waiter_module")- stub.is_trigger_node = MagicMock(return_value=True)- stub.get_trigger_config = MagicMock(- return_value=MagicMock(- node_type="twitterReceive",- event_type="twitter_event_received",- display_name="Twitter Event",- )- )- stub.register = AsyncMock(return_value=waiter_obj)- stub.wait_for_event = AsyncMock(return_value=canned_event or {})- stub.run_trigger_precheck = AsyncMock(return_value=None)- stub.get_backend_mode = MagicMock(return_value="asyncio.Future")- stub.cancel = MagicMock(return_value=True)- stub.dispatch = MagicMock(return_value=1)- return stub--class TestTwitterReceive:- CANNED = {- "trigger_type": "mentions",- "tweet_id": "tw123",- "text": "@me hello",- "author_id": "u999",- "author_username": "alice",- "created_at": "2026-04-15T12:00:00",- }-- async def test_happy_path_returns_canned_event(self, harness):- waiter = _make_waiter_stub(canned_event=self.CANNED)+ """Nothing polls Twitter for twitterReceive yet, so it refuses to run+ instead of waiting forever (RFC-0005 Phase 0.8)."""- with patched_broadcaster(), patch("services.handlers.triggers.event_waiter", waiter):- result = await harness.execute(- "twitterReceive",- {"trigger_type": "mentions", "poll_interval": 60},- )-- harness.assert_envelope(result, success=True)- payload = result["result"]- assert payload["tweet_id"] == "tw123"- assert payload["author_username"] == "alice"- waiter.register.assert_awaited_once()- waiter.wait_for_event.assert_awaited_once()-- async def test_cancellation_returns_error_envelope(self, harness):- import asyncio-- waiter = _make_waiter_stub()- waiter.wait_for_event = AsyncMock(side_effect=asyncio.CancelledError())-- with patched_broadcaster(), patch("services.handlers.triggers.event_waiter", waiter):- result = await harness.execute("twitterReceive", {"trigger_type": "mentions"})-- harness.assert_envelope(result, success=False)- assert "cancel" in result["error"].lower()-- async def test_unknown_trigger_config_errors(self, harness):- # get_trigger_config -> None simulates a missing registry entry.- waiter = _make_waiter_stub()- waiter.get_trigger_config = MagicMock(return_value=None)-- with patched_broadcaster(), patch("services.handlers.triggers.event_waiter", waiter):+ async def test_a_canvas_run_says_why_it_cannot_run(self, harness):+ with patched_broadcaster(), patch("services.handlers.triggers.event_waiter") as waiter:result = await harness.execute("twitterReceive", {"trigger_type": "mentions"})harness.assert_envelope(result, success=False)- assert "unknown trigger" in result["error"].lower()- waiter.register.assert_not_awaited()+ assert result["error_type"] == "NodeUserError"+ assert "cannot run yet" in result["error"]+ waiter.register.assert_not_called()- async def test_generic_exception_becomes_envelope(self, harness):- waiter = _make_waiter_stub()- waiter.wait_for_event = AsyncMock(side_effect=RuntimeError("boom"))+ def test_start_refuses_it(self):+ from nodes.twitter.twitter_receive import TwitterReceiveNode- with patched_broadcaster(), patch("services.handlers.triggers.event_waiter", waiter):- result = await harness.execute("twitterReceive", {"trigger_type": "mentions"})+ errors = TwitterReceiveNode.validate_graph("tw-1", {"nodes": [], "edges": []})- harness.assert_envelope(result, success=False)- assert "boom" in result["error"]+ assert [error["code"] for error in errors] == ["TWITTER_RECEIVE_UNAVAILABLE"]