Skip to content

Self-improving AI Employees for everyone

fix(deploy): keep saved node settings when a generation is re-armed

trohitgf0966791187a
diff --git a/server/services/deployment/handlers.py b/server/services/deployment/handlers.py
index 2a51d0e4..1c9ba421 100644
--- a/server/services/deployment/handlers.py
+++ b/server/services/deployment/handlers.py
@@ -263,11 +263,16 @@ async def handle_deploy_workflow(data: Dict[str, Any], websocket: WebSocket) ->
# Running this before the gate orphaned configuration on a failed deploy:
# the rows were renamed and the originals deleted, while the stored graph
# kept its old ids, so the next read looked up ids that no longer existed.
- await persist_parameter_aliases(
- container.database(),
- aliases=graph_aliases,
- parameters=normalized_parameters,
- )
+ # A generation's deploy writes no rows. Start saved them before it created
+ # the generation, and the restart re-arm passes the generation's sanitized
+ # snapshot, which would replace each saved row and erase its secrets (a
+ # webhook's header value among them) and any edit saved while paused.
+ if int(data.get("generation") or 0) <= 0:
+ await persist_parameter_aliases(
+ container.database(),
+ aliases=graph_aliases,
+ parameters=normalized_parameters,
+ )
if workflow_service.is_workflow_deployed(workflow_id):
status = workflow_service.get_deployment_status(workflow_id)
diff --git a/server/tests/services/test_workflow_parameter_preservation.py b/server/tests/services/test_workflow_parameter_preservation.py
index f0e54e80..e47c34a5 100644
--- a/server/tests/services/test_workflow_parameter_preservation.py
+++ b/server/tests/services/test_workflow_parameter_preservation.py
@@ -276,6 +276,66 @@ async def test_failed_deploy_validation_does_not_rekey_parameters(recording_db,
assert await recording_db.get_node_parameters("legacy-node") == {"prompt": "keep me"}
+async def test_restart_rearm_keeps_saved_node_secrets(recording_db, monkeypatch):
+ """The boot re-arm deploys a generation from its sanitized snapshot.
+
+ That deploy wrote the snapshot over every saved node row, so after the
+ first restart a header-authenticated webhook had lost its header value and
+ answered 401 to every request, and an edit saved while paused went back to
+ its Start value.
+ """
+ import core.container
+ from services.deployment import handlers as deployment_handlers
+
+ workflow_service = SimpleNamespace(
+ is_workflow_deployed=lambda _workflow_id: False,
+ deploy_workflow=AsyncMock(return_value={"success": True, "triggers_setup": [], "deployment_id": "deployment"}),
+ )
+ container_stub = MagicMock()
+ container_stub.database.return_value = recording_db
+ container_stub.workflow_service.return_value = workflow_service
+ monkeypatch.setattr(core.container, "container", container_stub)
+
+ broadcaster = SimpleNamespace(
+ lock_workflow=AsyncMock(return_value=True), unlock_workflow=AsyncMock(), update_node_status=AsyncMock(),
+ update_workflow_status=AsyncMock(), update_deployment_status=AsyncMock(),
+ )
+ broadcaster_stub = types.ModuleType("services.status_broadcaster")
+ broadcaster_stub.get_status_broadcaster = lambda: broadcaster
+ monkeypatch.setitem(sys.modules, "services.status_broadcaster", broadcaster_stub)
+
+ import services.workflow_validator as validator_module
+
+ monkeypatch.setattr(
+ validator_module,
+ "validate_workflow",
+ AsyncMock(return_value={"errors": [], "warnings": []}),
+ )
+ monkeypatch.setattr(deployment_handlers, "_deployment_tasks", {})
+
+ node_id = "1:webhookTrigger:1"
+ saved = {"path": "orders", "header_name": "X-Token", "header_value": "kept-secret"}
+ await recording_db.save_node_parameters(node_id, saved)
+
+ result = await deployment_handlers.handle_deploy_workflow(
+ {
+ "workflow_id": "1",
+ "nodes": [{"id": node_id, "type": "webhookTrigger", "position": {"x": 0, "y": 0}, "data": {}}],
+ "edges": [],
+ # The generation's snapshot, as the re-arm passes it: no secrets.
+ "parameters_by_id": {node_id: {"path": "orders", "header_name": "X-Token"}},
+ "generation": 1,
+ },
+ None,
+ )
+ await deployment_handlers._deployment_tasks["1"]
+
+ assert result["success"] is True
+ assert await recording_db.get_node_parameters(node_id) == saved
+ assert recording_db.deleted_parameter_ids == []
+
+
@pytest.mark.asyncio
async def test_save_preserves_description(patched_handlers):
"""Saving nulled the description because the kwarg was never passed."""