Self-improving AI Employees for everyone
Python ai-agentsai-employeeai-employeesassistantautonomous-agentsco-employeescompanygrok-botinstinctloop-agentsmuseown-your-datapersonalself-hosted
fix(chat): refuse a send that Temporal cannot deliver
trohitgfcda0d283e2f
diff --git a/server/services/chat/handlers.py b/server/services/chat/handlers.pyindex 5a6a0579..d111abd4 100644--- a/server/services/chat/handlers.py+++ b/server/services/chat/handlers.py@@ -49,6 +49,19 @@ logger = get_logger(__name__)PROTOCOL_VERSION = 1_DENIED = {"success": False, "error": "access_denied"}+#: A workflow's chat messages travel through Temporal (``dispatch.emit``+#: signals its listeners) and only a Temporal activity claims their runs, so+#: a send while it is unreachable would be lost.+_UNAVAILABLE = {"success": False, "error": "engine_unavailable"}+++def _engine_connected() -> bool:+ """Whether Temporal is reachable now (the flag ``/health/ready`` reads)."""+ try:+ wrapper = container.temporal_client()+ except Exception: # noqa: BLE001 - not wired: nothing can deliver+ return False+ return bool(wrapper is not None and wrapper.is_connected)def _wire_run(run: Any) -> Dict[str, Any]:@@ -209,7 +222,8 @@ async def _dispatch(async def handle_send_chat_message(data: Dict[str, Any], websocket: WebSocket) -> Dict[str, Any]:"""Save the owner's message, start its run, and dispatch it. Answers``{message_id, run_id, delivery, timestamp}``; ``run_in_progress`` (with- the live ``run_id``), ``not_running``, ``save_failed``, ``access_denied``,+ the live ``run_id``), ``not_running``, ``engine_unavailable`` (Temporal is+ unreachable, nothing saved), ``save_failed``, ``access_denied``,``invalid_request`` or ``ui_event_rejected`` otherwise.With ``ui_event`` the message is a button pressed in an interface the@@ -264,6 +278,8 @@ async def handle_send_chat_message(data: Dict[str, Any], websocket: WebSocket) -delivery = delivery_for(control)if delivery is None:return {"success": False, "error": "not_running"}+ if not _engine_connected():+ return dict(_UNAVAILABLE)track = scope.workflow_id is not None and await _answers_session(database, control, session_id)try:@@ -586,6 +602,8 @@ async def _branch_context(delivery = delivery_for(control)if delivery is None or not await _answers_session(database, control, session_id):return {"success": False, "error": "not_running"}, {}+ if not _engine_connected():+ return dict(_UNAVAILABLE), {}context["delivery"] = deliverycontext["state"] = "queued" if delivery == "queued" else "pending"return None, contextdiff --git a/server/tests/services/chat/conftest.py b/server/tests/services/chat/conftest.pyindex c6b61487..e0221c20 100644--- a/server/tests/services/chat/conftest.py+++ b/server/tests/services/chat/conftest.py@@ -79,7 +79,9 @@ def chat(monkeypatch, database, hub, frames):async def dispatch(event_data, *, workflow_id=None, event_id=None):dispatched.append({"data": dict(event_data), "workflow_id": workflow_id, "event_id": event_id})- monkeypatch.setattr(handlers, "container", SimpleNamespace(database=lambda: database))+ # Temporal, which delivers the messages; a test may disconnect it.+ engine = SimpleNamespace(is_connected=True)+ monkeypatch.setattr(handlers, "container", SimpleNamespace(database=lambda: database, temporal_client=lambda: engine))monkeypatch.setattr(handlers, "dispatch_chat_message_received", dispatch)monkeypatch.setattr(chat_thread, "_CLEARED_LISTENERS", [])- return SimpleNamespace(database=database, hub=hub, frames=frames, dispatched=dispatched, handlers=handlers)+ return SimpleNamespace(database=database, hub=hub, frames=frames, dispatched=dispatched, handlers=handlers, engine=engine)diff --git a/server/tests/services/chat/test_branches.py b/server/tests/services/chat/test_branches.pyindex 43d3d4f3..cc516de4 100644--- a/server/tests/services/chat/test_branches.py+++ b/server/tests/services/chat/test_branches.py@@ -187,6 +187,20 @@ async def test_trying_again_answers_the_same_message_beside_the_old_answer(chat)assert (await chat.handlers.handle_regenerate_chat_reply({"session_id": "wf", "message_id": older}, None))["error"] == "not_found"+async def test_an_edit_or_a_retry_needs_temporal_to_deliver_it(chat):+ first = await conversation(chat)+ shown = (await thread(chat))["messages"]+ before = await revision(chat)+ chat.engine.is_connected = False+ edited = await chat.handlers.handle_edit_chat_message(+ {"session_id": "wf", "message_id": first["message_id"], "message": "Book Sunday", "expected_revision": before}, None+ )+ retried = await chat.handlers.handle_regenerate_chat_reply({"session_id": "wf", "message_id": shown[1]["id"], "expected_revision": before}, None)+ assert edited == retried == {"success": False, "error": "engine_unavailable"}+ # Nothing moved.+ assert await revision(chat) == before and await path(chat) == ["Book Saturday", "Saturday is booked."]++async def test_trying_again_a_message_nothing_answered(chat):await talking(chat.database)sent = await chat.handlers.handle_send_chat_message({"message": "Book Saturday", "session_id": "wf"}, None)diff --git a/server/tests/services/chat/test_handlers.py b/server/tests/services/chat/test_handlers.pyindex aac12324..c315668a 100644--- a/server/tests/services/chat/test_handlers.py+++ b/server/tests/services/chat/test_handlers.py@@ -44,6 +44,23 @@ async def test_a_paused_employee_queues_the_run(chat):assert (await ledger.get_run(chat.database, result["run_id"])).state == "queued"+async def test_nothing_is_saved_when_temporal_cannot_deliver_it(chat):+ # Running or paused, the message would never reach the employee.+ for generation, status in enumerate(("running", "paused"), start=1):+ await talking(chat.database, status=status, generation=generation)+ chat.engine.is_connected = False+ assert await send(chat) == {"success": False, "error": "engine_unavailable"}+ assert await chat.database.read_chat_messages("wf") == []+ assert await ledger.session_runs(chat.database, "wf") == []+ assert chat.dispatched == [] and chat_updates(chat.frames) == []+ chat.engine.is_connected = True+ # The editor's default chat has no workflow and is not refused.+ chat.engine.is_connected = False+ assert (await send(chat, session_id="default"))["success"] is True+ chat.engine.is_connected = True+ assert (await send(chat))["success"] is True++async def test_a_second_message_while_a_run_is_live_is_refused(chat):await talking(chat.database)first = await send(chat)diff --git a/server/tests/services/test_chat_thread.py b/server/tests/services/test_chat_thread.pyindex 7378a4a5..e32f3469 100644--- a/server/tests/services/test_chat_thread.py+++ b/server/tests/services/test_chat_thread.py@@ -66,7 +66,8 @@ def router(monkeypatch, database, frames):async def dispatch(event_data, *, workflow_id=None, event_id=None):dispatched.append((dict(event_data), workflow_id))- monkeypatch.setattr(chat_handlers, "container", SimpleNamespace(database=lambda: database))+ engine = SimpleNamespace(is_connected=True)+ monkeypatch.setattr(chat_handlers, "container", SimpleNamespace(database=lambda: database, temporal_client=lambda: engine))monkeypatch.setattr(chat_handlers, "dispatch_chat_message_received", dispatch)# The Clear's listeners are whatever a test registers, never the plugins'.monkeypatch.setattr(chat_thread, "_CLEARED_LISTENERS", [])