Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix: harden workdir handling

wulien0a315b8863d2
diff --git a/internal/pipeline/workdir.go b/internal/pipeline/workdir.go
index 99f861a7..40fa09bb 100644
--- a/internal/pipeline/workdir.go
+++ b/internal/pipeline/workdir.go
@@ -9,6 +9,7 @@ import (
"strings"
)
+// ResolveWorkdir returns a task ID and work directory, creating workdir/output.
func ResolveWorkdir(input, explicit string) (string, string, error) {
taskID := makeTaskID(input)
workdir := explicit
@@ -48,10 +49,11 @@ func makeTaskID(input string) string {
if base == "" {
base = "task"
}
- return fmt.Sprintf("%s_%s", base, util.GenerateRandStringWithUpperLowerNum(4))
+ return fmt.Sprintf("%s_%s", base, util.GenerateRandStringWithUpperLowerNum(8))
}
func NormalizeInput(input string) string {
+ input = strings.TrimSpace(input)
if strings.HasPrefix(input, "local:") ||
strings.HasPrefix(input, "http://") ||
strings.HasPrefix(input, "https://") {
diff --git a/internal/pipeline/workdir_test.go b/internal/pipeline/workdir_test.go
index ced4fece..e075454c 100644
--- a/internal/pipeline/workdir_test.go
+++ b/internal/pipeline/workdir_test.go
@@ -1,6 +1,7 @@
package pipeline
import (
+ "os"
"path/filepath"
"strings"
"testing"
@@ -21,13 +22,18 @@ func TestResolveWorkdirExplicit(t *testing.T) {
}
func TestResolveWorkdirDefault(t *testing.T) {
+ t.Chdir(t.TempDir())
taskID, workdir, err := ResolveWorkdir("https://www.youtube.com/watch?v=abc123", "")
if err != nil {
t.Fatalf("ResolveWorkdir() error = %v", err)
}
- if !strings.HasPrefix(workdir, filepath.Join("tasks", taskID)) {
+ wantPrefix := filepath.Join("tasks", taskID)
+ if !strings.HasPrefix(workdir, wantPrefix) {
t.Fatalf("workdir = %q does not start with tasks/taskID %q", workdir, taskID)
}
+ if _, err := os.Stat(filepath.Join(workdir, "output")); err != nil {
+ t.Fatalf("workdir output directory stat error = %v", err)
+ }
}
func TestNormalizeLocalInput(t *testing.T) {
@@ -41,6 +47,9 @@ func TestNormalizeLocalInput(t *testing.T) {
if got := NormalizeInput("https://www.bilibili.com/video/BV123"); got != "https://www.bilibili.com/video/BV123" {
t.Fatalf("NormalizeInput(url) = %q", got)
}
+ if got := NormalizeInput(" https://example.com "); got != "https://example.com" {
+ t.Fatalf("NormalizeInput(trimmed url) = %q", got)
+ }
}
func TestMakeTaskIDEmptyInputUsesTaskFallback(t *testing.T) {
@@ -63,3 +72,11 @@ func TestMakeTaskIDUsesEmptyQueryVAsFallback(t *testing.T) {
t.Fatalf("makeTaskID(empty query v) = %q, want task_ prefix", got)
}
}
+
+func TestMakeTaskIDUsesEightCharSuffix(t *testing.T) {
+ got := makeTaskID("abc")
+ parts := strings.Split(got, "_")
+ if len(parts) < 2 || len(parts[len(parts)-1]) != 8 {
+ t.Fatalf("makeTaskID() = %q, want 8-character suffix", got)
+ }
+}