Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix(desktop): measure symlink payloads and trim bundled Node symbols

Leggett27077e00ef22
diff --git a/apps/desktop/scripts/package-directory-size.mjs b/apps/desktop/scripts/package-directory-size.mjs
new file mode 100644
index 00000000..19b75e51
--- /dev/null
+++ b/apps/desktop/scripts/package-directory-size.mjs
@@ -0,0 +1,22 @@
+import { existsSync, lstatSync, readdirSync } from 'node:fs';
+import { join } from 'node:path';
+
+export function treeSize(root) {
+ let total = 0;
+ for (const entry of readdirSync(root, { withFileTypes: true })) {
+ const path = join(root, entry.name);
+ const stat = lstatSync(path);
+ if (stat.isSymbolicLink()) {
+ if (!existsSync(path)) {
+ throw new Error(`Desktop package contains a broken symbolic link: ${path}`);
+ }
+ // Archives store the link target path, not another copy of its contents.
+ total += stat.size;
+ } else if (stat.isDirectory()) {
+ total += treeSize(path);
+ } else if (stat.isFile()) {
+ total += stat.size;
+ }
+ }
+ return total;
+}
diff --git a/apps/desktop/scripts/prepare-creator-node.mjs b/apps/desktop/scripts/prepare-creator-node.mjs
new file mode 100644
index 00000000..4afe0c56
--- /dev/null
+++ b/apps/desktop/scripts/prepare-creator-node.mjs
@@ -0,0 +1,8 @@
+import { execFileSync } from 'node:child_process';
+
+export function stripMacNodeRuntime(path) {
+ execFileSync('strip', ['-S', '-x', path], { stdio: 'inherit' });
+ // Stripping invalidates the vendor signature. Restore execution before the
+ // release signing hook applies Developer ID and the Node JIT entitlements.
+ execFileSync('codesign', ['--force', '--sign', '-', path], { stdio: 'inherit' });
+}
diff --git a/apps/desktop/scripts/prepare-creator-runtime.mjs b/apps/desktop/scripts/prepare-creator-runtime.mjs
index f3a2e29a..2013021d 100644
--- a/apps/desktop/scripts/prepare-creator-runtime.mjs
+++ b/apps/desktop/scripts/prepare-creator-runtime.mjs
@@ -19,6 +19,7 @@ import { dirname, join, relative, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import * as fontkit from 'fontkit';
import { verifyRuntimeExecutable } from './runtime-executable-check.mjs';
+import { stripMacNodeRuntime } from './prepare-creator-node.mjs';
const scriptDir = dirname(fileURLToPath(import.meta.url));
const desktopDir = resolve(scriptDir, '..');
@@ -103,6 +104,7 @@ const buildRecord = {
join(rootDir, 'scripts', 'build-krillinai.mjs'),
join(scriptDir, 'install-creator-runtime-dependencies.mjs'),
join(scriptDir, 'prepare-creator-runtime.mjs'),
+ join(scriptDir, 'prepare-creator-node.mjs'),
join(rootDir, 'apps', 'daemon', 'src', 'creator', 'krillin', 'adapter.ts'),
join(rootDir, 'apps', 'daemon', 'src', 'creator', 'krillin', 'cli-runner.ts'),
join(rootDir, 'apps', 'daemon', 'src', 'creator', 'krillin', 'config-bridge.ts'),
@@ -474,6 +476,9 @@ function prepareYtDlpJavascriptRuntime(vendorVersions) {
rmSync(extractionRoot, { recursive: true, force: true });
}
}
+ if (targetPlatform === 'darwin' && process.platform === 'darwin') {
+ stripMacNodeRuntime(executable);
+ }
if (targetPlatform === process.platform && targetArch === process.arch) {
verifyRuntimeExecutable({ name: 'yt-dlp Node runtime', path: executable,
args: ['--version'], expected: /^v(?:2[2-9]|[3-9]\d)\./, timeoutMs: 20_000 });
diff --git a/apps/desktop/scripts/verify-package.mjs b/apps/desktop/scripts/verify-package.mjs
index b1bd9dce..3dbb82ea 100644
--- a/apps/desktop/scripts/verify-package.mjs
+++ b/apps/desktop/scripts/verify-package.mjs
@@ -28,6 +28,7 @@ import { homedir, tmpdir } from 'node:os';
import { basename, dirname, join, relative, resolve } from 'node:path';
import { spawnSync } from 'node:child_process';
import { fileURLToPath } from 'node:url';
+import { treeSize } from './package-directory-size.mjs';
import { verifyCreatorRuntime } from './creator-runtime-contract.mjs';
import { verifyCodexRuntime } from './codex-runtime-contract.mjs';
import {
@@ -1005,15 +1006,6 @@ function assertSize(label, path, maxBytes) {
}
}
-function treeSize(root) {
- let total = 0;
- walk(root, path => {
- const stat = statSync(path);
- if (stat.isFile()) total += stat.size;
- });
- return total;
-}
-
function walk(root, visitor) {
for (const entry of readdirSync(root, { withFileTypes: true })) {
const path = join(root, entry.name);
diff --git a/apps/desktop/test/package-directory-size.test.mjs b/apps/desktop/test/package-directory-size.test.mjs
new file mode 100644
index 00000000..6a7c466f
--- /dev/null
+++ b/apps/desktop/test/package-directory-size.test.mjs
@@ -0,0 +1,47 @@
+import { lstatSync, mkdirSync, mkdtempSync, rmSync, symlinkSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { afterEach, describe, expect, it } from 'vitest';
+import { treeSize } from '../scripts/package-directory-size.mjs';
+
+const directories = [];
+afterEach(() => {
+ for (const path of directories.splice(0)) rmSync(path, { recursive: true, force: true });
+});
+
+function fixture() {
+ const path = mkdtempSync(join(tmpdir(), 'opencreator-package-size-'));
+ directories.push(path);
+ return path;
+}
+
+describe('packaged directory size', () => {
+ it('counts every file in nested directories', () => {
+ const root = fixture();
+ mkdirSync(join(root, 'bin'));
+ writeFileSync(join(root, 'bin', 'node'), Buffer.alloc(1024));
+ writeFileSync(join(root, 'manifest.json'), Buffer.alloc(128));
+ expect(treeSize(root)).toBe(1152);
+ });
+
+ it.skipIf(process.platform === 'win32')('counts Python aliases as links without duplicating interpreter bytes', () => {
+ const root = fixture();
+ const bin = join(root, 'bin');
+ mkdirSync(bin);
+ writeFileSync(join(bin, 'python3.13'), Buffer.alloc(1024 * 1024));
+ const python = join(bin, 'python');
+ const python3 = join(bin, 'python3');
+ const directoryAlias = join(root, 'bin-alias');
+ symlinkSync('python3.13', python);
+ symlinkSync('python3.13', python3);
+ symlinkSync('bin', directoryAlias);
+ expect(treeSize(root)).toBe(1024 * 1024
+ + lstatSync(python).size + lstatSync(python3).size + lstatSync(directoryAlias).size);
+ });
+
+ it.skipIf(process.platform === 'win32')('rejects a broken link instead of undercounting it', () => {
+ const root = fixture();
+ symlinkSync('missing', join(root, 'python'));
+ expect(() => treeSize(root)).toThrow('broken symbolic link');
+ });
+});