Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix: avoid treating parenthesized speech as silence

wulien29c5ae4ee300
diff --git a/internal/service/dubbing/clean.go b/internal/service/dubbing/clean.go
index 855cad8e..1e31be29 100644
--- a/internal/service/dubbing/clean.go
+++ b/internal/service/dubbing/clean.go
@@ -7,7 +7,7 @@ import (
var (
parenNoisePattern = regexp.MustCompile(`(?i)[((][^()()]*(music|applause|laughter|laugh|noise|sound|silence|inaudible|掌声|音乐|笑声|噪音|静音)[^()()]*[))]`)
- anyParenPattern = regexp.MustCompile(`[((][^()()]{0,20}[))]`)
+ silenceCuePattern = regexp.MustCompile(`(?i)(music|applause|laughter|laugh|noise|sound|silence|inaudible|掌声|音乐|笑声|噪音|静音)`)
spacePattern = regexp.MustCompile(`\s+`)
)
@@ -29,7 +29,5 @@ func IsSilenceOnlyText(text string) bool {
if cleaned == "" {
return true
}
-
- withoutParens := anyParenPattern.ReplaceAllString(cleaned, "")
- return strings.TrimSpace(withoutParens) == ""
+ return silenceCuePattern.MatchString(text) || silenceCuePattern.MatchString(cleaned)
}
diff --git a/internal/service/dubbing/clean_test.go b/internal/service/dubbing/clean_test.go
index 6ab9b550..aeb1ccb0 100644
--- a/internal/service/dubbing/clean_test.go
+++ b/internal/service/dubbing/clean_test.go
@@ -17,3 +17,12 @@ func TestIsSilenceOnlyText(t *testing.T) {
t.Fatalf("spoken text should not be silence-only")
}
}
+
+func TestIsSilenceOnlyTextDoesNotTreatPlainParenthesizedTextAsSilence(t *testing.T) {
+ if IsSilenceOnlyText("(你好)") {
+ t.Fatalf("plain parenthesized text should not be silence-only")
+ }
+ if IsSilenceOnlyText("(普通说明)") {
+ t.Fatalf("plain parenthesized text should not be silence-only")
+ }
+}