Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.
TypeScript agent-skillscodex-clideskop-appdubbingimage-generationlocalizationskillsttsvideo-editingvideo-generationvideo-transcriptionvideo-translation
fix(desktop): keep network probe URLs out of Windows launch arguments
Leggett2aaff0b20285
diff --git a/apps/desktop/e2e/desktop-network.spec.ts b/apps/desktop/e2e/desktop-network.spec.tsindex 30fa94ca..1117b993 100644--- a/apps/desktop/e2e/desktop-network.spec.ts+++ b/apps/desktop/e2e/desktop-network.spec.ts@@ -43,6 +43,9 @@ test('@package-smoke Desktop 网络在 Socket QoS 抛出 EINVAL 时仍可请求const env: NodeJS.ProcessEnv = {...process.env,OPENCREATOR_DESKTOP_NETWORK_TEST_RESULT: resultPath,+ OPENCREATOR_DESKTOP_NETWORK_TEST_USER_DATA: userData,+ OPENCREATOR_DESKTOP_NETWORK_TEST_MODULE: pathToFileURL(resolve(e2eDir, '../dist/main/desktop-network.js')).href,+ OPENCREATOR_DESKTOP_NETWORK_TEST_ORIGIN: `http://127.0.0.1:${(server.address() as AddressInfo).port}`,ELECTRON_ENABLE_LOGGING: '1',ELECTRON_LOG_FILE: electronLogPath};@@ -50,11 +53,10 @@ test('@package-smoke Desktop 网络在 Socket QoS 抛出 EINVAL 时仍可请求let processFailure: unknown;let stderr = '';try {+ // Electron rejects URL arguments followed by more arguments on Windows.+ // Pass test configuration through the environment on every platform.const result = await run(electronExecutable, [- resolve(e2eDir, 'fixtures/desktop-network.cjs'),- pathToFileURL(resolve(e2eDir, '../dist/main/desktop-network.js')).href,- `http://127.0.0.1:${(server.address() as AddressInfo).port}`,- userData+ resolve(e2eDir, 'fixtures/desktop-network.mjs')], { env, timeout: 30_000, windowsHide: true });stderr = result.stderr;} catch (error) { processFailure = error; }diff --git a/apps/desktop/e2e/fixtures/desktop-network.cjs b/apps/desktop/e2e/fixtures/desktop-network.mjssimilarity index 83%rename from apps/desktop/e2e/fixtures/desktop-network.cjsrename to apps/desktop/e2e/fixtures/desktop-network.mjsindex 32dd8c61..06f39adf 100644--- a/apps/desktop/e2e/fixtures/desktop-network.cjs+++ b/apps/desktop/e2e/fixtures/desktop-network.mjs@@ -1,7 +1,7 @@-const assert = require('node:assert/strict');-const { writeFileSync } = require('node:fs');-const { Socket } = require('node:net');-const { app } = require('electron');+import assert from 'node:assert/strict';+import { writeFileSync } from 'node:fs';+import { Socket } from 'node:net';+import { app } from 'electron';let phase = 'initialization';const report = result => writeFileSync(process.env.OPENCREATOR_DESKTOP_NETWORK_TEST_RESULT, `${JSON.stringify({ phase, ...result }, null, 2)}\n`);@@ -9,7 +9,7 @@ const report = result => writeFileSync(process.env.OPENCREATOR_DESKTOP_NETWORK_Treport({ ok: false, pending: true });void (async () => {- app.setPath('userData', process.argv[4]);+ app.setPath('userData', process.env.OPENCREATOR_DESKTOP_NETWORK_TEST_USER_DATA);Socket.prototype.setTypeOfService = () => {throw Object.assign(new Error('setTypeOfService EINVAL'), { code: 'EINVAL' });};@@ -18,8 +18,8 @@ void (async () => {};await app.whenReady();phase = 'load network module';- const { fetchDesktopRequest } = await import(process.argv[2]);- const origin = process.argv[3];+ const { fetchDesktopRequest } = await import(process.env.OPENCREATOR_DESKTOP_NETWORK_TEST_MODULE);+ const origin = process.env.OPENCREATOR_DESKTOP_NETWORK_TEST_ORIGIN;phase = 'JSON request';const json = await fetchDesktopRequest(`${origin}/json`);assert.deepEqual(await json.json(), { ok: true });