Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix: harden dubbing tts and audio helpers

wulien353be5330e39
diff --git a/internal/service/dubbing/audio.go b/internal/service/dubbing/audio.go
index 37b00879..0069dc10 100644
--- a/internal/service/dubbing/audio.go
+++ b/internal/service/dubbing/audio.go
@@ -3,6 +3,7 @@ package dubbing
import (
"fmt"
"krillin-ai/internal/storage"
+ "math"
"os/exec"
"strings"
)
@@ -32,9 +33,9 @@ func WriteTinySilence(output string, run CommandRunner) error {
})
}
-func buildAtempoFilter(speed float64) string {
- if speed <= 0 {
- speed = 1
+func buildAtempoFilter(speed float64) (string, error) {
+ if speed <= 0 || math.IsNaN(speed) || math.IsInf(speed, 0) {
+ return "", fmt.Errorf("speed must be finite and > 0: %v", speed)
}
parts := []string{}
@@ -47,7 +48,7 @@ func buildAtempoFilter(speed float64) string {
speed /= 0.5
}
parts = append(parts, fmt.Sprintf("atempo=%.3f", speed))
- return strings.Join(parts, ",")
+ return strings.Join(parts, ","), nil
}
func buildMuxArgs(inputVideo, inputAudio, outputVideo string) []string {
@@ -60,6 +61,7 @@ func buildMuxArgs(inputVideo, inputAudio, outputVideo string) []string {
"-map", "1:a:0",
"-c:a", "aac",
"-b:a", "192k",
+ "-shortest",
outputVideo,
}
}
diff --git a/internal/service/dubbing/audio_test.go b/internal/service/dubbing/audio_test.go
index e8f6445e..d2543ba3 100644
--- a/internal/service/dubbing/audio_test.go
+++ b/internal/service/dubbing/audio_test.go
@@ -1,21 +1,46 @@
package dubbing
import (
+ "math"
"strings"
"testing"
)
func TestBuildAtempoFilterChainsLargeSpeed(t *testing.T) {
- got := buildAtempoFilter(3.0)
+ got, err := buildAtempoFilter(3.0)
+ if err != nil {
+ t.Fatalf("buildAtempoFilter(3) error = %v", err)
+ }
if got != "atempo=2.000,atempo=1.500" {
t.Fatalf("buildAtempoFilter(3) = %q", got)
}
}
+func TestBuildAtempoFilterChainsSmallSpeed(t *testing.T) {
+ got, err := buildAtempoFilter(0.25)
+ if err != nil {
+ t.Fatalf("buildAtempoFilter(0.25) error = %v", err)
+ }
+ if got != "atempo=0.500,atempo=0.500" {
+ t.Fatalf("buildAtempoFilter(0.25) = %q", got)
+ }
+}
+
+func TestBuildAtempoFilterRejectsInvalidSpeed(t *testing.T) {
+ for _, speed := range []float64{0, -1, math.Inf(1), math.NaN()} {
+ if got, err := buildAtempoFilter(speed); err == nil {
+ t.Fatalf("buildAtempoFilter(%v) = %q, nil error", speed, got)
+ }
+ }
+}
+
func TestBuildMuxArgsMapsVideoAndDubAudio(t *testing.T) {
args := buildMuxArgs("input.mp4", "dub.wav", "out.mp4")
joined := strings.Join(args, " ")
if !strings.Contains(joined, "-map 0:v:0") || !strings.Contains(joined, "-map 1:a:0") {
t.Fatalf("args should map original video and dub audio: %v", args)
}
+ if !strings.Contains(joined, "-shortest") {
+ t.Fatalf("args should include -shortest: %v", args)
+ }
}
diff --git a/internal/service/dubbing/tts.go b/internal/service/dubbing/tts.go
index f91336a6..629fb858 100644
--- a/internal/service/dubbing/tts.go
+++ b/internal/service/dubbing/tts.go
@@ -46,7 +46,7 @@ func GenerateRawSegments(ctx context.Context, tts types.Ttser, plan []PlanItem,
dur, err := duration(output)
if err != nil {
- return nil, err
+ return nil, fmt.Errorf("measure segment %d duration failed for %s: %w", plan[i].Index, output, err)
}
plan[i].ActualDuration = dur
}
@@ -55,8 +55,15 @@ func GenerateRawSegments(ctx context.Context, tts types.Ttser, plan []PlanItem,
}
func retryTTS(tts types.Ttser, text, voice, output string, attempts int) error {
+ if attempts <= 0 {
+ return fmt.Errorf("attempts must be > 0: %d", attempts)
+ }
+
var last error
for i := 0; i < attempts; i++ {
+ if err := os.Remove(output); err != nil && !errors.Is(err, os.ErrNotExist) {
+ return fmt.Errorf("remove stale output %s: %w", output, err)
+ }
last = tts.Text2Speech(text, voice, output)
if last == nil {
if _, err := os.Stat(output); err == nil {
diff --git a/internal/service/dubbing/tts_test.go b/internal/service/dubbing/tts_test.go
index 7f7cd961..63387f9e 100644
--- a/internal/service/dubbing/tts_test.go
+++ b/internal/service/dubbing/tts_test.go
@@ -5,12 +5,14 @@ import (
"errors"
"os"
"path/filepath"
+ "strings"
"testing"
)
type fakeTTS struct {
- failures int
- calls int
+ failures int
+ calls int
+ writeOnReturn bool
}
func (f *fakeTTS) Text2Speech(text, voice, outputFile string) error {
@@ -18,12 +20,15 @@ func (f *fakeTTS) Text2Speech(text, voice, outputFile string) error {
if f.calls <= f.failures {
return errors.New("tts failed")
}
+ if !f.writeOnReturn {
+ return nil
+ }
return os.WriteFile(outputFile, []byte("wav"), 0644)
}
func TestGenerateRawSegmentsRetriesAndWritesFiles(t *testing.T) {
dir := t.TempDir()
- tts := &fakeTTS{failures: 1}
+ tts := &fakeTTS{failures: 1, writeOnReturn: true}
plan := []PlanItem{{Index: 1, SpokenText: "你好"}}
got, err := GenerateRawSegments(context.Background(), tts, plan, "voice", dir, nil, func(string) (float64, error) {
return 1.2, nil
@@ -41,3 +46,43 @@ func TestGenerateRawSegmentsRetriesAndWritesFiles(t *testing.T) {
t.Fatalf("raw file missing: %v", err)
}
}
+
+func TestRetryTTSRejectsNonPositiveAttempts(t *testing.T) {
+ err := retryTTS(&fakeTTS{}, "hello", "voice", filepath.Join(t.TempDir(), "out.wav"), 0)
+ if err == nil || !strings.Contains(err.Error(), "attempts must be > 0") {
+ t.Fatalf("retryTTS() error = %v, want attempts validation", err)
+ }
+}
+
+func TestRetryTTSDoesNotTreatStaleOutputAsSuccess(t *testing.T) {
+ output := filepath.Join(t.TempDir(), "out.wav")
+ if err := os.WriteFile(output, []byte("stale"), 0644); err != nil {
+ t.Fatalf("write stale output: %v", err)
+ }
+
+ tts := &fakeTTS{writeOnReturn: false}
+ err := retryTTS(tts, "hello", "voice", output, 1)
+ if err == nil {
+ t.Fatal("retryTTS() error = nil, want missing output error")
+ }
+ if _, statErr := os.Stat(output); !errors.Is(statErr, os.ErrNotExist) {
+ t.Fatalf("stale output stat error = %v, want removed output", statErr)
+ }
+}
+
+func TestGenerateRawSegmentsWrapsDurationProbeError(t *testing.T) {
+ dir := t.TempDir()
+ tts := &fakeTTS{writeOnReturn: true}
+ plan := []PlanItem{{Index: 1, SpokenText: "你好"}}
+
+ _, err := GenerateRawSegments(context.Background(), tts, plan, "voice", dir, nil, func(string) (float64, error) {
+ return 0, errors.New("probe failed")
+ })
+ if err == nil {
+ t.Fatal("GenerateRawSegments() error = nil, want duration error")
+ }
+ output := filepath.Join(dir, "raw", "1.wav")
+ if !strings.Contains(err.Error(), "measure segment 1 duration failed") || !strings.Contains(err.Error(), output) {
+ t.Fatalf("GenerateRawSegments() error = %q, want segment index and output path", err)
+ }
+}