Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix: keep yt-dlp on stable release

wulien5661f6771c66
diff --git a/internal/deps/checker.go b/internal/deps/checker.go
index 867f5cf0..80d009db 100644
--- a/internal/deps/checker.go
+++ b/internal/deps/checker.go
@@ -10,6 +10,8 @@ import (
"os/exec"
"path/filepath"
"runtime"
+ "strings"
+ "time"
"go.uber.org/zap"
)
@@ -225,61 +227,185 @@ func checkAndDownloadFfprobe() error {
// 检测并安装yt-dlp
func checkAndDownloadYtDlp() error {
- _, err := exec.LookPath("yt-dlp")
- if err == nil {
- log.GetLogger().Info("已找到yt-dlp")
- storage.YtdlpPath = "yt-dlp"
- return nil
+ path, err := resolveYtDlpDependency(defaultYtDlpDependencyEnv())
+ if err != nil {
+ return err
}
+ storage.YtdlpPath = path
+ return nil
+}
- ytdlpBinFilePath := "./bin/yt-dlp"
- if runtime.GOOS == "windows" {
- ytdlpBinFilePath += ".exe"
+type ytdlpDependencyEnv struct {
+ goos string
+ goarch string
+ proxy string
+ lastCheckPath string
+ now func() time.Time
+ lookPath func(string) (string, error)
+ stat func(string) (os.FileInfo, error)
+ mkdirAll func(string, os.FileMode) error
+ downloadFile func(string, string, string) error
+ chmod func(string, os.FileMode) error
+ runCommand func(string, ...string) ([]byte, error)
+}
+
+func defaultYtDlpDependencyEnv() ytdlpDependencyEnv {
+ return ytdlpDependencyEnv{
+ goos: runtime.GOOS,
+ goarch: runtime.GOARCH,
+ proxy: config.Conf.App.Proxy,
+ lastCheckPath: filepath.Join("bin", ".yt-dlp-last-check"),
+ now: time.Now,
+ lookPath: exec.LookPath,
+ stat: os.Stat,
+ mkdirAll: os.MkdirAll,
+ downloadFile: util.DownloadFile,
+ chmod: os.Chmod,
+ runCommand: func(name string, args ...string) ([]byte, error) {
+ return exec.Command(name, args...).CombinedOutput()
+ },
}
- // 先前下载过的
- if _, err = os.Stat(ytdlpBinFilePath); err == nil {
+}
+
+func resolveYtDlpDependency(env ytdlpDependencyEnv) (string, error) {
+ if path, err := env.lookPath("yt-dlp"); err == nil {
+ log.GetLogger().Info("已找到yt-dlp")
+ if recentlyCheckedYtDlp(env) {
+ return "yt-dlp", nil
+ }
+ if err = updateYtDlpBinary(env, path); err != nil {
+ log.GetLogger().Warn("系统yt-dlp自更新失败,将下载stable最新版到本地bin", zap.Error(err))
+ ytdlpBinFilePath := ytDlpBundledPath(env.goos)
+ if err = env.mkdirAll("./bin", 0755); err != nil {
+ log.GetLogger().Error("创建./bin目录失败", zap.Error(err))
+ return "", err
+ }
+ if err = downloadLatestYtDlp(env, ytdlpBinFilePath); err != nil {
+ return "", err
+ }
+ markYtDlpChecked(env)
+ return ytdlpBinFilePath, nil
+ }
+ markYtDlpChecked(env)
+ return "yt-dlp", nil
+ }
+
+ ytdlpBinFilePath := ytDlpBundledPath(env.goos)
+ if _, err := env.stat(ytdlpBinFilePath); err == nil {
log.GetLogger().Info("已找到ytdlp")
- storage.YtdlpPath = ytdlpBinFilePath
- return nil
+ if recentlyCheckedYtDlp(env) {
+ return ytdlpBinFilePath, nil
+ }
+ if err := updateYtDlpBinary(env, ytdlpBinFilePath); err != nil {
+ log.GetLogger().Warn("yt-dlp自更新失败,将下载stable最新版覆盖", zap.Error(err))
+ if err = downloadLatestYtDlp(env, ytdlpBinFilePath); err != nil {
+ return "", err
+ }
+ }
+ markYtDlpChecked(env)
+ return ytdlpBinFilePath, nil
}
log.GetLogger().Info("没有找到yt-dlp,即将开始自动安装")
- err = os.MkdirAll("./bin", 0755)
- if err != nil {
+ if err := env.mkdirAll("./bin", 0755); err != nil {
log.GetLogger().Error("创建./bin目录失败", zap.Error(err))
+ return "", err
+ }
+ if err := downloadLatestYtDlp(env, ytdlpBinFilePath); err != nil {
+ return "", err
+ }
+ markYtDlpChecked(env)
+ return ytdlpBinFilePath, nil
+}
+
+func updateYtDlpBinary(env ytdlpDependencyEnv, path string) error {
+ args := []string{"--update-to", "stable"}
+ if env.proxy != "" {
+ args = append(args, "--proxy", env.proxy)
+ }
+ output, err := env.runCommand(path, args...)
+ if err != nil {
+ log.GetLogger().Warn("yt-dlp更新到stable失败", zap.String("path", path), zap.String("output", string(output)), zap.Error(err))
return err
}
+ log.GetLogger().Info("yt-dlp已更新到stable通道", zap.String("path", path), zap.String("output", string(output)))
+ return nil
+}
- var ytDlpURL string
- if runtime.GOOS == "linux" {
- ytDlpURL = "https://modelscope.cn/models/Maranello/KrillinAI_dependency_cn/resolve/master/yt-dlp_linux"
- } else if runtime.GOOS == "darwin" {
- ytDlpURL = "https://modelscope.cn/models/Maranello/KrillinAI_dependency_cn/resolve/master/yt-dlp_macos"
- } else if runtime.GOOS == "windows" {
- ytDlpURL = "https://modelscope.cn/models/Maranello/KrillinAI_dependency_cn/resolve/master/yt-dlp.exe"
- } else {
- log.GetLogger().Error("不支持你当前的操作系统", zap.String("当前系统", runtime.GOOS))
- return fmt.Errorf("unsupported OS: %s", runtime.GOOS)
+func recentlyCheckedYtDlp(env ytdlpDependencyEnv) bool {
+ if env.lastCheckPath == "" || env.now == nil {
+ return false
+ }
+ data, err := os.ReadFile(env.lastCheckPath)
+ if err != nil {
+ return false
+ }
+ last, err := time.Parse(time.RFC3339, strings.TrimSpace(string(data)))
+ if err != nil {
+ return false
+ }
+ return env.now().Sub(last) < 24*time.Hour
+}
+
+func markYtDlpChecked(env ytdlpDependencyEnv) {
+ if env.lastCheckPath == "" || env.now == nil {
+ return
+ }
+ if err := os.MkdirAll(filepath.Dir(env.lastCheckPath), 0755); err != nil {
+ log.GetLogger().Warn("创建yt-dlp更新时间缓存目录失败", zap.Error(err))
+ return
+ }
+ if err := os.WriteFile(env.lastCheckPath, []byte(env.now().UTC().Format(time.RFC3339)), 0644); err != nil {
+ log.GetLogger().Warn("写入yt-dlp更新时间缓存失败", zap.Error(err))
}
+}
- err = util.DownloadFile(ytDlpURL, ytdlpBinFilePath, config.Conf.App.Proxy)
+func downloadLatestYtDlp(env ytdlpDependencyEnv, path string) error {
+ ytDlpURL, err := latestYtDlpStableURL(env.goos, env.goarch)
if err != nil {
+ log.GetLogger().Error("不支持你当前的操作系统", zap.String("当前系统", env.goos), zap.String("当前架构", env.goarch))
+ return err
+ }
+ if err = env.downloadFile(ytDlpURL, path, env.proxy); err != nil {
log.GetLogger().Error("下载yt-dlp失败", zap.Error(err))
return err
}
-
- if runtime.GOOS != "windows" {
- err = os.Chmod(ytdlpBinFilePath, 0755)
- if err != nil {
+ if env.goos != "windows" {
+ if err = env.chmod(path, 0755); err != nil {
log.GetLogger().Error("设置文件权限失败", zap.Error(err))
return err
}
}
+ log.GetLogger().Info("yt-dlp安装完成", zap.String("路径", path))
+ return nil
+}
- storage.YtdlpPath = ytdlpBinFilePath
- log.GetLogger().Info("yt-dlp安装完成", zap.String("路径", ytdlpBinFilePath))
+func ytDlpBundledPath(goos string) string {
+ if goos == "windows" {
+ return "./bin/yt-dlp.exe"
+ }
+ return "./bin/yt-dlp"
+}
- return nil
+func latestYtDlpStableURL(goos, goarch string) (string, error) {
+ const base = "https://github.com/yt-dlp/yt-dlp/releases/latest/download/"
+ switch goos {
+ case "linux":
+ if goarch == "arm64" {
+ return base + "yt-dlp_linux_aarch64", nil
+ }
+ if goarch == "amd64" || goarch == "" {
+ return base + "yt-dlp_linux", nil
+ }
+ case "darwin":
+ return base + "yt-dlp_macos", nil
+ case "windows":
+ if goarch == "arm64" {
+ return base + "yt-dlp_arm64.exe", nil
+ }
+ return base + "yt-dlp.exe", nil
+ }
+ return "", fmt.Errorf("unsupported OS or architecture: %s/%s", goos, goarch)
}
// 检测faster whisper
@@ -620,4 +746,4 @@ func checkEdgeTts() error {
storage.EdgeTtsPath = EdgeTtsBinFilePath
log.GetLogger().Info("edge-tts安装完成", zap.String("路径", EdgeTtsBinFilePath))
return nil
-}
\ No newline at end of file
+}
diff --git a/internal/deps/checker_test.go b/internal/deps/checker_test.go
new file mode 100644
index 00000000..a37ca644
--- /dev/null
+++ b/internal/deps/checker_test.go
@@ -0,0 +1,245 @@
+package deps
+
+import (
+ "errors"
+ "krillin-ai/log"
+ "os"
+ "path/filepath"
+ "reflect"
+ "testing"
+ "time"
+
+ "go.uber.org/zap"
+)
+
+func TestMain(m *testing.M) {
+ log.Logger = zap.NewNop()
+ os.Exit(m.Run())
+}
+
+func TestResolveYtDlpUpdatesExistingBundledBinaryToStableRelease(t *testing.T) {
+ env := testYtDlpEnv(t, "darwin")
+ env.stat = func(path string) (os.FileInfo, error) {
+ if path == "./bin/yt-dlp" {
+ return nil, nil
+ }
+ return nil, os.ErrNotExist
+ }
+ var commands [][]string
+ env.runCommand = func(name string, args ...string) ([]byte, error) {
+ commands = append(commands, append([]string{name}, args...))
+ return []byte("Updated yt-dlp"), nil
+ }
+ var downloads []string
+ env.downloadFile = func(url, path, proxy string) error {
+ downloads = append(downloads, url)
+ return nil
+ }
+
+ path, err := resolveYtDlpDependency(env)
+ if err != nil {
+ t.Fatalf("resolveYtDlpDependency() error = %v", err)
+ }
+ if path != "./bin/yt-dlp" {
+ t.Fatalf("path = %q, want bundled yt-dlp", path)
+ }
+ wantCommands := [][]string{{"./bin/yt-dlp", "--update-to", "stable"}}
+ if !reflect.DeepEqual(commands, wantCommands) {
+ t.Fatalf("commands = %#v, want %#v", commands, wantCommands)
+ }
+ if len(downloads) != 0 {
+ t.Fatalf("downloadFile called for existing updatable binary: %#v", downloads)
+ }
+}
+
+func TestResolveYtDlpSkipsUpdateWhenCheckedRecently(t *testing.T) {
+ env := testYtDlpEnv(t, "darwin")
+ dir := t.TempDir()
+ statePath := filepath.Join(dir, ".yt-dlp-last-check")
+ env.lastCheckPath = statePath
+ env.now = func() time.Time {
+ return time.Date(2026, 6, 14, 9, 0, 0, 0, time.UTC)
+ }
+ if err := os.WriteFile(statePath, []byte("2026-06-14T08:00:00Z"), 0644); err != nil {
+ t.Fatal(err)
+ }
+ env.stat = func(path string) (os.FileInfo, error) {
+ if path == "./bin/yt-dlp" {
+ return nil, nil
+ }
+ return os.Stat(path)
+ }
+ var commands [][]string
+ env.runCommand = func(name string, args ...string) ([]byte, error) {
+ commands = append(commands, append([]string{name}, args...))
+ return []byte("Updated yt-dlp"), nil
+ }
+
+ path, err := resolveYtDlpDependency(env)
+ if err != nil {
+ t.Fatalf("resolveYtDlpDependency() error = %v", err)
+ }
+ if path != "./bin/yt-dlp" {
+ t.Fatalf("path = %q, want bundled yt-dlp", path)
+ }
+ if len(commands) != 0 {
+ t.Fatalf("commands = %#v, want no update check when checked recently", commands)
+ }
+}
+
+func TestResolveYtDlpChecksUpdateAfterCacheExpires(t *testing.T) {
+ env := testYtDlpEnv(t, "darwin")
+ dir := t.TempDir()
+ statePath := filepath.Join(dir, ".yt-dlp-last-check")
+ env.lastCheckPath = statePath
+ env.now = func() time.Time {
+ return time.Date(2026, 6, 14, 9, 0, 0, 0, time.UTC)
+ }
+ if err := os.WriteFile(statePath, []byte("2026-06-13T08:59:59Z"), 0644); err != nil {
+ t.Fatal(err)
+ }
+ env.stat = func(path string) (os.FileInfo, error) {
+ if path == "./bin/yt-dlp" {
+ return nil, nil
+ }
+ return os.Stat(path)
+ }
+ var commands [][]string
+ env.runCommand = func(name string, args ...string) ([]byte, error) {
+ commands = append(commands, append([]string{name}, args...))
+ return []byte("yt-dlp is up to date"), nil
+ }
+
+ path, err := resolveYtDlpDependency(env)
+ if err != nil {
+ t.Fatalf("resolveYtDlpDependency() error = %v", err)
+ }
+ if path != "./bin/yt-dlp" {
+ t.Fatalf("path = %q, want bundled yt-dlp", path)
+ }
+ wantCommands := [][]string{{"./bin/yt-dlp", "--update-to", "stable"}}
+ if !reflect.DeepEqual(commands, wantCommands) {
+ t.Fatalf("commands = %#v, want %#v", commands, wantCommands)
+ }
+ data, err := os.ReadFile(statePath)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if got := string(data); got != "2026-06-14T09:00:00Z" {
+ t.Fatalf("last check timestamp = %q", got)
+ }
+}
+
+func TestResolveYtDlpDownloadsLatestStableReleaseWhenMissing(t *testing.T) {
+ env := testYtDlpEnv(t, "darwin")
+ env.lookPath = func(name string) (string, error) {
+ return "", errors.New("not found")
+ }
+ env.stat = func(path string) (os.FileInfo, error) {
+ return nil, os.ErrNotExist
+ }
+ var mkdirs []string
+ env.mkdirAll = func(path string, perm os.FileMode) error {
+ mkdirs = append(mkdirs, path)
+ return nil
+ }
+ var downloads [][2]string
+ env.downloadFile = func(url, path, proxy string) error {
+ downloads = append(downloads, [2]string{url, path})
+ return nil
+ }
+ var chmods []string
+ env.chmod = func(path string, mode os.FileMode) error {
+ chmods = append(chmods, path)
+ return nil
+ }
+
+ path, err := resolveYtDlpDependency(env)
+ if err != nil {
+ t.Fatalf("resolveYtDlpDependency() error = %v", err)
+ }
+ if path != "./bin/yt-dlp" {
+ t.Fatalf("path = %q, want bundled yt-dlp", path)
+ }
+ if !reflect.DeepEqual(mkdirs, []string{"./bin"}) {
+ t.Fatalf("mkdirs = %#v", mkdirs)
+ }
+ wantDownloads := [][2]string{{
+ "https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_macos",
+ "./bin/yt-dlp",
+ }}
+ if !reflect.DeepEqual(downloads, wantDownloads) {
+ t.Fatalf("downloads = %#v, want %#v", downloads, wantDownloads)
+ }
+ if !reflect.DeepEqual(chmods, []string{"./bin/yt-dlp"}) {
+ t.Fatalf("chmods = %#v", chmods)
+ }
+}
+
+func TestResolveYtDlpFallsBackToBundledStableReleaseWhenSystemUpdateFails(t *testing.T) {
+ env := testYtDlpEnv(t, "darwin")
+ env.lookPath = func(name string) (string, error) {
+ return "/usr/local/bin/yt-dlp", nil
+ }
+ env.runCommand = func(name string, args ...string) ([]byte, error) {
+ return []byte("installed by package manager"), errors.New("cannot update")
+ }
+ var mkdirs []string
+ env.mkdirAll = func(path string, perm os.FileMode) error {
+ mkdirs = append(mkdirs, path)
+ return nil
+ }
+ var downloads [][2]string
+ env.downloadFile = func(url, path, proxy string) error {
+ downloads = append(downloads, [2]string{url, path})
+ return nil
+ }
+
+ path, err := resolveYtDlpDependency(env)
+ if err != nil {
+ t.Fatalf("resolveYtDlpDependency() error = %v", err)
+ }
+ if path != "./bin/yt-dlp" {
+ t.Fatalf("path = %q, want bundled yt-dlp after system update failure", path)
+ }
+ if !reflect.DeepEqual(mkdirs, []string{"./bin"}) {
+ t.Fatalf("mkdirs = %#v", mkdirs)
+ }
+ wantDownloads := [][2]string{{
+ "https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_macos",
+ "./bin/yt-dlp",
+ }}
+ if !reflect.DeepEqual(downloads, wantDownloads) {
+ t.Fatalf("downloads = %#v, want %#v", downloads, wantDownloads)
+ }
+}
+
+func testYtDlpEnv(t *testing.T, goos string) ytdlpDependencyEnv {
+ t.Helper()
+ return ytdlpDependencyEnv{
+ goos: goos,
+ proxy: "",
+ now: func() time.Time {
+ return time.Date(2026, 6, 14, 9, 0, 0, 0, time.UTC)
+ },
+ lastCheckPath: filepath.Join(t.TempDir(), ".yt-dlp-last-check"),
+ lookPath: func(name string) (string, error) {
+ return "", errors.New("not found")
+ },
+ stat: func(path string) (os.FileInfo, error) {
+ return nil, os.ErrNotExist
+ },
+ mkdirAll: func(path string, perm os.FileMode) error {
+ return nil
+ },
+ downloadFile: func(url, path, proxy string) error {
+ return nil
+ },
+ chmod: func(path string, mode os.FileMode) error {
+ return nil
+ },
+ runCommand: func(name string, args ...string) ([]byte, error) {
+ return nil, nil
+ },
+ }
+}