Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.
TypeScript agent-skillscodex-clideskop-appdubbingimage-generationlocalizationskillsttsvideo-editingvideo-generationvideo-transcriptionvideo-translation
fix: preserve bilingual lines in vertical subtitles
wulien65cd1f10d491
diff --git a/internal/service/srt_embed.go b/internal/service/srt_embed.goindex c5e1878d..f7ca57c0 100644--- a/internal/service/srt_embed.go+++ b/internal/service/srt_embed.go@@ -805,12 +805,30 @@ func srtToAss(inputSRT, outputASS string, isHorizontal bool, stepParam *types.Sureturn err}- var content string- scanner.Scan()- content = scanner.Text()- if content == "" {+ var subtitleLines []string+ for scanner.Scan() {+ textLine := scanner.Text()+ if textLine == "" {+ break+ }+ subtitleLines = append(subtitleLines, textLine)+ }+ if len(subtitleLines) == 0 {continue}+ if len(subtitleLines) > 1 {+ startFormatted := formatTimestamp(startTime)+ endFormatted := formatTimestamp(endTime)+ majorText := joinASSLines(wrapSubtitleForASS(subtitleLines[0], screenStyle.Major, stepParam))+ minorText := joinASSLines(wrapSubtitleForASS(subtitleLines[1], screenStyle.Minor, stepParam))+ combinedText := fmt.Sprintf("%s{\\an%d}{\\rMajor}%s\\N%s{\\an%d}{\\rMinor}%s",+ majorTags, majorAlignment, majorText,+ minorTags, minorAlignment, minorText)+ _, _ = assFile.WriteString(fmt.Sprintf("Dialogue: 0,%s,%s,Major,,0,0,0,,%s\n", startFormatted, endFormatted, combinedText))+ continue+ }++ content := subtitleLines[0]if !util.ContainsAlphabetic(content) {// 处理中文字幕diff --git a/internal/service/srt_embed_test.go b/internal/service/srt_embed_test.goindex 9478a8c2..58e5aacc 100644--- a/internal/service/srt_embed_test.go+++ b/internal/service/srt_embed_test.go@@ -72,6 +72,32 @@ func TestVerticalAssKeepsChineseLineInSingleDialogueWithLineBreak(t *testing.T)}}+func TestVerticalAssKeepsBothLinesFromBilingualSRT(t *testing.T) {+ dir := t.TempDir()+ in := filepath.Join(dir, "bilingual.srt")+ out := filepath.Join(dir, "bilingual.ass")+ content := "1\n00:00:00,840 --> 00:00:02,900\n这是中文字幕\nThis is the English subtitle\n\n"+ if err := os.WriteFile(in, []byte(content), 0644); err != nil {+ t.Fatal(err)+ }++ err := srtToAss(in, out, false, &types.SubtitleTaskStepParam{TaskBasePath: dir})+ if err != nil {+ t.Fatalf("srtToAss() error = %v", err)+ }+ data, err := os.ReadFile(out)+ if err != nil {+ t.Fatal(err)+ }+ ass := string(data)+ if !strings.Contains(ass, "{\\rMajor}这是中文字幕") {+ t.Fatalf("vertical bilingual SRT should keep first line as Major: %s", ass)+ }+ if !strings.Contains(ass, "{\\rMinor}This is the English subtitle") {+ t.Fatalf("vertical bilingual SRT should keep second line as Minor: %s", ass)+ }+}+func TestHorizontalAssKeepsSingleLineSubtitle(t *testing.T) {dir := t.TempDir()in := filepath.Join(dir, "single-line.srt")