Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix: preserve video settings while defaults load

MijaelX931276e2b69b
diff --git a/apps/web/src/features/dashboard/VideoGenerationWorkspace.test.tsx b/apps/web/src/features/dashboard/VideoGenerationWorkspace.test.tsx
index 37ab11ed..9ba5b82f 100644
--- a/apps/web/src/features/dashboard/VideoGenerationWorkspace.test.tsx
+++ b/apps/web/src/features/dashboard/VideoGenerationWorkspace.test.tsx
@@ -1,4 +1,4 @@
-import { fireEvent, render, screen, waitFor } from '@testing-library/react';
+import { act, fireEvent, render, screen, waitFor } from '@testing-library/react';
import type {
CreatorArtifact,
CreatorJob,
@@ -248,6 +248,24 @@ describe('VideoGenerationWorkspace', () => {
expect(screen.getByText('Output format')).toBeInTheDocument();
});
+ it('preserves user selections when service defaults arrive late', async () => {
+ let resolveConfig!: (value: CreatorServicesConfigResponse) => void;
+ const pendingConfig = new Promise<CreatorServicesConfigResponse>(resolve => { resolveConfig = resolve; });
+ renderWorkspace(creatorJob({ state: {
+ provider: 'seedance', model: 'doubao-seedance-2-0-260128',
+ duration: 5, currentStep: 1, furthestStep: 1
+ } }), { creatorServicesService: { getConfig: () => pendingConfig } });
+ const provider = screen.getByRole('combobox', { name: '视频服务' });
+ const model = screen.getByRole('combobox', { name: '模型版本' });
+ const duration = screen.getByRole('combobox', { name: '视频时长' });
+ fireEvent.change(provider, { target: { value: 'veo' } });
+ fireEvent.change(duration, { target: { value: '8' } });
+ await act(async () => { resolveConfig({ config: createVideoConfig(), configuredCredentials: [] }); });
+ expect(provider).toHaveValue('veo');
+ expect(model).toHaveValue('veo-3.1-generate-preview');
+ expect(duration).toHaveValue('8');
+ });
+
it('uses the configured default model for a task and allows a task-level override', async () => {
const job = creatorJob({
state: {
diff --git a/apps/web/src/features/dashboard/VideoGenerationWorkspace.tsx b/apps/web/src/features/dashboard/VideoGenerationWorkspace.tsx
index e158f4a6..655c0064 100644
--- a/apps/web/src/features/dashboard/VideoGenerationWorkspace.tsx
+++ b/apps/web/src/features/dashboard/VideoGenerationWorkspace.tsx
@@ -22,7 +22,7 @@ import {
WandSparkles,
X
} from 'lucide-react';
-import { useEffect, useMemo, useState } from 'react';
+import { useEffect, useMemo, useRef, useState } from 'react';
import { useLocalizedCopy } from '../../i18n/useLocalizedCopy.js';
import type { CreatorServicesSettingsService } from '../../services/creator-services-service.js';
import CreatorResultVersionMenu from './CreatorResultVersionMenu.js';
@@ -99,6 +99,7 @@ export default function VideoGenerationWorkspace(props: {
const [referenceImageFile, setReferenceImageFile] = useState<File>();
const [referenceImageUrl, setReferenceImageUrl] = useState('');
const initialProvider = readProvider(session?.state.provider);
+ const settingsRevision = useRef(0);
const [modelDefaults, setModelDefaults] = useState<Record<VideoGenerationProvider, string>>(
() => ({ ...defaultVideoGenerationModels })
);
@@ -193,15 +194,17 @@ export default function VideoGenerationWorkspace(props: {
return undefined;
}
let active = true;
+ const revision = settingsRevision.current;
void props.creatorServicesService.getConfig()
.then(response => {
if (!active) return;
const defaults = videoModelDefaults(response.config);
+ setModelDefaults(defaults);
+ if (settingsRevision.current !== revision) return;
const savedProvider = readOptionalProvider(session?.state.provider);
const nextProvider = savedProvider ?? response.config.video.provider;
const nextModel = readOptionalModel(session?.state.model) ?? defaults[nextProvider];
const nextDuration = readDuration(session?.state.duration, nextProvider);
- setModelDefaults(defaults);
setProvider(nextProvider);
setModel(nextModel);
setDuration(nextDuration);
@@ -306,6 +309,7 @@ export default function VideoGenerationWorkspace(props: {
}
function updateProvider(nextProvider: VideoGenerationProvider) {
+ settingsRevision.current += 1;
const nextDurations = providerDurations[nextProvider];
const nextDuration = nextDurations.includes(duration) ? duration : nextDurations[0]!;
const nextModel = modelDefaults[nextProvider] || defaultVideoGenerationModels[nextProvider];
@@ -321,6 +325,7 @@ export default function VideoGenerationWorkspace(props: {
}
function updateModel(nextModel: string) {
+ settingsRevision.current += 1;
setModel(nextModel);
session?.updateDraft({ model: nextModel });
setError('');
@@ -333,6 +338,7 @@ export default function VideoGenerationWorkspace(props: {
}
function updateDuration(nextDuration: VideoGenerationDuration) {
+ settingsRevision.current += 1;
setDuration(nextDuration);
session?.updateDraft({ duration: nextDuration });
setError('');