Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

fix: harden service stage exports

wulienb6723653d0d4
diff --git a/internal/service/stage_exports.go b/internal/service/stage_exports.go
index 39fce34f..58d32d47 100644
--- a/internal/service/stage_exports.go
+++ b/internal/service/stage_exports.go
@@ -2,9 +2,12 @@ package service
import (
"context"
+ "errors"
"krillin-ai/internal/types"
)
+var ErrYouTubeSubtitleServiceNotInitialized = errors.New("youtube subtitle service not initialized")
+
func (s Service) PrepareMedia(ctx context.Context, stepParam *types.SubtitleTaskStepParam) error {
return s.linkToFile(ctx, stepParam)
}
@@ -22,9 +25,15 @@ func (s Service) FinalizeSubtitleResults(ctx context.Context, stepParam *types.S
}
func (s Service) DownloadYouTubeSubtitle(ctx context.Context, req *YoutubeSubtitleReq) (string, error) {
+ if s.YouTubeSubtitleSrv == nil {
+ return "", ErrYouTubeSubtitleServiceNotInitialized
+ }
return s.YouTubeSubtitleSrv.downloadYouTubeSubtitle(ctx, req)
}
func (s Service) ProcessYouTubeSubtitle(ctx context.Context, req *YoutubeSubtitleReq) (string, error) {
+ if s.YouTubeSubtitleSrv == nil {
+ return "", ErrYouTubeSubtitleServiceNotInitialized
+ }
return s.YouTubeSubtitleSrv.processYouTubeSubtitle(ctx, req)
}
diff --git a/internal/service/stage_exports_test.go b/internal/service/stage_exports_test.go
index f7befa42..313b795b 100644
--- a/internal/service/stage_exports_test.go
+++ b/internal/service/stage_exports_test.go
@@ -2,23 +2,34 @@ package service
import (
"context"
+ "errors"
"krillin-ai/internal/types"
"testing"
)
+type stageExporter interface {
+ PrepareMedia(context.Context, *types.SubtitleTaskStepParam) error
+ GenerateSubtitlesFromAudio(context.Context, *types.SubtitleTaskStepParam) error
+ GenerateSpeechFromSRT(context.Context, *types.SubtitleTaskStepParam) error
+ FinalizeSubtitleResults(context.Context, *types.SubtitleTaskStepParam) error
+ DownloadYouTubeSubtitle(context.Context, *YoutubeSubtitleReq) (string, error)
+ ProcessYouTubeSubtitle(context.Context, *YoutubeSubtitleReq) (string, error)
+}
+
+var _ stageExporter = Service{}
+
func TestStageExportMethodsExist(t *testing.T) {
+ var _ stageExporter = Service{}
+}
+
+func TestYouTubeStageExportsReturnErrorWhenServiceMissing(t *testing.T) {
var svc Service
- param := &types.SubtitleTaskStepParam{}
- _ = svc.PrepareMedia
- _ = svc.GenerateSubtitlesFromAudio
- _ = svc.GenerateSpeechFromSRT
- _ = svc.FinalizeSubtitleResults
+ if _, err := svc.DownloadYouTubeSubtitle(context.Background(), &YoutubeSubtitleReq{}); !errors.Is(err, ErrYouTubeSubtitleServiceNotInitialized) {
+ t.Fatalf("DownloadYouTubeSubtitle error = %v, want %v", err, ErrYouTubeSubtitleServiceNotInitialized)
+ }
- if false {
- _ = svc.PrepareMedia(context.Background(), param)
- _ = svc.GenerateSubtitlesFromAudio(context.Background(), param)
- _ = svc.GenerateSpeechFromSRT(context.Background(), param)
- _ = svc.FinalizeSubtitleResults(context.Background(), param)
+ if _, err := svc.ProcessYouTubeSubtitle(context.Background(), &YoutubeSubtitleReq{}); !errors.Is(err, ErrYouTubeSubtitleServiceNotInitialized) {
+ t.Fatalf("ProcessYouTubeSubtitle error = %v, want %v", err, ErrYouTubeSubtitleServiceNotInitialized)
}
}