Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.
TypeScript agent-skillscodex-clideskop-appdubbingimage-generationlocalizationskillsttsvideo-editingvideo-generationvideo-transcriptionvideo-translation
fix(creator): recompute download progress across media resources
Leggettc82d767a2dbe
diff --git a/apps/daemon/src/creator/download/executor.ts b/apps/daemon/src/creator/download/executor.tsindex 5ea9ba4c..34f15a4b 100644--- a/apps/daemon/src/creator/download/executor.ts+++ b/apps/daemon/src/creator/download/executor.ts@@ -609,7 +609,7 @@ function createPreviewProgressReporter(stage: CreatorExecutorInput): (line: striconst combinedPercent = rawPercent === null? null: Math.min(95, rawPercent);- if (combinedPercent !== null) reportedPercent = Math.max(reportedPercent, Math.round(combinedPercent));+ if (combinedPercent !== null) reportedPercent = Math.round(combinedPercent);stage.reportProgress({phase: 'downloading',percent: combinedPercent === nulldiff --git a/apps/daemon/src/creator/stage-runner.ts b/apps/daemon/src/creator/stage-runner.tsindex 33f612e3..59fa342c 100644--- a/apps/daemon/src/creator/stage-runner.ts+++ b/apps/daemon/src/creator/stage-runner.ts@@ -572,9 +572,13 @@ export function createCreatorStageRunner(input: {const progress = { ...(current?.progress ?? {}), ...incoming };const currentPercent = current?.progress.percent;const incomingPercent = incoming.percent;+ const currentPhase = current?.progress.phase;+ const incomingPhase = incoming.phase;+ const phaseChanged = incomingPhase !== undefined && incomingPhase !== currentPhase;if (typeof currentPercent === 'number' && Number.isFinite(currentPercent)&& (incomingPercent === null- || (typeof incomingPercent === 'number' && Number.isFinite(incomingPercent)+ || (phaseChanged+ && typeof incomingPercent === 'number' && Number.isFinite(incomingPercent)&& incomingPercent < currentPercent))) {progress.percent = currentPercent;}diff --git a/apps/daemon/test/unit/creator-download-executor.test.ts b/apps/daemon/test/unit/creator-download-executor.test.tsindex f44b7cd2..40d8069d 100644--- a/apps/daemon/test/unit/creator-download-executor.test.ts+++ b/apps/daemon/test/unit/creator-download-executor.test.ts@@ -195,7 +195,7 @@ describe('creator download executor', () => {expect(reportProgress).toHaveBeenCalledWith(expect.objectContaining({ phase: 'merging_media', percent: 96 }));});- it('keeps preview progress monotonic when yt-dlp switches from video to audio', async () => {+ it('recomputes aggregate progress when yt-dlp switches from video to audio', async () => {const executor = createDownloadExecutor(await fakeBinaries({previewProgressEvents: [{ downloaded_bytes: 100, total_bytes: 100, filename: 'video.mp4' },@@ -216,9 +216,9 @@ describe('creator download executor', () => {.filter(value => value.phase === 'downloading');expect(progress).toEqual([expect.objectContaining({ percent: 95, downloadedBytes: 100, totalBytes: 100 }),- expect.objectContaining({ percent: 95, downloadedBytes: 125, totalBytes: 200 })+ expect.objectContaining({ percent: 63, downloadedBytes: 125, totalBytes: 200 })]);- expect(progress[1]!.percent).toBeGreaterThanOrEqual(progress[0]!.percent!);+ expect(progress[1]!.percent).toBe(Math.round(progress[1]!.downloadedBytes! / progress[1]!.totalBytes! * 100));});it('reports the measured ratio for a single preview resource', async () => {diff --git a/apps/daemon/test/unit/creator-video-preview.test.ts b/apps/daemon/test/unit/creator-video-preview.test.tsindex b84a3a69..1eff511b 100644--- a/apps/daemon/test/unit/creator-video-preview.test.ts+++ b/apps/daemon/test/unit/creator-video-preview.test.ts@@ -96,6 +96,29 @@ describe('video translation preview preparation', () => {} finally { await context.close(); }});+ it('allows download progress to reflect a newly discovered media resource', async () => {+ let release!: () => void;+ const released = new Promise<void>(resolve => { release = resolve; });+ const context = setup({ id: 'download', async run({ reportProgress, workdir }) {+ reportProgress({ phase: 'downloading', percent: 95, downloadedBytes: 100, totalBytes: 100 });+ reportProgress({ phase: 'downloading', percent: 63, downloadedBytes: 125, totalBytes: 200 });+ await released;+ const path = join(workdir, 'preview.mp4');+ writeFileSync(path, 'preview');+ return { outputs: [{ kind: 'source_video', path, status: 'completed', sourceArtifactIds: [] }] };+ } });+ try {+ const stageId = context.start();+ const execution = context.runner.runStageRun(stageId);+ await expect.poll(() => context.repository.getStageRun(stageId)?.progress.totalBytes).toBe(200);+ expect(context.repository.getStageRun(stageId)?.progress).toMatchObject({+ phase: 'downloading', percent: 63, downloadedBytes: 125, totalBytes: 200+ });+ release();+ expect((await execution).status).toBe('succeeded');+ } finally { await context.close(); }+ });+it('preserves draft status on preview failure and rejects unsupported sources', async () => {const context = setup({ id: 'download', async run() { throw new CreatorExecutorError('network_unavailable', 'Preview download failed'); } });try {