Skip to content

Formerly KrillinAI, VideoTranslation and Dubbing Tool for 120+ Languages. Open-source AI workspace for creators, powered by Codex. Video downloader, video translation, create videos, images, audios, and edits with Agents in one place. For your Social Media like YouTube, TikTok, Instagram, etc.

feat: pass subtitle styles through pipeline

wulienfd97f095fc41
diff --git a/internal/pipeline/render.go b/internal/pipeline/render.go
index c9f5b253..fdc6527a 100644
--- a/internal/pipeline/render.go
+++ b/internal/pipeline/render.go
@@ -4,6 +4,7 @@ import (
"context"
"errors"
"krillin-ai/internal/service"
+ subtitlestyle "krillin-ai/internal/subtitle_style"
"krillin-ai/internal/types"
"os"
"path/filepath"
@@ -19,6 +20,7 @@ type RenderRequest struct {
Dubbed bool
MajorTitle string
MinorTitle string
+ SubtitleStyle *subtitlestyle.StyleSet
}
func Render(ctx context.Context, svc StageService, req RenderRequest) (Response, error) {
@@ -46,6 +48,7 @@ func Render(ctx context.Context, svc StageService, req RenderRequest) (Response,
TtsResultFilePath: manifest.Outputs.TTSAudio,
VerticalVideoMajorTitle: req.MajorTitle,
VerticalVideoMinorTitle: req.MinorTitle,
+ SubtitleStyle: req.SubtitleStyle,
}
rendered, err := svc.RenderVideo(ctx, service.RenderVideoRequest{
Workdir: req.Workdir,
diff --git a/internal/pipeline/render_test.go b/internal/pipeline/render_test.go
index 0775c594..3eaee9ea 100644
--- a/internal/pipeline/render_test.go
+++ b/internal/pipeline/render_test.go
@@ -4,6 +4,7 @@ import (
"context"
"encoding/json"
"krillin-ai/internal/service"
+ subtitlestyle "krillin-ai/internal/subtitle_style"
"os"
"path/filepath"
"strings"
@@ -44,6 +45,31 @@ func TestRenderHorizontalDubbedOutputName(t *testing.T) {
}
}
+func TestRenderPassesSubtitleStyleToService(t *testing.T) {
+ dir := t.TempDir()
+ fake := &renderFakeService{}
+ style := subtitlestyle.DefaultStyleSet()
+ req := RenderRequest{
+ Workdir: dir,
+ TaskID: "demo",
+ Video: "origin_video.mp4",
+ Subtitle: "bilingual_srt.srt",
+ Horizontal: true,
+ SubtitleStyle: style,
+ }
+
+ resp, err := Render(context.Background(), fake, req)
+ if err != nil {
+ t.Fatalf("Render() error = %v", err)
+ }
+ if !resp.OK {
+ t.Fatalf("OK = false, want true")
+ }
+ if fake.lastRender.StepParam == nil || fake.lastRender.StepParam.SubtitleStyle != style {
+ t.Fatalf("SubtitleStyle was not passed to service")
+ }
+}
+
func TestRenderVerticalBilingualOutputName(t *testing.T) {
dir := t.TempDir()
fake := &renderFakeService{}
diff --git a/internal/pipeline/subtitle.go b/internal/pipeline/subtitle.go
index e6fd450c..635455d3 100644
--- a/internal/pipeline/subtitle.go
+++ b/internal/pipeline/subtitle.go
@@ -4,6 +4,7 @@ import (
"context"
"errors"
"krillin-ai/internal/service"
+ subtitlestyle "krillin-ai/internal/subtitle_style"
"krillin-ai/internal/types"
"os"
"strings"
@@ -21,6 +22,7 @@ type SubtitleRequest struct {
CaptionSource CaptionSource
BilingualTop bool
MaxWordOneLine int
+ SubtitleStyle *subtitlestyle.StyleSet
}
func GenerateSubtitles(ctx context.Context, svc StageService, req SubtitleRequest) (Response, error) {
@@ -120,6 +122,7 @@ func subtitleStepParam(req SubtitleRequest) *types.SubtitleTaskStepParam {
MaxWordOneLine: maxWordOneLine,
VttSwitch: isYouTubeInput(req.Input) && req.CaptionSource != CaptionSourceWhisper,
EmbedSubtitleVideoType: "none",
+ SubtitleStyle: req.SubtitleStyle,
}
}
diff --git a/internal/pipeline/subtitle_test.go b/internal/pipeline/subtitle_test.go
index 8a78c29f..3f17ebfc 100644
--- a/internal/pipeline/subtitle_test.go
+++ b/internal/pipeline/subtitle_test.go
@@ -4,6 +4,7 @@ import (
"context"
"errors"
"krillin-ai/internal/service"
+ subtitlestyle "krillin-ai/internal/subtitle_style"
"krillin-ai/internal/types"
pkgimage "krillin-ai/pkg/image"
"testing"
@@ -15,6 +16,7 @@ type fakeStageService struct {
calls []string
prepareVTT []bool
prepareEmbedTypes []string
+ lastPrepare *types.SubtitleTaskStepParam
lastSpeech *types.SubtitleTaskStepParam
lastCoverPrompt string
lastCoverSize string
@@ -25,6 +27,7 @@ func (f *fakeStageService) PrepareMedia(_ context.Context, p *types.SubtitleTask
f.calls = append(f.calls, "prepare")
f.prepareVTT = append(f.prepareVTT, p.VttSwitch)
f.prepareEmbedTypes = append(f.prepareEmbedTypes, p.EmbedSubtitleVideoType)
+ f.lastPrepare = p
return nil
}
@@ -90,6 +93,32 @@ func TestGenerateSubtitlesFallsBackToAudioWhenAnySourceFails(t *testing.T) {
}
}
+func TestGenerateSubtitlesPassesSubtitleStyleToStepParam(t *testing.T) {
+ dir := t.TempDir()
+ fake := &fakeStageService{}
+ style := subtitlestyle.DefaultStyleSet()
+ req := SubtitleRequest{
+ Input: "local:demo.mp4",
+ Workdir: dir,
+ TaskID: "demo",
+ OriginLang: "en",
+ TargetLang: "zh_cn",
+ CaptionSource: CaptionSourceWhisper,
+ SubtitleStyle: style,
+ }
+
+ resp, err := GenerateSubtitles(context.Background(), fake, req)
+ if err != nil {
+ t.Fatalf("GenerateSubtitles() error = %v", err)
+ }
+ if !resp.OK {
+ t.Fatalf("OK = false, want true")
+ }
+ if fake.lastPrepare == nil || fake.lastPrepare.SubtitleStyle != style {
+ t.Fatalf("SubtitleStyle was not passed to stepParam")
+ }
+}
+
func TestGenerateSubtitlesManualDoesNotFallback(t *testing.T) {
dir := t.TempDir()
fake := &fakeStageService{downloadErr: errors.New("no captions")}