The open-source CapCut alternative
fix: removed the media from timeline after its deleted
Notoriousbraincf6ef8f1c4a9
diff --git a/apps/web/src/stores/media-store.ts b/apps/web/src/stores/media-store.tsindex c4ee5f3e..6eb06e35 100644--- a/apps/web/src/stores/media-store.ts+++ b/apps/web/src/stores/media-store.ts@@ -183,24 +183,46 @@ export const useMediaStore = create<MediaStore>((set, get) => ({}},- removeMediaItem: async (projectId, id: string) => {+ removeMediaItem: async (projectId: string, id: string) => {const state = get();const item = state.mediaItems.find((media) => media.id === id);// Cleanup object URLs to prevent memory leaks- if (item && item.url) {+ if (item?.url) {URL.revokeObjectURL(item.url);if (item.thumbnailUrl) {URL.revokeObjectURL(item.thumbnailUrl);}}- // Remove from local state immediately+ // 1) Remove from local state immediatelyset((state) => ({mediaItems: state.mediaItems.filter((media) => media.id !== id),}));- // Remove from persistent storage+ // 2) Cascade into the timeline: remove any elements using this media ID+ const timeline = useTimelineStore.getState();+ const {+ tracks,+ removeElementFromTrack,+ removeElementFromTrackWithRipple,+ rippleEditingEnabled,+ } = timeline;++ // Iterate over a snapshot of tracks and their elements+ tracks.forEach((track) => {+ track.elements.forEach((el) => {+ if (el.type === "media" && el.mediaId === id) {+ if (rippleEditingEnabled) {+ removeElementFromTrackWithRipple(track.id, el.id);+ } else {+ removeElementFromTrack(track.id, el.id);+ }+ }+ });+ });++ // 3) Remove from persistent storagetry {await storageService.deleteMediaItem(projectId, id);} catch (error) {@@ -219,15 +241,19 @@ export const useMediaStore = create<MediaStore>((set, get) => ({mediaItems.map(async (item) => {if (item.type === "video" && item.file) {try {- const { thumbnailUrl, width, height } = await generateVideoThumbnail(item.file);+ const { thumbnailUrl, width, height } =+ await generateVideoThumbnail(item.file);return {...item,thumbnailUrl,width: width || item.width,- height: height || item.height+ height: height || item.height,};} catch (error) {- console.error(`Failed to regenerate thumbnail for video ${item.id}:`, error);+ console.error(+ `Failed to regenerate thumbnail for video ${item.id}:`,+ error+ );return item;}}