Your always-on AI coworkers that move between text, calls, and Slack.
TypeScript
fix: submit the home composer on Enter (#95)
Charan Rathore9e9f22c9a17c
diff --git a/src/client/App.tsx b/src/client/App.tsxindex 04255d3..608f1f9 100644--- a/src/client/App.tsx+++ b/src/client/App.tsx@@ -47,6 +47,7 @@ import { ResultPane } from './ResultPane';import { TaskRow } from './TaskPresentation';import { TaskActions } from './TaskActions';import { WorkspaceDialog, type Dialog } from './WorkspaceDialog';+import { submitComposerOnEnter } from './chat-composer';function describeFailure(error: unknown, fallback: string) {return {@@ -700,6 +701,12 @@ export function App() {value={prompt}maxLength={4000}onChange={(e) => setPrompt(e.target.value)}+ onKeyDown={(e) =>+ submitComposerOnEnter(+ e,+ configured && !busy && !!prompt.trim(),+ )+ }disabled={!configured}/><div className="composer-bottom">diff --git a/src/client/chat-composer.ts b/src/client/chat-composer.tsindex 039ebbf..e55dbc5 100644--- a/src/client/chat-composer.ts+++ b/src/client/chat-composer.ts@@ -13,3 +13,15 @@ export function shouldSubmitComposerOnKeyDown(event: {event.nativeEvent.keyCode !== 229);}++export function submitComposerOnEnter(+ event: Parameters<typeof shouldSubmitComposerOnKeyDown>[0] & {+ preventDefault(): void;+ currentTarget: { form?: { requestSubmit(): void } | null };+ },+ canSubmit: boolean,+) {+ if (!shouldSubmitComposerOnKeyDown(event)) return;+ event.preventDefault();+ if (canSubmit) event.currentTarget.form?.requestSubmit();+}diff --git a/tests/chat-composer.test.ts b/tests/chat-composer.test.tsindex 71a2f10..0b5e7bf 100644--- a/tests/chat-composer.test.ts+++ b/tests/chat-composer.test.ts@@ -1,5 +1,8 @@-import { expect, it } from 'vitest';-import { shouldSubmitComposerOnKeyDown } from '../src/client/chat-composer';+import { expect, it, vi } from 'vitest';+import {+ shouldSubmitComposerOnKeyDown,+ submitComposerOnEnter,+} from '../src/client/chat-composer';function keyEvent({key = 'Enter',@@ -41,3 +44,40 @@ it('keeps Shift+Enter available for multiline drafts', () => {false,);});++function enterEvent(init: Parameters<typeof keyEvent>[0] = {}) {+ const requestSubmit = vi.fn();+ const preventDefault = vi.fn();+ return {+ requestSubmit,+ preventDefault,+ event: {+ ...keyEvent(init),+ preventDefault,+ currentTarget: { form: { requestSubmit } },+ },+ };+}++it('submits the form when Enter is pressed in the home composer', () => {+ const { event, requestSubmit, preventDefault } = enterEvent();+ submitComposerOnEnter(event, true);+ expect(preventDefault).toHaveBeenCalled();+ expect(requestSubmit).toHaveBeenCalledTimes(1);+});++it('keeps Enter from adding a line but does not submit an empty or busy composer', () => {+ const { event, requestSubmit, preventDefault } = enterEvent();+ submitComposerOnEnter(event, false);+ expect(preventDefault).toHaveBeenCalled();+ expect(requestSubmit).not.toHaveBeenCalled();+});++it('leaves Shift+Enter alone so it still inserts a newline', () => {+ const { event, requestSubmit, preventDefault } = enterEvent({+ shiftKey: true,+ });+ submitComposerOnEnter(event, true);+ expect(preventDefault).not.toHaveBeenCalled();+ expect(requestSubmit).not.toHaveBeenCalled();+});