AI-powered virtual executive team — a single coherent executive persona backed by 8 specialist agents (FastAPI + Next.js).
fix(attunement): scope outcome credit to the person who acted
Rufus0590008663b5
diff --git a/packages/core/openexecutive/alerts/lifecycle.py b/packages/core/openexecutive/alerts/lifecycle.pyindex 2015e3cd..88795c7b 100644--- a/packages/core/openexecutive/alerts/lifecycle.py+++ b/packages/core/openexecutive/alerts/lifecycle.py@@ -198,12 +198,17 @@ def expire_stale_alerts(]if not expired_ids:return 0- count = len(bulk_set_status(+ changed = bulk_set_status(EXPIRED_STATUS, alert_ids=expired_ids, only_status="unread", db_path=db_path- ))+ )+ count = len(changed)except Exception:logger.exception("alerts.lifecycle: expiry sweep failed")return 0+ # An alert nobody acted on before its TTL didn't matter: void the review's+ # DMs about it rather than leave them counted as ignored.+ for alert_id in expired_ids:+ resolve_alert_outreach(_AlertRef(alert_id), EXPIRED_STATUS)if count:try:@@ -243,7 +248,15 @@ def mute_pattern_for(alert: Alert) -> str | None:return tags[0] if tags else None-def resolve_alert_outreach(alert: Alert, status: str) -> None:+class _AlertRef:+ """Just enough of an Alert for :func:`resolve_alert_outreach` to void it."""++ def __init__(self, alert_id: int) -> None:+ self.id: int | None = alert_id+ self.routed_to_person_id: int | None = None+++def resolve_alert_outreach(alert: Alert | _AlertRef, status: str) -> None:"""Resolve the Attunement outcome rows for review DMs about ``alert``.Acknowledged or resolved: the DMs to the person it is routed to (and todiff --git a/packages/core/openexecutive/architecture/architecture-facts.yaml b/packages/core/openexecutive/architecture/architecture-facts.yamlindex f123e4ec..5e8d1f3d 100644--- a/packages/core/openexecutive/architecture/architecture-facts.yaml+++ b/packages/core/openexecutive/architecture/architecture-facts.yaml@@ -1581,24 +1581,30 @@ attunement:web-chat sends (no linkage by design).resolution: |replied — `mark_outbound_context_consumed`. acted — close_open_loop with- reason reported_done, or done closed by the owner themselves (principal- tidy-up credits nobody); `resumer.apply_resolution` resolves- nudge:stalled:<run_id>; store_initiative/update_initiative on an existing- initiative resolves nudge:initiative:<id>; alert ack or resolved+ reason reported_done or done, only when closed_by_person_id is the owner+ (principal tidy-up, or the principal saying someone else's loop is done,+ credits nobody); `resumer.apply_resolution` resolves+ nudge:stalled:<run_id> for resolution.person_id only;+ store_initiative/update_initiative resolve nudge:initiative:<id> only on+ a real change (new status or summary) and only for+ `updated_by_person_id` — the extractor passes the principal (it runs on+ principal turns only), PATCH /memories/initiatives/{id} passes nothing+ (no caller identity, no auth) so it credits nobody; alert ack or resolved(`alerts.lifecycle.resolve_alert_outreach`, also called by alert reviewwhen it closes an alert) — scoped to routed_to_person_id + principal.- void — alert dismissed / stale: excluded from every rate, so a dismissal- (POST /alerts/{id}/ack has no per-caller authz, pre-existing) can never- push someone toward demotion. ignored — `sweep_ignored` at the start of+ void — alert dismissed / stale / expired (expiry sweep): excluded from+ every rate, so a dismissal (POST /alerts/{id}/ack has no per-caller+ authz, pre-existing) can never push someone toward demotion. acted and+ void override an earlier ignored (done after the sweep is the truer+ verdict); replied does not. ignored — `sweep_ignored` at the start ofeach nudge scan AND lazily in acceptance()/muted_pairs() (rates stay- honest with NUDGE_SCAN_ENABLED=false). Only rows still open are touched.- Recording skips email cc's (only the first `to` address) and principal- self follow-ups.+ honest with NUDGE_SCAN_ENABLED=false). Recording skips email cc's (only+ the first rostered `to` address) and principal self follow-ups.use: |`acceptance()` per (person, source), 30 days, voids excluded.nudge_engine `_apply_outcome_feedback` uses `muted_pairs(min_sends)`:demoted when the person's LAST ATTUNEMENT_MUTE_MIN_SENDS (5) resolved- sends of that source were all unanswered → cooldown x+ sends of that source (ordered by created_at) were all unanswered → cooldown xMUTE_COOLDOWN_MULTIPLIER (3), ranked last in `_apply_caps`; neverdropped; one answer lifts it (a 30-day share would not — reviewfinding). Reflection WHAT LANDS block (sources with >=3 resolved).diff --git a/packages/core/openexecutive/architecture/prebuilt/attunement.json b/packages/core/openexecutive/architecture/prebuilt/attunement.jsonindex ec46b139..89d6d6d4 100644--- a/packages/core/openexecutive/architecture/prebuilt/attunement.json+++ b/packages/core/openexecutive/architecture/prebuilt/attunement.json@@ -1,7 +1,7 @@{"section_id": "attunement","title": "Attunement (Open Loops)",- "markdown": "Attunement is the Executive adapting to each person it works with. Its first piece is **open loops**: the concrete things someone on the roster committed to, or was asked for, in conversation — tracked until they're done, and chased when they slip. It lives in `openexecutive.attunement`.\n\n### Why it exists\n\nBefore this, commitments were captured only from the principal's own words (`memory.episodic.should_extract` requires `is_principal`), because stored messages did not record who said them. A teammate's \"I'll send the vendor quote by Thursday\" vanished. And nothing in production ever set `scheduled_actions.awaiting_response_since`, so the nudge engine's commitment-chasing source had nothing to chase.\n\n### Sender attribution and feedback\n\nEvery persisted user message records `chat_messages.sender_person_id`: the **resolved** rostered sender, never the session owner. Discord and Telegram sessions from unrostered senders are owned by the principal so they still show in the sidebar; attribution keeps those outsiders' words from ever being read as the principal's. The web route passes its header-resolved caller (a header-less caller is the principal's own CLI / API surface; a signed-in email not on the roster resolves to nobody). Slack, Discord and Telegram pass the sender they resolved. For the turn itself, the Executive records the resolved speaker on `Session.caller_person_id`, which tool handlers read.\n\nAssistant replies can carry explicit feedback: `chat_messages.feedback` (`up` / `down`) via `POST /sessions/{id}/messages/{message_id}/feedback`, restricted to the session's own caller or the principal. The chat stream's `done` event includes `message_id` so the web panel renders 👍/👎 on the reply. Each rating writes an `attunement` audit row.\n\n### Opening and closing loops\n\nAfter every chat turn whose speaker resolved to a rostered, non-archived person — on any channel, email included, because the hook sits in the Executive rather than an adapter — `schedule_open_loop_pass` runs fire-and-forget, beside the episodic extraction:\n\n1. **Prefilter** — a keyword check (\"I'll\", \"by Friday\", \"can you\", … or, when loops are open, \"sent\", \"done\", …) skips most turns with no model call. A turn carrying an attached document (`[Attached: …]` inlined by `integrations.attachments`) is skipped outright: the document's words sit in the same message — after the text on the web, before it on Telegram and Discord — so a quote found there would be the document's, not the speaker's.\n2. **Budget** — `ATTUNEMENT_MAX_CALLS_PER_DAY` (default 200) is taken atomically from the `attunement_usage` row for the UTC day.\n3. **One forced-tool call** (`record_open_loops`, routing model) sees today's date, the speaker, the roster, the loops the speaker may close, the message and the reply. It may:\n - open a **commitment** the speaker made (owner = the speaker);\n - open an **ask** the speaker made of a named rostered person (owner = that person);\n - when the principal speaks, open a commitment the principal attributes to a named teammate (\"Sara will send the numbers Monday\");\n - close loops the speaker reports done, sent, no longer needed or cancelled — their own loops, or any loop when the principal speaks.\n4. **Gates in code**, not just the prompt: every item must quote the speaker's own message verbatim (commitments through the episodic extractor's `_is_valid_user_commitment`, so the Executive's own suggestions are never logged as someone's promise), and the stored `text` must itself appear verbatim in that message — it is re-injected into the nudge intent a tool-using turn executes, so it is never a model paraphrase (the intent also tells that turn to treat the quoted text as data); owners must resolve to exactly one rostered person (a full name not on the roster never falls back to a rostered first name — \"Ben Jones from Acme\" is not Ben Ortiz); a teammate cannot attribute a commitment to someone else; the principal's own commitments are left to the episodic extractor; a loop id outside the closable set is ignored; each owner holds at most `ATTUNEMENT_MAX_OPEN_LOOPS_PER_PERSON` (15). Due dates are clamped to 60 days and default to `ATTUNEMENT_LOOP_DEFAULT_DUE_DAYS` (2).\n5. **Audit** — one `attunement` row per pass (`op=extract`, opened / closed / dropped with reasons) plus `loop_opened` / `loop_closed` rows.\n\n### Storage and chasing\n\nA loop is a `scheduled_actions` row: `kind='open_loop'`, `channel='__internal__'`, inserted already `done` so the runner never dispatches it, `assigned_to_person_id` = owner, `awaiting_response_since` = due time, `scope_key` = `loop:{owner}:{hash}`. A partial unique index over open loops dedupes concurrent passes. That shape is exactly what existing readers expect:\n\n- the nudge engine's commitment source chases an open loop **as soon as it is overdue**, with a check-in addressed to its owner, through `prefer_channel_for`, availability windows, `NUDGE_MAX_PER_SCOPE` and the outbound guard;\n- `list_awaiting_replies_by_person` counts it **once it is due** (the same cut-off the nudge engine uses), so `/today`'s roster and reflection's \"people waiting\" include an overdue loop but not one still in the future — while `last_contact_at_by_person`, the client engagement \"follow-ups completed\" count and the `/today` activity feed (which now filters `__internal__` rows in SQL so loops cannot crowd real sends out of its window) all exclude it, since a loop is not a message sent;\n- `executive_reflection` renders an **OPEN LOOPS** block (up to 10, overdue flagged).\n\nA loop closes (its `awaiting_response_since` cleared, audited) when the owner reports it done, when the principal or owner calls `close_open_loop` or uses **Mark done** on the person's page, when its owner is archived, or when it passes `ATTUNEMENT_LOOP_TTL_DAYS` (21) — expired at the start of each nudge scan.\n\n### Who can see and close a loop\n\nWhat someone owes is not roster-public. `list_open_loops` shows the principal everyone's loops only on a **private surface** — web chat, a Slack or Discord DM, or a 1:1 Telegram chat; in a shared channel or thread, a Telegram group, a Google Chat space or an email thread (which can carry cc's), and for anyone else, it shows only the caller's own loops, and an unresolved caller gets nothing. `GET /people/{id}/open-loops` is the principal's or that person's only.\n\n`close_open_loop` (chat tool) and `POST /open-loops/{id}/close` only close when the resolved caller is the principal or the loop's owner. Every one of these checks, and the feedback route's, goes through one helper, `people.store.is_principal_or_self`. Loop ids appear in prompts and replies and inbound email reaches the Executive, so a quoted \"close loop 12\" from an unrostered sender, a signed-in web user not on the roster, or an unattended session (a scheduled nudge's prompt quotes the loop text) is refused. The reflection pass is not given the tool at all.\n\n### Outcome ledger — what lands, per person\n\n`attunement.outcomes` records every **proactive** DM to a rostered person and resolves it with no model call, so the Executive can do more of what gets answered and less of what doesn't.\n\n- **Recording.** Proactive work tags itself with `tag_proactive(source, ref)` — a ContextVar, wrapped only around non-yielding code — and the single point every DM passes through, `schedule_tools._record_outbound_context`, writes a `proactive_outcomes` row next to the `outbound_context` linkage when a tag is set and the recipient resolves to a Person. Tagged callers: the scheduler's generic dispatch (a nudge is `nudge_stalled` / `nudge_commitment` / `nudge_initiative`, or `open_loop` when its commitment target is an open loop, keyed by its scope key; anything else is `followup`), `executive_reflection` (`reflection`), `executive_research` (`research`) and alert review (`alert_review`, keyed `alert:<id>`). A user's own chat turn is never tagged, and web-chat sends write no linkage. Only the addressed recipient counts: an email's first `to` address gets a row, its cc's only get reply linkage; and a follow-up the principal scheduled for themselves is not outreach.\n- **Resolution.** `replied` when the recipient's reply consumes the linkage (`mark_outbound_context_consumed`). `acted` when the thing it was about got done, however it was done: the open loop a chase was about is reported done **by its owner** (the principal tidying a loop away credits nobody); the approval a stalled-run nudge chased is resolved (`resumer.apply_resolution`); the initiative a check-in was about is updated; or the alert a review DM was about is acknowledged or resolved — credited only to the person it is routed to and the principal, never to someone DM'd about it on an earlier pass. `void` when that alert is dismissed or found stale: the DM didn't matter, so it counts neither way — a dismissal, which anyone with API access can make, can never lower someone's rate. `ignored` when still open after `ATTUNEMENT_IGNORE_AFTER_HOURS` (72) — swept at the start of each nudge scan and whenever rates are read, so the rates stay honest with the scan disabled. Expired, cancelled or archived loops resolve nothing.\n- **Use.** `acceptance()` gives per-(person, source) counts over 30 days. The nudge engine demotes a candidate whose person left their **last** `ATTUNEMENT_MUTE_MIN_SENDS` (5) resolved sends of that source all unanswered (`muted_pairs`): it ranks after every other candidate and its cooldown is multiplied by `ATTUNEMENT_MUTE_COOLDOWN_MULTIPLIER` (3). It is never dropped, and a single answer lifts it — judged on the most recent sends rather than a 30-day share, which would keep a demoted source (with fewer chances to be answered) demoted long after the person came back. Reflection gets a **WHAT LANDS** block (per person, per source with ≥3 resolved), and the prompt steers DMs toward the kinds that land. `GET /people/{id}/outreach` (principal or that person) backs a \"How they respond\" card on the person page.\n\n### Settings\n\n`ATTUNEMENT_ENABLED`, `ATTUNEMENT_OPEN_LOOPS_ENABLED`, `ATTUNEMENT_LOOP_DEFAULT_DUE_DAYS`, `ATTUNEMENT_LOOP_TTL_DAYS`, `ATTUNEMENT_MAX_OPEN_LOOPS_PER_PERSON`, `ATTUNEMENT_MAX_CALLS_PER_DAY`, `ATTUNEMENT_IGNORE_AFTER_HOURS`, `ATTUNEMENT_MUTE_MIN_SENDS`, `ATTUNEMENT_MUTE_COOLDOWN_MULTIPLIER`. The open loops themselves live in `scheduled_actions` and the attribution columns in `chat_messages`, both wiped by company switches and resets; `attunement_usage` and `proactive_outcomes` are wiped with them.\n\n### Known gaps\n\nEmail and Google Chat turns open and close loops (the hook is in the Executive) but do not persist `chat_messages`, so they carry no stored attribution or feedback. `POST /alerts/{id}/ack` has no per-caller authorization (pre-existing), which is why a dismissal voids rather than counts against anyone. Principal briefs and dynamic-workflow deliveries run without a chat session, so they write no outreach linkage and are not in the outcome ledger; broadcasts to a channel have no single recipient and are not counted either.",+ "markdown": "Attunement is the Executive adapting to each person it works with. Its first piece is **open loops**: the concrete things someone on the roster committed to, or was asked for, in conversation — tracked until they're done, and chased when they slip. It lives in `openexecutive.attunement`.\n\n### Why it exists\n\nBefore this, commitments were captured only from the principal's own words (`memory.episodic.should_extract` requires `is_principal`), because stored messages did not record who said them. A teammate's \"I'll send the vendor quote by Thursday\" vanished. And nothing in production ever set `scheduled_actions.awaiting_response_since`, so the nudge engine's commitment-chasing source had nothing to chase.\n\n### Sender attribution and feedback\n\nEvery persisted user message records `chat_messages.sender_person_id`: the **resolved** rostered sender, never the session owner. Discord and Telegram sessions from unrostered senders are owned by the principal so they still show in the sidebar; attribution keeps those outsiders' words from ever being read as the principal's. The web route passes its header-resolved caller (a header-less caller is the principal's own CLI / API surface; a signed-in email not on the roster resolves to nobody). Slack, Discord and Telegram pass the sender they resolved. For the turn itself, the Executive records the resolved speaker on `Session.caller_person_id`, which tool handlers read.\n\nAssistant replies can carry explicit feedback: `chat_messages.feedback` (`up` / `down`) via `POST /sessions/{id}/messages/{message_id}/feedback`, restricted to the session's own caller or the principal. The chat stream's `done` event includes `message_id` so the web panel renders 👍/👎 on the reply. Each rating writes an `attunement` audit row.\n\n### Opening and closing loops\n\nAfter every chat turn whose speaker resolved to a rostered, non-archived person — on any channel, email included, because the hook sits in the Executive rather than an adapter — `schedule_open_loop_pass` runs fire-and-forget, beside the episodic extraction:\n\n1. **Prefilter** — a keyword check (\"I'll\", \"by Friday\", \"can you\", … or, when loops are open, \"sent\", \"done\", …) skips most turns with no model call. A turn carrying an attached document (`[Attached: …]` inlined by `integrations.attachments`) is skipped outright: the document's words sit in the same message — after the text on the web, before it on Telegram and Discord — so a quote found there would be the document's, not the speaker's.\n2. **Budget** — `ATTUNEMENT_MAX_CALLS_PER_DAY` (default 200) is taken atomically from the `attunement_usage` row for the UTC day.\n3. **One forced-tool call** (`record_open_loops`, routing model) sees today's date, the speaker, the roster, the loops the speaker may close, the message and the reply. It may:\n - open a **commitment** the speaker made (owner = the speaker);\n - open an **ask** the speaker made of a named rostered person (owner = that person);\n - when the principal speaks, open a commitment the principal attributes to a named teammate (\"Sara will send the numbers Monday\");\n - close loops the speaker reports done, sent, no longer needed or cancelled — their own loops, or any loop when the principal speaks.\n4. **Gates in code**, not just the prompt: every item must quote the speaker's own message verbatim (commitments through the episodic extractor's `_is_valid_user_commitment`, so the Executive's own suggestions are never logged as someone's promise), and the stored `text` must itself appear verbatim in that message — it is re-injected into the nudge intent a tool-using turn executes, so it is never a model paraphrase (the intent also tells that turn to treat the quoted text as data); owners must resolve to exactly one rostered person (a full name not on the roster never falls back to a rostered first name — \"Ben Jones from Acme\" is not Ben Ortiz); a teammate cannot attribute a commitment to someone else; the principal's own commitments are left to the episodic extractor; a loop id outside the closable set is ignored; each owner holds at most `ATTUNEMENT_MAX_OPEN_LOOPS_PER_PERSON` (15). Due dates are clamped to 60 days and default to `ATTUNEMENT_LOOP_DEFAULT_DUE_DAYS` (2).\n5. **Audit** — one `attunement` row per pass (`op=extract`, opened / closed / dropped with reasons) plus `loop_opened` / `loop_closed` rows.\n\n### Storage and chasing\n\nA loop is a `scheduled_actions` row: `kind='open_loop'`, `channel='__internal__'`, inserted already `done` so the runner never dispatches it, `assigned_to_person_id` = owner, `awaiting_response_since` = due time, `scope_key` = `loop:{owner}:{hash}`. A partial unique index over open loops dedupes concurrent passes. That shape is exactly what existing readers expect:\n\n- the nudge engine's commitment source chases an open loop **as soon as it is overdue**, with a check-in addressed to its owner, through `prefer_channel_for`, availability windows, `NUDGE_MAX_PER_SCOPE` and the outbound guard;\n- `list_awaiting_replies_by_person` counts it **once it is due** (the same cut-off the nudge engine uses), so `/today`'s roster and reflection's \"people waiting\" include an overdue loop but not one still in the future — while `last_contact_at_by_person`, the client engagement \"follow-ups completed\" count and the `/today` activity feed (which now filters `__internal__` rows in SQL so loops cannot crowd real sends out of its window) all exclude it, since a loop is not a message sent;\n- `executive_reflection` renders an **OPEN LOOPS** block (up to 10, overdue flagged).\n\nA loop closes (its `awaiting_response_since` cleared, audited) when the owner reports it done, when the principal or owner calls `close_open_loop` or uses **Mark done** on the person's page, when its owner is archived, or when it passes `ATTUNEMENT_LOOP_TTL_DAYS` (21) — expired at the start of each nudge scan.\n\n### Who can see and close a loop\n\nWhat someone owes is not roster-public. `list_open_loops` shows the principal everyone's loops only on a **private surface** — web chat, a Slack or Discord DM, or a 1:1 Telegram chat; in a shared channel or thread, a Telegram group, a Google Chat space or an email thread (which can carry cc's), and for anyone else, it shows only the caller's own loops, and an unresolved caller gets nothing. `GET /people/{id}/open-loops` is the principal's or that person's only.\n\n`close_open_loop` (chat tool) and `POST /open-loops/{id}/close` only close when the resolved caller is the principal or the loop's owner. Every one of these checks, and the feedback route's, goes through one helper, `people.store.is_principal_or_self`. Loop ids appear in prompts and replies and inbound email reaches the Executive, so a quoted \"close loop 12\" from an unrostered sender, a signed-in web user not on the roster, or an unattended session (a scheduled nudge's prompt quotes the loop text) is refused. The reflection pass is not given the tool at all.\n\n### Outcome ledger — what lands, per person\n\n`attunement.outcomes` records every **proactive** DM to a rostered person and resolves it with no model call, so the Executive can do more of what gets answered and less of what doesn't.\n\n- **Recording.** Proactive work tags itself with `tag_proactive(source, ref)` — a ContextVar, wrapped only around non-yielding code — and the single point every DM passes through, `schedule_tools._record_outbound_context`, writes a `proactive_outcomes` row next to the `outbound_context` linkage when a tag is set and the recipient resolves to a Person. Tagged callers: the scheduler's generic dispatch (a nudge is `nudge_stalled` / `nudge_commitment` / `nudge_initiative`, or `open_loop` when its commitment target is an open loop, keyed by its scope key; anything else is `followup`), `executive_reflection` (`reflection`), `executive_research` (`research`) and alert review (`alert_review`, keyed `alert:<id>`). A user's own chat turn is never tagged, and web-chat sends write no linkage. Only the addressed recipient counts: an email's first rostered `to` address gets a row, its cc's and any other recipients only get reply linkage; and a follow-up the principal scheduled for themselves is not outreach.\n- **Resolution.** `replied` when the recipient's reply consumes the linkage (`mark_outbound_context_consumed`). `acted` when the thing it was about got done, however it was done: the open loop a chase was about is reported done **by its owner** (the principal tidying a loop away, or saying someone else's is done, credits nobody); the approval a stalled-run nudge chased is resolved (`resumer.apply_resolution`), credited to the person who resolved it; the initiative a check-in was about gets a real change (a new status or summary, not a re-mention), credited only to the person who made it — an edit through `PATCH /memories/initiatives/{id}`, which carries no caller identity, credits nobody; or the alert a review DM was about is acknowledged or resolved — credited only to the person it is routed to and the principal, never to someone DM'd about it on an earlier pass. `void` when that alert is dismissed, found stale or expires unread: the DM didn't matter, so it counts neither way — a dismissal, which anyone with API access can make, can never lower someone's rate. `ignored` when still open after `ATTUNEMENT_IGNORE_AFTER_HOURS` (72) — swept at the start of each nudge scan and whenever rates are read, so the rates stay honest with the scan disabled. A later `acted` or `void` overrides an earlier `ignored` — the thing can get done days after the sweep, and that verdict is the truer one; a late reply does not. Expired, cancelled or archived loops resolve nothing.\n- **Use.** `acceptance()` gives per-(person, source) counts over 30 days. The nudge engine demotes a candidate whose person left their **last** `ATTUNEMENT_MUTE_MIN_SENDS` (5) resolved sends (by send time) of that source all unanswered (`muted_pairs`): it ranks after every other candidate and its cooldown is multiplied by `ATTUNEMENT_MUTE_COOLDOWN_MULTIPLIER` (3). It is never dropped, and a single answer lifts it — judged on the most recent sends rather than a 30-day share, which would keep a demoted source (with fewer chances to be answered) demoted long after the person came back. Reflection gets a **WHAT LANDS** block (per person, per source with ≥3 resolved), and the prompt steers DMs toward the kinds that land. `GET /people/{id}/outreach` (principal or that person) backs a \"How they respond\" card on the person page.\n\n### Settings\n\n`ATTUNEMENT_ENABLED`, `ATTUNEMENT_OPEN_LOOPS_ENABLED`, `ATTUNEMENT_LOOP_DEFAULT_DUE_DAYS`, `ATTUNEMENT_LOOP_TTL_DAYS`, `ATTUNEMENT_MAX_OPEN_LOOPS_PER_PERSON`, `ATTUNEMENT_MAX_CALLS_PER_DAY`, `ATTUNEMENT_IGNORE_AFTER_HOURS`, `ATTUNEMENT_MUTE_MIN_SENDS`, `ATTUNEMENT_MUTE_COOLDOWN_MULTIPLIER`. The open loops themselves live in `scheduled_actions` and the attribution columns in `chat_messages`, both wiped by company switches and resets; `attunement_usage` and `proactive_outcomes` are wiped with them.\n\n### Known gaps\n\nEmail and Google Chat turns open and close loops (the hook is in the Executive) but do not persist `chat_messages`, so they carry no stored attribution or feedback. `POST /alerts/{id}/ack` has no per-caller authorization (pre-existing), which is why a dismissal voids rather than counts against anyone. Principal briefs and dynamic-workflow deliveries run without a chat session, so they write no outreach linkage and are not in the outcome ledger; broadcasts to a channel have no single recipient and are not counted either.","mermaid": "flowchart TD\n Turn[\"Chat turn<br/>(any channel)\"]\n Resolve[\"Resolved speaker<br/>(rostered, not archived)\"]\n Persist[(\"chat_messages<br/>sender_person_id · feedback\")]\n Pre[\"Prefilter + daily budget\"]\n LLM[\"record_open_loops<br/>(forced tool)\"]\n Gate[\"Code gates<br/>verbatim quote · owner · closable set\"]\n Loops[(\"scheduled_actions<br/>kind=open_loop\")]\n Nudge[\"nudge_engine<br/>commitment source\"]\n Guard[\"prefer_channel_for<br/>+ outbound guard\"]\n Owner[\"Owner's channel\"]\n Reflect[\"executive_reflection<br/>OPEN LOOPS block\"]\n Today[\"/today awaiting counts\"]\n Close[\"close_open_loop · Mark done<br/>archive · TTL expiry\"]\n Turn --> Resolve\n Resolve --> Persist\n Resolve --> Pre\n Pre --> LLM\n LLM --> Gate\n Gate -- \"open / close\" --> Loops\n Loops -- \"overdue\" --> Nudge\n Nudge --> Guard\n Guard --> Owner\n Loops --> Reflect\n Loops --> Today\n Close --> Loops\n class Turn entry\n class Resolve compute\n class Persist storage\n class Pre compute\n class LLM hot\n class Gate compute\n class Loops storage\n class Nudge compute\n class Guard compute\n class Owner external\n class Reflect compute\n class Today compute\n class Close compute","generated_at": "2026-09-22T23:17:20.508677+00:00"}diff --git a/packages/core/openexecutive/architecture/prebuilt/memory.json b/packages/core/openexecutive/architecture/prebuilt/memory.jsonindex f5d393f4..889a0373 100644--- a/packages/core/openexecutive/architecture/prebuilt/memory.json+++ b/packages/core/openexecutive/architecture/prebuilt/memory.json@@ -1,7 +1,7 @@{"section_id": "memory","title": "Memory System",- "markdown": "The Executive's durable memory is an episodic SQLite store at `./episodic_memory.db`, managed by `openexecutive.memory.episodic`. It holds four tables:\n\n- `decisions` — choices made, with `domain`, `summary`, `rationale`, `outcome`, and `tags`.\n- `initiatives` — tracked efforts with a `status` and `summary` (idempotent upserts).\n- `advice_given` — query/advice pairs per domain.\n- `scheduled_actions` — a dispatch queue, treated separately from recall memory.\n\n### What gets extracted, and when\n\n`episodic.extract_and_store` runs after a turn and asks a utility-fast model for decisions, initiatives and advice. Every candidate must carry a `user_commitment_quote` that appears verbatim in the principal's own message (`_is_valid_user_commitment`) — the model has repeatedly tried to log the Executive's *recommendations* as the user's commitments, and that quote is the hard gate against it.\n\nA turn reaches the extractor if `should_extract(user_message)` is true, which means only that the principal said something — there is deliberately **no length floor**. There used to be one, on the combined user+assistant length, and on a live tenant it selected almost exactly the wrong turns: 9 of 16 exchanges were blocked, and the 9 held every instruction the principal gave, while the 7 admitted were long analytical exchanges with no commitment in them. The extractor ran 13 times and stored nothing.\n\nMoving that floor to the user's side would relocate the bug, not fix it. The canonical executive decision is a long analysis answered with \"Approve option B.\" (17 chars) or \"Do B.\" (5), and any floor high enough to skip \"Done\" (4) also skips those — \"Do B.\" and \"Done\" differ by one character and mean opposite things. Length cannot separate a decision from an acknowledgement; the verbatim-quote check can, so `_is_valid_user_commitment` is the gate that decides. The price is one utility-fast call on turns that propose nothing.\n\nThat quote check is only meaningful when `user_message` holds the **principal's** words, and on a chat channel it does not — `Executive.chat()` is reached from Slack, Discord, Telegram, Google Chat and the email poller. A teammate's line would be written to `decisions` with no speaker attached, indistinguishable from the principal's own; an inbound email body is text the sender chose, so a self-quote is free. Removing the length floor is what makes this bite — short channel traffic used to fall under it incidentally — so `should_extract` also takes the turn's `origin_channel` and `person_id`. No channel means the web app, the CLI or the API, all of them the principal's own authenticated surfaces, where `person_id` is legitimately null in a single-user install. A turn that names a channel must resolve to a person marked `is_principal`, and an unresolvable speaker fails closed.\n\nEach pass writes a `memory_extraction` audit row — in a `finally`, so a pass that crashed is recorded too, with the exception type as its `failure` reason: how many items the model proposed, how many were stored, a `malformed` count so a pass where the model returned only garbage does not read as one that found nothing, and a `{kind, reason}` record per drop — `bad_quote` and `missing_field` for an item the model proposed, `not_a_list`, `item_not_a_dict` and `payload_not_a_dict` for a shape that was never a usable item. Every proposed item is either stored or dropped, so `proposed == stored + item drops` is the arithmetic that says whether anything was lost silently. The tool payload is not schema-checked anywhere, so a malformed shape is counted as a drop rather than raised — it used to abort the whole pass, discarding the other two kinds with it and suppressing the row, which read exactly like \"extraction never ran\". Without it, \"the model found nothing\" and \"the model found things and every one was rejected\" are indistinguishable from outside the database — which is why the failure above survived undetected and took a SQLite session on the tenant to find. A `proposed>0, stored=0` streak is the signal to watch.\n\nThe validator rejects a paraphrase, and the model paraphrases: on one install two of three real commitments were lost that way, the quote beginning \"SVN's engagement covers only …\" where the person had typed something else. So a `bad_quote` drop earns exactly one corrective call. The model is shown the rejected items and the quotes it gave, told to copy the span character-for-character (typos and casing included) or return empty arrays, and the tool is forced where the provider supports tool choice. Every retry item is validated first; a still-invalid one adds no second drop and is counted `still_invalid`. A valid item is then classified in order: its label matches a pending drop record → a recovery, stored and the record released; else its quote (terminal punctuation ignored) already supports a stored item of that kind → a re-send, ignored and counted `repeated`, so a model that re-sends everything cannot double-count `stored`; else a new proposal, stored and counted — a reworded label cannot be told from a different item, and crediting it would erase the very `bad_quote` census the row exists to show, so its original drop stands. Recovery is checked before re-send because two commitments can rest on one sentence. Malformed shapes at any level — a kind that is not a list, an item or payload that is not a dict, a response with no tool call — are counted `malformed`, so a retry that returned garbage does not read like one that obediently returned nothing. The row's `retry` block (`rejected`, `recovered`, `repeated`, `still_invalid`, `malformed`, `failure`) is always present, zeros when nothing was rejected; `rejected` is set from the complete drop list when the row is written, so neither a store failure before the retry nor a cancellation during it can zero it. The arithmetic above still holds after the retry. An exception on the retry is recorded as the retry's own `failure` and leaves the first pass's results untouched; the cost is one utility-model call, only on turns that dropped something. `memory_extraction` is a declared event type, so the audit page's filter can select it.\n\n### Session scoping\n\n`decisions` and `advice_given` rows carry a `session_id`, so per-thread channels (Discord, Telegram) can pull just-this-thread history without leaking cross-conversation context. A null `session_id` falls back to a global view.\n\n### Surfacing\n\n`openexecutive.memory.episodic.format_for_prompt` renders recent decisions and initiatives into a compact `<past_decisions>` block injected into the user turn — alongside `<retrieved_context>` and peer memory — never into a cached system block.\n\nThe chat route also injects a `<briefing>` block into the same user turn: a compact digest of the current open (unread) alerts, built by `openexecutive.briefing.context.format_open_alerts_for_prompt` (company-wide, `status=\"unread\"`, mirroring `/today`). This is what lets the Executive discuss a briefing item the principal clicked or named on `/today` (e.g. \"Gulf Coast Port Cyberattack\"). It is resolved in parallel with the other context fetches, omitted when there are no open alerts, and never placed in a cached system block.\n\nOn the Pulse page the Memory section shows the three lists as Decisions, Initiatives and Advice tabs, with a fourth **People** tab for peer memory (what Honcho has derived about each person, read-only, see the peer memory section). The header's Memories tile counts the three lists plus the peer notes, and says how many of the number are peer notes in its hint, since the People tab's badge counts people rather than notes.\n\n### System of record\n\nSQL is the system of record; the peer-memory service is a recall layer mirrored from it, not a replacement. When `store_decision` / `store_initiative` / `store_advice` insert a row whose `department` is non-empty and not `\"general\"`, the row is mirrored as a kind-tagged note into that department's peer via `append_department_note`. The mirror fires only after a successful INSERT, is fire-and-forget, and never rolls back the SQL row on peer-memory failure. `scheduled_actions` is never mirrored — it is a queue, not memory.\n\nThe episodic extractor still learns only from the principal's own words. Commitments and asks from everyone else on the roster are tracked as **open loops** (see Attunement) — `scheduled_actions` rows with `kind='open_loop'`, opened and closed by a separate quote-gated pass after each attributed turn. That pass depends on `chat_messages.sender_person_id`, which records who actually wrote each persisted user message. An open loop counts toward `list_awaiting_replies_by_person` only once it is due, and `list_scheduled_actions(exclude_internal=True)` filters `__internal__` rows in SQL so readers that want real sends are not starved by them. `mark_outbound_context_consumed` also resolves the Attunement outcome row for that DM as `replied` — a matched reply is the clearest sign proactive outreach landed — and `store_initiative` / `update_initiative` on an existing initiative mark its check-in nudges `acted`.",+ "markdown": "The Executive's durable memory is an episodic SQLite store at `./episodic_memory.db`, managed by `openexecutive.memory.episodic`. It holds four tables:\n\n- `decisions` — choices made, with `domain`, `summary`, `rationale`, `outcome`, and `tags`.\n- `initiatives` — tracked efforts with a `status` and `summary` (idempotent upserts).\n- `advice_given` — query/advice pairs per domain.\n- `scheduled_actions` — a dispatch queue, treated separately from recall memory.\n\n### What gets extracted, and when\n\n`episodic.extract_and_store` runs after a turn and asks a utility-fast model for decisions, initiatives and advice. Every candidate must carry a `user_commitment_quote` that appears verbatim in the principal's own message (`_is_valid_user_commitment`) — the model has repeatedly tried to log the Executive's *recommendations* as the user's commitments, and that quote is the hard gate against it.\n\nA turn reaches the extractor if `should_extract(user_message)` is true, which means only that the principal said something — there is deliberately **no length floor**. There used to be one, on the combined user+assistant length, and on a live tenant it selected almost exactly the wrong turns: 9 of 16 exchanges were blocked, and the 9 held every instruction the principal gave, while the 7 admitted were long analytical exchanges with no commitment in them. The extractor ran 13 times and stored nothing.\n\nMoving that floor to the user's side would relocate the bug, not fix it. The canonical executive decision is a long analysis answered with \"Approve option B.\" (17 chars) or \"Do B.\" (5), and any floor high enough to skip \"Done\" (4) also skips those — \"Do B.\" and \"Done\" differ by one character and mean opposite things. Length cannot separate a decision from an acknowledgement; the verbatim-quote check can, so `_is_valid_user_commitment` is the gate that decides. The price is one utility-fast call on turns that propose nothing.\n\nThat quote check is only meaningful when `user_message` holds the **principal's** words, and on a chat channel it does not — `Executive.chat()` is reached from Slack, Discord, Telegram, Google Chat and the email poller. A teammate's line would be written to `decisions` with no speaker attached, indistinguishable from the principal's own; an inbound email body is text the sender chose, so a self-quote is free. Removing the length floor is what makes this bite — short channel traffic used to fall under it incidentally — so `should_extract` also takes the turn's `origin_channel` and `person_id`. No channel means the web app, the CLI or the API, all of them the principal's own authenticated surfaces, where `person_id` is legitimately null in a single-user install. A turn that names a channel must resolve to a person marked `is_principal`, and an unresolvable speaker fails closed.\n\nEach pass writes a `memory_extraction` audit row — in a `finally`, so a pass that crashed is recorded too, with the exception type as its `failure` reason: how many items the model proposed, how many were stored, a `malformed` count so a pass where the model returned only garbage does not read as one that found nothing, and a `{kind, reason}` record per drop — `bad_quote` and `missing_field` for an item the model proposed, `not_a_list`, `item_not_a_dict` and `payload_not_a_dict` for a shape that was never a usable item. Every proposed item is either stored or dropped, so `proposed == stored + item drops` is the arithmetic that says whether anything was lost silently. The tool payload is not schema-checked anywhere, so a malformed shape is counted as a drop rather than raised — it used to abort the whole pass, discarding the other two kinds with it and suppressing the row, which read exactly like \"extraction never ran\". Without it, \"the model found nothing\" and \"the model found things and every one was rejected\" are indistinguishable from outside the database — which is why the failure above survived undetected and took a SQLite session on the tenant to find. A `proposed>0, stored=0` streak is the signal to watch.\n\nThe validator rejects a paraphrase, and the model paraphrases: on one install two of three real commitments were lost that way, the quote beginning \"SVN's engagement covers only …\" where the person had typed something else. So a `bad_quote` drop earns exactly one corrective call. The model is shown the rejected items and the quotes it gave, told to copy the span character-for-character (typos and casing included) or return empty arrays, and the tool is forced where the provider supports tool choice. Every retry item is validated first; a still-invalid one adds no second drop and is counted `still_invalid`. A valid item is then classified in order: its label matches a pending drop record → a recovery, stored and the record released; else its quote (terminal punctuation ignored) already supports a stored item of that kind → a re-send, ignored and counted `repeated`, so a model that re-sends everything cannot double-count `stored`; else a new proposal, stored and counted — a reworded label cannot be told from a different item, and crediting it would erase the very `bad_quote` census the row exists to show, so its original drop stands. Recovery is checked before re-send because two commitments can rest on one sentence. Malformed shapes at any level — a kind that is not a list, an item or payload that is not a dict, a response with no tool call — are counted `malformed`, so a retry that returned garbage does not read like one that obediently returned nothing. The row's `retry` block (`rejected`, `recovered`, `repeated`, `still_invalid`, `malformed`, `failure`) is always present, zeros when nothing was rejected; `rejected` is set from the complete drop list when the row is written, so neither a store failure before the retry nor a cancellation during it can zero it. The arithmetic above still holds after the retry. An exception on the retry is recorded as the retry's own `failure` and leaves the first pass's results untouched; the cost is one utility-model call, only on turns that dropped something. `memory_extraction` is a declared event type, so the audit page's filter can select it.\n\n### Session scoping\n\n`decisions` and `advice_given` rows carry a `session_id`, so per-thread channels (Discord, Telegram) can pull just-this-thread history without leaking cross-conversation context. A null `session_id` falls back to a global view.\n\n### Surfacing\n\n`openexecutive.memory.episodic.format_for_prompt` renders recent decisions and initiatives into a compact `<past_decisions>` block injected into the user turn — alongside `<retrieved_context>` and peer memory — never into a cached system block.\n\nThe chat route also injects a `<briefing>` block into the same user turn: a compact digest of the current open (unread) alerts, built by `openexecutive.briefing.context.format_open_alerts_for_prompt` (company-wide, `status=\"unread\"`, mirroring `/today`). This is what lets the Executive discuss a briefing item the principal clicked or named on `/today` (e.g. \"Gulf Coast Port Cyberattack\"). It is resolved in parallel with the other context fetches, omitted when there are no open alerts, and never placed in a cached system block.\n\nOn the Pulse page the Memory section shows the three lists as Decisions, Initiatives and Advice tabs, with a fourth **People** tab for peer memory (what Honcho has derived about each person, read-only, see the peer memory section). The header's Memories tile counts the three lists plus the peer notes, and says how many of the number are peer notes in its hint, since the People tab's badge counts people rather than notes.\n\n### System of record\n\nSQL is the system of record; the peer-memory service is a recall layer mirrored from it, not a replacement. When `store_decision` / `store_initiative` / `store_advice` insert a row whose `department` is non-empty and not `\"general\"`, the row is mirrored as a kind-tagged note into that department's peer via `append_department_note`. The mirror fires only after a successful INSERT, is fire-and-forget, and never rolls back the SQL row on peer-memory failure. `scheduled_actions` is never mirrored — it is a queue, not memory.\n\nThe episodic extractor still learns only from the principal's own words. Commitments and asks from everyone else on the roster are tracked as **open loops** (see Attunement) — `scheduled_actions` rows with `kind='open_loop'`, opened and closed by a separate quote-gated pass after each attributed turn. That pass depends on `chat_messages.sender_person_id`, which records who actually wrote each persisted user message. An open loop counts toward `list_awaiting_replies_by_person` only once it is due, and `list_scheduled_actions(exclude_internal=True)` filters `__internal__` rows in SQL so readers that want real sends are not starved by them. `mark_outbound_context_consumed` also resolves the Attunement outcome row for that DM as `replied` — a matched reply is the clearest sign proactive outreach landed — and a real change to an existing initiative (`store_initiative` / `update_initiative`, new status or summary) marks the updater's own check-in nudges `acted` — an update with no known updater, such as `PATCH /memories/initiatives/{id}`, credits nobody.","mermaid": "flowchart TD\n Store[\"store_decision / store_initiative / store_advice\"]\n DB[\"episodic_memory.db<br/>decisions / initiatives<br/>advice_given / scheduled_actions\"]\n Fmt[\"format_for_prompt\"]\n Turn[\"User turn<br/>past_decisions block\"]\n Mirror[\"append_department_note\"]\n Peer[\"Department peer<br/>(Honcho)\"]\n Store --> DB\n DB --> Fmt\n Fmt --> Turn\n Store -->|\"dept set & not general\"| Mirror\n Mirror -->|\"fire-and-forget\"| Peer\n class Store entry\n class DB storage\n class Fmt compute\n class Turn hot\n class Peer external\n","generated_at": "2026-09-22T23:17:20.508677+00:00"}diff --git a/packages/core/openexecutive/architecture/prebuilt/today.json b/packages/core/openexecutive/architecture/prebuilt/today.jsonindex 60750bad..db884f26 100644--- a/packages/core/openexecutive/architecture/prebuilt/today.json+++ b/packages/core/openexecutive/architecture/prebuilt/today.json@@ -1,7 +1,7 @@{"section_id": "today","title": "Today / Morning Brief",- "markdown": "`openexecutive.api.routes.today` serves the morning brief — a one-screen, read-only view of what is happening across the org. It is the default landing surface (the Next.js root renders `<Briefing>`).\n\n`GET /today` returns `TodayResponse` assembled by `_build_today()`, which is synchronous and caller-agnostic:\n\n- **`departments`** — per-department goal health, rolling up each department's goal counts (`total`, `at_risk`, `off_track`) plus its awaiting-workflow count, and `attention_goals`: the actual off-track/at-risk goals (worst first, capped at 3) with `key_result`, `current`, `target`, and `status`, so the briefing's Department card shows *which* goal is off and how far without a click. Empty for healthy/inactive departments.\n- **`people`** — an attention-ranked roster. Each person carries `awaiting_action` count, soonest SLA, a `status` (`on_leave` / `needs_reply` / `awaiting` / `clear`), reachability, `overdue`, a server `priority` sort key, and a cached one-line `insight`. Sorted by `(-priority, full_name)`.\n- **`proposals`** — the *live* unread alerts (workflow approvals, triage-classified inbound, Executive signals, flagged artifacts, and gated calendar bookings): unread, inside their category TTL, not snoozed — see *Alert lifecycle* below. Each carries `score`, `category` (`action` vs `monitoring`), `surfaced_reason` from `openexecutive.briefing.ranking`, the lifecycle fields (`occurrence_count`, `last_seen_at`, `last_reviewed_at`, `review_verdict`, `review_note`, `recommended_move`, `why_now`, `due_at`, `superseded_count`, `suggested_workflow`), and `decision_instance_id` (set only when the proposal is backed by a decision-ledger row — a calendar booking awaiting approval). The UI splits them into 'mine' vs 'across the team' using `caller_person_id`. For decision-backed proposals the card's Approve/Reject call the `/decisions` endpoints (which book or cancel the event server-side and clear the alert) instead of the ack-and-hand-off-to-chat flow — so meeting bookings are reviewed in the briefing itself rather than on a separate page.\n- **`narrative`** — a per-viewer Executive-voice header synthesized by `synthesize_briefing_narrative`; the principal gets the whole-company scope, teammates a role-scoped one. In the web UI each bullet of this narrative is a click target: clicking one hands off to chat (the same `onContinue` path as the proposal cards) seeded to discuss that item. The Executive recognizes it because every chat turn now carries a `<briefing>` digest of open alerts (see Memory). That digest (`briefing.context.format_open_alerts_for_prompt`) is capped at 30 items; when the board is longer the header says so explicitly and tells the Executive to point at this page for the rest — it previously presented the capped list as the complete board, so the Executive described a slice as everything that was open (#136). Chat adapters get the digest too, but Slack gates it to the principal's DMs: the board is company-wide and must not be pulled into a shared channel. The `[alert_id]` at the start of each line is also what `ack_alert` trusts, because an id quoted inside an alert's own body came from inbound mail or chat and is attacker-controlled. This page's `[Discuss mode — alert_id=N]` handoff primer is a pointer to which item is under discussion, not authority on its own: the server accepts it only if that id is on the live board too. Two things enforce that. Every field the digest interpolates — headline, body, suggested action, tags, review note — is collapsed to a single line, since a newline in any of them would forge a whole extra `[N]` line and with it a fabricated instruction to clear someone else's alert. And the server records the live board it derived, so `ack_alert` refuses any id outside it — on **every** session, not just the chat adapters. The recorded set is the whole live board, not just the rows the digest printed, so a card past the render cap stays ackable. The control stops invented, closed, snoozed and expired ids; it does not stop the model being argued into acking the wrong *live* card. That check used to run only when `origin_channel` was set, which the browser never sets, so the one surface where the principal actually reads their board had no check at all and the model could ack any id, including one quoted out of an alert body by the Discuss handoff. Rendering the block and recording its ids now happen together in `briefing.context.render_and_trust`, which both the web chat route and the channel adapters call: render without recording and the tool refuses everything, record without rendering and the model gets reach it was never shown. A turn that was shown nothing trusts nothing. Recording it is only half the wiring: the tool reads the board off the turn's session through a ContextVar, and the chat route binds that session for the whole SSE body (`set_session`, next to `set_turn`). Bound from inside the Executive's own generator instead, it survives exactly one stream step — `asyncio.wait_for` runs each step in a fresh Task with a copy of the context — and the tool-call loop, which runs later, sees nothing. That shipped, and every web ack was refused on cards that were open the whole time. The digest also carries a short **already handled** tail — recently acked / dismissed / resolved rows, named but deliberately NOT trusted for acking — because a card cleared on the page minutes ago is otherwise simply absent from chat: asked to \"record that as fixed\", the Executive could not tell a settled item from one it had never heard of, and sent the principal back to dismiss a card that was already gone. That tail renders even when nothing is open, which is exactly when it matters. Note it is a different window from the `handled_overnight` rail above: that one runs since the last delivered morning brief, while the chat tail looks back 14 days (matching the action-alert TTL, so it still covers an item cleared late in its life), so chat can name a settled item the rail no longer shows. The narrative is held to what is **live**, and to what it is actually for. The `alert_raised` source is dropped from the activity it reasons over (`_build_activity(..., include_alert_raised=False)`): a closed alert reads as work the principal already settled, and a *live* one is worse than redundant — `lifecycle.is_live` is the very predicate behind `list_live_alerts`, so every live raise is already a proposal card below the header, which the prompt forbids re-listing. The `/today/activity` rail keeps the whole source, because a raise really happened. The activity block is only labelled \"since last brief\" when the caller bounded it with `since` (the standalone briefs do; the header does not), since calling an unbounded history rail a delta made the header present weeks-old rows as overnight news. When the viewer's slice holds nothing that wants a decision — no action proposal, no at-risk/off-track department, nobody awaiting — the regen skips the model call entirely and writes the fixed quiet line (`Quiet right now — nothing pressing.`, or `… nothing needs you.` for a teammate). **The cache key is a hash of the rendered context itself** (`today._narrative_context` builds it once and both the hot path and the background task key off that one string, which is also handed to the model verbatim). That makes the key a function of the model's input: everything the prompt renders is covered, and nothing it omits can trigger a regeneration. Keying on hand-picked fields broke one half or the other each time — headlines alone left the rendered activity block uncovered, while the proposals' review fields are never rendered by this header yet are rewritten with fresh prose by every `alerts.review` pass, so they regenerated each viewer's narrative several times a day to re-synthesize identical input. A quiet board keys off a fixed sentinel instead, so a moving rail cannot re-key an entry whose text is constant. Together: on a fully dismissed board every other input was empty, the rail became the only context, and the model synthesized a confident header out of closed items.\n- **`in_flight`** / **`awaiting`** — upcoming Executive commitments and people we are waiting on.\n- **`handled_overnight`** — the autonomous moves the Executive *completed* since the last delivered morning brief: the alert review's (routed, nudged, escalated, drafted, merged, closed) plus the research watch policy's (`watching` — a watch added on its own because it was grounded in company data; `stopped_watching` — a research watch auto-disabled as noisy or dead; no alert id, re-enable from `/watchlist`). A `changed` verdict (the review rewrote an open alert's headline / body / severity) is deliberately **not** here: the alert is still open in \"Needs you\" and its card carries the note, so the brief reports it under \"what changed\" (a REWRITTEN block) rather than as done. Each row is structured, not just a sentence: `kind`, the audit `summary` (nudge bookkeeping marker stripped), `at`, `alert_id`, `event_type` (for a pre-filtered `/audit` deep link), `headline` (the alert's headline at move time; a watch's slug), `target` (person name for routed / nudged, survivor headline for merged, new severity for escalated, draft title, workflow name), `detail` (the cited evidence or the watch policy's reason), `outcome` (`resolved` | `dismissed` for a close, `proposed` for a route that went through the authority gate), `evidence_ref` (S1 / R2 / A3), `superseded_by_alert_id`, and `status` — the alert's lifecycle state **now** (`open` = live in the queue per `lifecycle.is_live` | `resolved` | `dismissed` | `expired` | `merged` | `acked` | `inactive` for snoozed / past-TTL rows), looked up per row so a close the principal already undid renders as reopened instead of offering a second Undo, and a \"still open\" jump link only appears when there is a card to land on. The morning brief also carries a one-line count of research watch suggestions waiting on `/watchlist`.\n\nThe route resolves the caller from `x-caller-email`, then attaches the viewer-scoped narrative in a `BackgroundTask` so the request never blocks on an LLM call. `GET /today/activity` returns the recent self-initiated action rail — merged from fired scheduled actions (DMs, follow-ups, nudges, cadences), logged decisions, saved advice, completed workflow runs (briefings/check-ins/research), kicked-off initiatives, resolved gated decisions, and raised alerts, so it reflects all of the Executive's activity rather than just dispatched messages. The Pulse page (`/memories`) polls it (limit 100) every ~20s so new events stream into the 'Recent activity' card, which scrolls internally at a fixed height instead of growing the page. The `morning_brief` workflow calls `_build_today()` directly to build the standalone DM (via a different, enumerated prompt). `GET /morning-brief` is a deprecated alias.\n\n## Alert lifecycle & the Executive review\n\nAlerts used to be write-once: raised, then never looked at again, so the \"Needs you\" queue grew without bound and the briefs re-listed it daily. Three things now keep it live:\n\n- **Time-to-live** (`openexecutive.alerts.lifecycle`). Action items expire after `ALERT_TTL_DAYS_ACTION` (14 d), unrouted low/medium monitoring signals after `ALERT_TTL_DAYS_MONITORING` (3 d). Every surface reads `list_live_alerts` (the same predicate the scheduler's 15-minute sweep persists as status `expired`), so `/today` is right even before the sweep runs. Artifacts and decision-backed alerts are exempt. `POST /alerts/{id}/reopen` is the Undo.\n- **Coalescing** (`alerts.pipeline` + `store.coalesce_alert`). A repeat of an open alert with the same `(source, dedup_key)` updates that row — `occurrence_count`, `last_seen_at`, severity max — instead of stacking a second card, and only re-pings when severity rose to high/urgent. Monitoring alerts carry a stable `watch:<slug>` key, so one watch means one card.\n- **The review** (`openexecutive.alerts.review`, heartbeat `alert_review_scan`, every 6 h and right before the morning brief). For each open alert the Executive sees what changed since it was raised — newer signals from the same watch, related alerts, activity since, the roster with SLAs, department authority — and returns a verdict (relevant / changed / resolved / stale) plus a recommended move. Deterministic policy then acts: **route** (assign + DM the owner; `propose_via_alert` for propose-only departments), **nudge**, **escalate** (severity + `due_at` + DM the principal only), **draft** (`draft_artifact`), **suggest a workflow** (a link, never a run), **merge** (`superseded_by_alert_id`), or **resolve** — only on high confidence citing a server-minted evidence ref (a newer signal, a related alert, an activity item shown for that alert); free text never closes a card, and anything weaker is annotated `likely_stale`, demoted 30 ranking points, and left for one click. Everything that came from outside is rendered as inert data inside the review prompt, so an injected email body cannot steer the batch. Board / comp / legal matters only ever go to a scope-holder or the principal and keep their text. Route and escalate are idempotent across passes, every DM carries an \"[Alert review] Re: …\" header, outbound moves are capped per pass, passes are single-flight, `ALERT_REVIEW_ENABLED=false` stops every caller, every move is audited with its evidence and prior state, and a distinct `resolved` status keeps Executive closes separate from `ack` (user approved).\n\nOn the page, cards read as decisions: the one-line \"what changed since you last looked\" (`review_note`) leads, the recommended move is the primary control (Nudge <owner> → chat; Run <workflow> → `/jobs/<name>`), with chips for age, seen ×N, why-now / due, folded-in and draft-ready, a \"Reviewed <ago>\" footer, and an amber Likely-stale treatment with one-click Dismiss. \"Needs you\" shows *Start here* + 8 cards + \"Show N more\", a \"Dismiss N older than 7 days\" footer (explicit ids to `POST /alerts/bulk-ack` — never a server-side age sweep, which would hit teammates' routed items), and \"Re-check relevance\" (`POST /alerts/review`). The handled rail (anchor of the \"Executive handled N overnight\" pill) is deliberately one sentence by default: a first-person heading built from counts only — \"Since your last brief: N off your plate (closes still standing, and merges whose survivor is not itself listed; a merge into a listed survivor counts on that survivor's row), N in others' hands (routed / nudged), N waiting on you (escalated)\", plus \"N drafts ready\", \"N workflows suggested\", \"N watch changes\", \"N other moves\" (a kind the UI does not know) and \"N back on your plate\" (a close that is open again) when present — with the rows behind a \"details\" disclosure, and nothing rendered at all when the grouped rows are empty. The pure logic (grouping, headline, links) lives in `packages/ui/src/lib/handled.ts` and is covered by `npm test`. Expanded, it shows one first-person row per alert (\"Resolved *X* — evidence\", \"Dismissed *X* as stale — evidence\", \"Handed *X* to Dana Kim\" / \"Proposed *X* to Dana Kim (awaiting their approval)\", \"Chased Dana Kim on *X*\", \"Raised *X* to high\", \"Drafted *T* from *X*\", \"Folded *X* into *Y*\", \"Started watching *slug*\"), escalations first; rows sharing an alert collapse to the newest move with the others as an \"also …\" trailer — a close always keeps the visible slot (it carries Undo), otherwise an escalation beats routed / nudged / drafted; a merge whose survivor is listed becomes \"N duplicates folded in\" on the survivor. Every row links its `evidence_ref` (or \"evidence\") to `/audit?event_type=…&q=…` (the audit page pre-fills those filters from the query string), a still-open row jumps to its card (`#alert-<id>`), drafted rows link `/artifacts`, watch rows `/watchlist`. Undo is offered only while the close still stands (`status` not `open`); a reverted close shows \"Reopened\". Dismissing a watch-sourced alert lowers that watch's `trust_score` (which discounts ranking and is shown to the review as evidence); the ack body may carry `mute_topic`. Acknowledging or resolving an alert — including the review closing it itself — marks the review's DMs about it `acted` in the Attunement outcome ledger, for the person it is routed to and the principal only; dismissing it or finding it stale voids them (counted neither way). Review DMs are tagged `alert_review` with `alert:<id>`.\n\n## Multi-client practice section\n\nIn multi-client practice mode (2+ client slots — see the Client Companies section), the response gains an additive `practice_clients` list: rollup cards for the **parked** clients (overdue follow-ups, awaiting replies, unread alerts, onboarding due soon, renewal countdowns), each stamped with the save point its data reflects. Single-company installs always receive an empty list and the UI renders nothing.",+ "markdown": "`openexecutive.api.routes.today` serves the morning brief — a one-screen, read-only view of what is happening across the org. It is the default landing surface (the Next.js root renders `<Briefing>`).\n\n`GET /today` returns `TodayResponse` assembled by `_build_today()`, which is synchronous and caller-agnostic:\n\n- **`departments`** — per-department goal health, rolling up each department's goal counts (`total`, `at_risk`, `off_track`) plus its awaiting-workflow count, and `attention_goals`: the actual off-track/at-risk goals (worst first, capped at 3) with `key_result`, `current`, `target`, and `status`, so the briefing's Department card shows *which* goal is off and how far without a click. Empty for healthy/inactive departments.\n- **`people`** — an attention-ranked roster. Each person carries `awaiting_action` count, soonest SLA, a `status` (`on_leave` / `needs_reply` / `awaiting` / `clear`), reachability, `overdue`, a server `priority` sort key, and a cached one-line `insight`. Sorted by `(-priority, full_name)`.\n- **`proposals`** — the *live* unread alerts (workflow approvals, triage-classified inbound, Executive signals, flagged artifacts, and gated calendar bookings): unread, inside their category TTL, not snoozed — see *Alert lifecycle* below. Each carries `score`, `category` (`action` vs `monitoring`), `surfaced_reason` from `openexecutive.briefing.ranking`, the lifecycle fields (`occurrence_count`, `last_seen_at`, `last_reviewed_at`, `review_verdict`, `review_note`, `recommended_move`, `why_now`, `due_at`, `superseded_count`, `suggested_workflow`), and `decision_instance_id` (set only when the proposal is backed by a decision-ledger row — a calendar booking awaiting approval). The UI splits them into 'mine' vs 'across the team' using `caller_person_id`. For decision-backed proposals the card's Approve/Reject call the `/decisions` endpoints (which book or cancel the event server-side and clear the alert) instead of the ack-and-hand-off-to-chat flow — so meeting bookings are reviewed in the briefing itself rather than on a separate page.\n- **`narrative`** — a per-viewer Executive-voice header synthesized by `synthesize_briefing_narrative`; the principal gets the whole-company scope, teammates a role-scoped one. In the web UI each bullet of this narrative is a click target: clicking one hands off to chat (the same `onContinue` path as the proposal cards) seeded to discuss that item. The Executive recognizes it because every chat turn now carries a `<briefing>` digest of open alerts (see Memory). That digest (`briefing.context.format_open_alerts_for_prompt`) is capped at 30 items; when the board is longer the header says so explicitly and tells the Executive to point at this page for the rest — it previously presented the capped list as the complete board, so the Executive described a slice as everything that was open (#136). Chat adapters get the digest too, but Slack gates it to the principal's DMs: the board is company-wide and must not be pulled into a shared channel. The `[alert_id]` at the start of each line is also what `ack_alert` trusts, because an id quoted inside an alert's own body came from inbound mail or chat and is attacker-controlled. This page's `[Discuss mode — alert_id=N]` handoff primer is a pointer to which item is under discussion, not authority on its own: the server accepts it only if that id is on the live board too. Two things enforce that. Every field the digest interpolates — headline, body, suggested action, tags, review note — is collapsed to a single line, since a newline in any of them would forge a whole extra `[N]` line and with it a fabricated instruction to clear someone else's alert. And the server records the live board it derived, so `ack_alert` refuses any id outside it — on **every** session, not just the chat adapters. The recorded set is the whole live board, not just the rows the digest printed, so a card past the render cap stays ackable. The control stops invented, closed, snoozed and expired ids; it does not stop the model being argued into acking the wrong *live* card. That check used to run only when `origin_channel` was set, which the browser never sets, so the one surface where the principal actually reads their board had no check at all and the model could ack any id, including one quoted out of an alert body by the Discuss handoff. Rendering the block and recording its ids now happen together in `briefing.context.render_and_trust`, which both the web chat route and the channel adapters call: render without recording and the tool refuses everything, record without rendering and the model gets reach it was never shown. A turn that was shown nothing trusts nothing. Recording it is only half the wiring: the tool reads the board off the turn's session through a ContextVar, and the chat route binds that session for the whole SSE body (`set_session`, next to `set_turn`). Bound from inside the Executive's own generator instead, it survives exactly one stream step — `asyncio.wait_for` runs each step in a fresh Task with a copy of the context — and the tool-call loop, which runs later, sees nothing. That shipped, and every web ack was refused on cards that were open the whole time. The digest also carries a short **already handled** tail — recently acked / dismissed / resolved rows, named but deliberately NOT trusted for acking — because a card cleared on the page minutes ago is otherwise simply absent from chat: asked to \"record that as fixed\", the Executive could not tell a settled item from one it had never heard of, and sent the principal back to dismiss a card that was already gone. That tail renders even when nothing is open, which is exactly when it matters. Note it is a different window from the `handled_overnight` rail above: that one runs since the last delivered morning brief, while the chat tail looks back 14 days (matching the action-alert TTL, so it still covers an item cleared late in its life), so chat can name a settled item the rail no longer shows. The narrative is held to what is **live**, and to what it is actually for. The `alert_raised` source is dropped from the activity it reasons over (`_build_activity(..., include_alert_raised=False)`): a closed alert reads as work the principal already settled, and a *live* one is worse than redundant — `lifecycle.is_live` is the very predicate behind `list_live_alerts`, so every live raise is already a proposal card below the header, which the prompt forbids re-listing. The `/today/activity` rail keeps the whole source, because a raise really happened. The activity block is only labelled \"since last brief\" when the caller bounded it with `since` (the standalone briefs do; the header does not), since calling an unbounded history rail a delta made the header present weeks-old rows as overnight news. When the viewer's slice holds nothing that wants a decision — no action proposal, no at-risk/off-track department, nobody awaiting — the regen skips the model call entirely and writes the fixed quiet line (`Quiet right now — nothing pressing.`, or `… nothing needs you.` for a teammate). **The cache key is a hash of the rendered context itself** (`today._narrative_context` builds it once and both the hot path and the background task key off that one string, which is also handed to the model verbatim). That makes the key a function of the model's input: everything the prompt renders is covered, and nothing it omits can trigger a regeneration. Keying on hand-picked fields broke one half or the other each time — headlines alone left the rendered activity block uncovered, while the proposals' review fields are never rendered by this header yet are rewritten with fresh prose by every `alerts.review` pass, so they regenerated each viewer's narrative several times a day to re-synthesize identical input. A quiet board keys off a fixed sentinel instead, so a moving rail cannot re-key an entry whose text is constant. Together: on a fully dismissed board every other input was empty, the rail became the only context, and the model synthesized a confident header out of closed items.\n- **`in_flight`** / **`awaiting`** — upcoming Executive commitments and people we are waiting on.\n- **`handled_overnight`** — the autonomous moves the Executive *completed* since the last delivered morning brief: the alert review's (routed, nudged, escalated, drafted, merged, closed) plus the research watch policy's (`watching` — a watch added on its own because it was grounded in company data; `stopped_watching` — a research watch auto-disabled as noisy or dead; no alert id, re-enable from `/watchlist`). A `changed` verdict (the review rewrote an open alert's headline / body / severity) is deliberately **not** here: the alert is still open in \"Needs you\" and its card carries the note, so the brief reports it under \"what changed\" (a REWRITTEN block) rather than as done. Each row is structured, not just a sentence: `kind`, the audit `summary` (nudge bookkeeping marker stripped), `at`, `alert_id`, `event_type` (for a pre-filtered `/audit` deep link), `headline` (the alert's headline at move time; a watch's slug), `target` (person name for routed / nudged, survivor headline for merged, new severity for escalated, draft title, workflow name), `detail` (the cited evidence or the watch policy's reason), `outcome` (`resolved` | `dismissed` for a close, `proposed` for a route that went through the authority gate), `evidence_ref` (S1 / R2 / A3), `superseded_by_alert_id`, and `status` — the alert's lifecycle state **now** (`open` = live in the queue per `lifecycle.is_live` | `resolved` | `dismissed` | `expired` | `merged` | `acked` | `inactive` for snoozed / past-TTL rows), looked up per row so a close the principal already undid renders as reopened instead of offering a second Undo, and a \"still open\" jump link only appears when there is a card to land on. The morning brief also carries a one-line count of research watch suggestions waiting on `/watchlist`.\n\nThe route resolves the caller from `x-caller-email`, then attaches the viewer-scoped narrative in a `BackgroundTask` so the request never blocks on an LLM call. `GET /today/activity` returns the recent self-initiated action rail — merged from fired scheduled actions (DMs, follow-ups, nudges, cadences), logged decisions, saved advice, completed workflow runs (briefings/check-ins/research), kicked-off initiatives, resolved gated decisions, and raised alerts, so it reflects all of the Executive's activity rather than just dispatched messages. The Pulse page (`/memories`) polls it (limit 100) every ~20s so new events stream into the 'Recent activity' card, which scrolls internally at a fixed height instead of growing the page. The `morning_brief` workflow calls `_build_today()` directly to build the standalone DM (via a different, enumerated prompt). `GET /morning-brief` is a deprecated alias.\n\n## Alert lifecycle & the Executive review\n\nAlerts used to be write-once: raised, then never looked at again, so the \"Needs you\" queue grew without bound and the briefs re-listed it daily. Three things now keep it live:\n\n- **Time-to-live** (`openexecutive.alerts.lifecycle`). Action items expire after `ALERT_TTL_DAYS_ACTION` (14 d), unrouted low/medium monitoring signals after `ALERT_TTL_DAYS_MONITORING` (3 d). Every surface reads `list_live_alerts` (the same predicate the scheduler's 15-minute sweep persists as status `expired`), so `/today` is right even before the sweep runs. Artifacts and decision-backed alerts are exempt. `POST /alerts/{id}/reopen` is the Undo.\n- **Coalescing** (`alerts.pipeline` + `store.coalesce_alert`). A repeat of an open alert with the same `(source, dedup_key)` updates that row — `occurrence_count`, `last_seen_at`, severity max — instead of stacking a second card, and only re-pings when severity rose to high/urgent. Monitoring alerts carry a stable `watch:<slug>` key, so one watch means one card.\n- **The review** (`openexecutive.alerts.review`, heartbeat `alert_review_scan`, every 6 h and right before the morning brief). For each open alert the Executive sees what changed since it was raised — newer signals from the same watch, related alerts, activity since, the roster with SLAs, department authority — and returns a verdict (relevant / changed / resolved / stale) plus a recommended move. Deterministic policy then acts: **route** (assign + DM the owner; `propose_via_alert` for propose-only departments), **nudge**, **escalate** (severity + `due_at` + DM the principal only), **draft** (`draft_artifact`), **suggest a workflow** (a link, never a run), **merge** (`superseded_by_alert_id`), or **resolve** — only on high confidence citing a server-minted evidence ref (a newer signal, a related alert, an activity item shown for that alert); free text never closes a card, and anything weaker is annotated `likely_stale`, demoted 30 ranking points, and left for one click. Everything that came from outside is rendered as inert data inside the review prompt, so an injected email body cannot steer the batch. Board / comp / legal matters only ever go to a scope-holder or the principal and keep their text. Route and escalate are idempotent across passes, every DM carries an \"[Alert review] Re: …\" header, outbound moves are capped per pass, passes are single-flight, `ALERT_REVIEW_ENABLED=false` stops every caller, every move is audited with its evidence and prior state, and a distinct `resolved` status keeps Executive closes separate from `ack` (user approved).\n\nOn the page, cards read as decisions: the one-line \"what changed since you last looked\" (`review_note`) leads, the recommended move is the primary control (Nudge <owner> → chat; Run <workflow> → `/jobs/<name>`), with chips for age, seen ×N, why-now / due, folded-in and draft-ready, a \"Reviewed <ago>\" footer, and an amber Likely-stale treatment with one-click Dismiss. \"Needs you\" shows *Start here* + 8 cards + \"Show N more\", a \"Dismiss N older than 7 days\" footer (explicit ids to `POST /alerts/bulk-ack` — never a server-side age sweep, which would hit teammates' routed items), and \"Re-check relevance\" (`POST /alerts/review`). The handled rail (anchor of the \"Executive handled N overnight\" pill) is deliberately one sentence by default: a first-person heading built from counts only — \"Since your last brief: N off your plate (closes still standing, and merges whose survivor is not itself listed; a merge into a listed survivor counts on that survivor's row), N in others' hands (routed / nudged), N waiting on you (escalated)\", plus \"N drafts ready\", \"N workflows suggested\", \"N watch changes\", \"N other moves\" (a kind the UI does not know) and \"N back on your plate\" (a close that is open again) when present — with the rows behind a \"details\" disclosure, and nothing rendered at all when the grouped rows are empty. The pure logic (grouping, headline, links) lives in `packages/ui/src/lib/handled.ts` and is covered by `npm test`. Expanded, it shows one first-person row per alert (\"Resolved *X* — evidence\", \"Dismissed *X* as stale — evidence\", \"Handed *X* to Dana Kim\" / \"Proposed *X* to Dana Kim (awaiting their approval)\", \"Chased Dana Kim on *X*\", \"Raised *X* to high\", \"Drafted *T* from *X*\", \"Folded *X* into *Y*\", \"Started watching *slug*\"), escalations first; rows sharing an alert collapse to the newest move with the others as an \"also …\" trailer — a close always keeps the visible slot (it carries Undo), otherwise an escalation beats routed / nudged / drafted; a merge whose survivor is listed becomes \"N duplicates folded in\" on the survivor. Every row links its `evidence_ref` (or \"evidence\") to `/audit?event_type=…&q=…` (the audit page pre-fills those filters from the query string), a still-open row jumps to its card (`#alert-<id>`), drafted rows link `/artifacts`, watch rows `/watchlist`. Undo is offered only while the close still stands (`status` not `open`); a reverted close shows \"Reopened\". Dismissing a watch-sourced alert lowers that watch's `trust_score` (which discounts ranking and is shown to the review as evidence); the ack body may carry `mute_topic`. Acknowledging or resolving an alert — including the review closing it itself — marks the review's DMs about it `acted` in the Attunement outcome ledger, for the person it is routed to and the principal only; dismissing it, finding it stale or letting it expire voids them (counted neither way). Review DMs are tagged `alert_review` with `alert:<id>`.\n\n## Multi-client practice section\n\nIn multi-client practice mode (2+ client slots — see the Client Companies section), the response gains an additive `practice_clients` list: rollup cards for the **parked** clients (overdue follow-ups, awaiting replies, unread alerts, onboarding due soon, renewal countdowns), each stamped with the save point its data reflects. Single-company installs always receive an empty list and the UI renders nothing.","mermaid": "flowchart TD\n REQ[\"GET /today\"]\n BUILD[\"_build_today()\"]\n DEPTS[\"departments<br/>(per-dept goal health)\"]\n ROSTER[\"people<br/>(attention-ranked roster)\"]\n PROPS[\"proposals<br/>(unread alerts, routed)\"]\n INFLIGHT[\"in_flight<br/>(pending follow-ups / nudges)\"]\n AWAIT[\"awaiting<br/>(replies we await)\"]\n NARR[\"viewer-scoped narrative (BackgroundTask)\"]\n MB[\"morning_brief workflow\"]\n REQ --> BUILD\n BUILD --> DEPTS\n BUILD --> ROSTER\n BUILD --> PROPS\n BUILD --> INFLIGHT\n BUILD --> AWAIT\n REQ -->|\"resolve caller, attach\"| NARR\n MB -->|\"calls directly for standalone DM\"| BUILD\n class REQ entry\n class BUILD compute\n class DEPTS storage\n class ROSTER storage\n class PROPS storage\n class INFLIGHT storage\n class AWAIT storage\n class NARR compute\n class MB compute","generated_at": "2026-09-22T23:17:20.508677+00:00"}diff --git a/packages/core/openexecutive/attunement/__init__.py b/packages/core/openexecutive/attunement/__init__.pyindex 13c21135..70d5c000 100644--- a/packages/core/openexecutive/attunement/__init__.py+++ b/packages/core/openexecutive/attunement/__init__.py@@ -9,6 +9,6 @@ here ever reads an outsider's words as someone on the roster.on the roster become open loops the nudge engine chases once due, and closewhen the owner says they're done.- :mod:`openexecutive.attunement.outcomes` — every proactive DM to a person is- resolved replied / acted / dismissed / ignored, and the rates steer which+ resolved replied / acted / void / ignored, and the rates steer whichoutreach the nudge engine and the morning standup send to whom."""diff --git a/packages/core/openexecutive/attunement/open_loops.py b/packages/core/openexecutive/attunement/open_loops.pyindex 587ae38f..51d01309 100644--- a/packages/core/openexecutive/attunement/open_loops.py+++ b/packages/core/openexecutive/attunement/open_loops.py@@ -332,13 +332,13 @@ def close_open_loop(# Only the owner's own "it's done" credits the chases. The principal# tidying a loop away ("done" is the default in the UI and the tool) says# nothing about whether the owner answered.- owner_did_it = reason == "reported_done" or (+ owner_did_it = (reason in _DONE_REASONS and closed_by_person_id is not Noneand closed_by_person_id == owner_id)if closed and owner_did_it:- # The chases for this loop landed: the owner (or the principal) says- # it's done. Other closures (expiry, archive, cancelled) prove nothing.+ # The chases for this loop landed: its owner says it's done. Other+ # closures (expiry, archive, cancelled, a principal tidy-up) prove nothing.from openexecutive.attunement.outcomes import OUTCOME_ACTED, resolve_by_refresolve_by_ref(f"nudge:commitment:{loop_id}", OUTCOME_ACTED, db_path=db_path)diff --git a/packages/core/openexecutive/attunement/outcomes.py b/packages/core/openexecutive/attunement/outcomes.pyindex e1598756..62941a20 100644--- a/packages/core/openexecutive/attunement/outcomes.py+++ b/packages/core/openexecutive/attunement/outcomes.py@@ -14,7 +14,8 @@ rostered person and resolves it deterministically, with no model call:- **void** — the alert it was about was dismissed or found stale: the DMneither landed nor was ignored, so it counts toward neither;- **ignored** — nothing of the above within ``ATTUNEMENT_IGNORE_AFTER_HOURS``- (swept at the start of each nudge scan and whenever rates are read).+ (swept at the start of each nudge scan and whenever rates are read). A+ later acted / void verdict overrides it.Recording happens at the one place every proactive DM passes through —``orchestrator.schedule_tools._record_outbound_context`` — but only while a@@ -156,8 +157,18 @@ def _is_principal(person_id: int) -> bool:return False-def _resolve(where: str, params: tuple[Any, ...], outcome: str, db_path: Path | None) -> int:- """Set ``outcome`` on still-open rows matching ``where``. Never raises."""+def _resolve(+ where: str,+ params: tuple[Any, ...],+ outcome: str,+ db_path: Path | None,+ *,+ override_ignored: bool = False,+) -> int:+ """Set ``outcome`` on still-open rows matching ``where`` — and, with+ ``override_ignored``, on rows already swept to ``ignored``: the thing a+ DM chased can get done (or be dismissed) days after the 72h sweep, and+ that later verdict is the truer one. Never raises."""try:from openexecutive.memory.episodic import _get_conn@@ -165,9 +176,13 @@ def _resolve(where: str, params: tuple[Any, ...], outcome: str, db_path: Path |if not resolved.exists():return 0with _get_conn(resolved) as conn:+ open_clause = (+ "(outcome IS NULL OR outcome = 'ignored')" if override_ignored+ else "outcome IS NULL"+ )cur = conn.execute("UPDATE proactive_outcomes SET outcome = ?, resolved_at = ? "- f"WHERE outcome IS NULL AND {where}",+ f"WHERE {open_clause} AND {where}",(outcome, datetime.now(UTC).isoformat(), *params),)return int(cur.rowcount)@@ -190,13 +205,18 @@ def resolve_by_ref(credits only the ones it now belongs to."""if not ref:return 0+ # A later "done" or "didn't matter" overrides an earlier timeout.+ override = outcome in (OUTCOME_ACTED, OUTCOME_VOID)if person_ids is None:- return _resolve("ref = ?", (ref,), outcome, db_path)+ return _resolve("ref = ?", (ref,), outcome, db_path, override_ignored=override)ids = sorted(person_ids)if not ids:return 0placeholders = ",".join("?" * len(ids))- return _resolve(f"ref = ? AND person_id IN ({placeholders})", (ref, *ids), outcome, db_path)+ return _resolve(+ f"ref = ? AND person_id IN ({placeholders})", (ref, *ids), outcome, db_path,+ override_ignored=override,+ )def resolve_by_outbound_context(@@ -213,9 +233,17 @@ def sweep_ignored(db_path: Path | None = None,) -> int:"""Mark outcomes still open after ``after_hours`` as ignored."""- from openexecutive.config import get_settings-- hours = after_hours if after_hours is not None else get_settings().attunement_ignore_after_hours+ if after_hours is not None:+ hours = after_hours+ else:+ try:+ from openexecutive.config import get_settings++ hours = get_settings().attunement_ignore_after_hours+ except Exception:+ # Runs on read paths too; a settings failure must not 500 a page.+ logger.warning("outcomes: sweep settings unavailable", exc_info=True)+ return 0if hours <= 0:return 0cutoff = ((now or datetime.now(UTC)) - timedelta(hours=hours)).isoformat()@@ -311,7 +339,9 @@ def muted_pairs(rows = conn.execute("SELECT person_id, source, outcome FROM proactive_outcomes ""WHERE created_at >= ? AND outcome IS NOT NULL AND outcome != 'void' "- "ORDER BY person_id, source, resolved_at DESC, id DESC",+ # By when the DM was SENT: an old send swept to "ignored"+ # after a newer one was answered must not bury that answer.+ "ORDER BY person_id, source, created_at DESC, id DESC",(since,),).fetchall()except Exception:diff --git a/packages/core/openexecutive/memory/episodic.py b/packages/core/openexecutive/memory/episodic.pyindex 6fbc7a75..bae3cf9c 100644--- a/packages/core/openexecutive/memory/episodic.py+++ b/packages/core/openexecutive/memory/episodic.py@@ -556,16 +556,21 @@ def store_initiative(department: str = "",person_id: int | None = None,db_path: Path = DB_PATH,+ updated_by_person_id: int | None = None,) -> None:now = datetime.now(UTC).isoformat()is_insert = Falseis_status_change = False+ is_real_update = Falsewith _get_conn(db_path) as conn:existing = conn.execute(- "SELECT id, status FROM initiatives WHERE title = ?", (title,)+ "SELECT id, status, summary FROM initiatives WHERE title = ?", (title,)).fetchone()if existing:is_status_change = existing["status"] != status+ is_real_update = is_status_change or (+ bool(summary) and summary != (existing["summary"] or "")+ )# Only overwrite an existing department when the caller actually# passed a non-empty value — preserves the original tag if the# update path is invoked without department context.@@ -585,8 +590,10 @@ def store_initiative("INSERT INTO initiatives (title, status, created_at, updated_at, summary, department) VALUES (?, ?, ?, ?, ?, ?)",(title, status, now, now, summary, department),)- if existing:- _resolve_initiative_outreach(int(existing["id"]), db_path)+ if existing and is_real_update:+ # Only a real change answers a check-in — a same-status re-mention+ # during routine extraction does not.+ _resolve_initiative_outreach(int(existing["id"]), updated_by_person_id, db_path)# Mirror only on a new initiative OR a real status transition.# Idempotent upserts (same title + same status) don't fire — that# would spam the dept peer with redundant notes on every routine@@ -812,6 +819,7 @@ def update_initiative(status: str | None = None,summary: str | None = None,db_path: Path = DB_PATH,+ updated_by_person_id: int | None = None,) -> bool:fields: list[tuple[str, str]] = []if title is not None:@@ -831,15 +839,38 @@ def update_initiative()updated = cursor.rowcount > 0if updated:- _resolve_initiative_outreach(initiative_id, db_path)+ _resolve_initiative_outreach(initiative_id, updated_by_person_id, db_path)return updated-def _resolve_initiative_outreach(initiative_id: int, db_path: Path | None) -> None:- """An initiative got an update, so the check-in nudges about it landed."""+def _principal_person_id() -> int | None:+ """The principal's roster id, or None when there is none. Never raises."""+ try:+ from openexecutive.people.store import find_principal_person++ principal = find_principal_person()+ except Exception:+ logger.debug("principal lookup failed", exc_info=True)+ return None+ return principal.id if principal is not None else None+++def _resolve_initiative_outreach(+ initiative_id: int, updated_by_person_id: int | None, db_path: Path | None+) -> None:+ """The person a check-in nudge went to updated the initiative, so it landed.++ Credit goes only to the updater's own pending check-ins. An update from+ someone else (the principal editing the card, an unauthenticated API call)+ says nothing about whether the department head answered."""+ if updated_by_person_id is None:+ returnfrom openexecutive.attunement.outcomes import OUTCOME_ACTED, resolve_by_ref- resolve_by_ref(f"nudge:initiative:{initiative_id}", OUTCOME_ACTED, db_path=db_path)+ resolve_by_ref(+ f"nudge:initiative:{initiative_id}", OUTCOME_ACTED,+ person_ids={updated_by_person_id}, db_path=db_path,+ )def update_advice(@@ -2169,11 +2200,14 @@ def _store_item(db_path=db_path,)elif spec is _INITIATIVES:+ # Extraction only runs on the principal's own words (should_extract),+ # so the principal is the one updating it.store_initiative(title=item["title"],status=item.get("status", "active"),summary=item["summary"],db_path=db_path,+ updated_by_person_id=_principal_person_id(),)else:store_advice(diff --git a/packages/core/openexecutive/orchestrator/mcp_gateway.py b/packages/core/openexecutive/orchestrator/mcp_gateway.pyindex e877ca63..1da3d2a1 100644--- a/packages/core/openexecutive/orchestrator/mcp_gateway.py+++ b/packages/core/openexecutive/orchestrator/mcp_gateway.py@@ -581,10 +581,12 @@ def _record_email_outbound_context(arguments: dict[str, Any]) -> None:from openexecutive.orchestrator.schedule_tools import (_record_outbound_context,+ _resolve_recipient_person_id,)self_addr = get_settings().exec_email_address.lower()seen: set[str] = set()+ primary_taken = Falsefor field in _OUTBOUND_CONTEXT_RECIPIENT_FIELDS:value = arguments.get(field)if not value:@@ -594,9 +596,13 @@ def _record_email_outbound_context(arguments: dict[str, Any]) -> None:norm = addr.strip().lower()if not norm or norm == self_addr or norm in seen:continue- # Only the first "to" address is who the email was addressed- # to; every recipient still gets reply linkage.- primary = field == "to" and not seen+ # Only the first rostered "to" address is who the email was+ # addressed to; every recipient still gets reply linkage.+ primary = (+ field == "to" and not primary_taken+ and _resolve_recipient_person_id("email", norm) is not None+ )+ primary_taken = primary_taken or primaryseen.add(norm)_record_outbound_context(channel="email",diff --git a/packages/core/openexecutive/workflows/resumer.py b/packages/core/openexecutive/workflows/resumer.pyindex 9931b096..96ae4d4c 100644--- a/packages/core/openexecutive/workflows/resumer.py+++ b/packages/core/openexecutive/workflows/resumer.py@@ -100,7 +100,11 @@ async def apply_resolution(from openexecutive.attunement.outcomes import OUTCOME_ACTED, resolve_by_ref# The ledger lives in the episodic store, not necessarily at `db_path`.- resolve_by_ref(f"nudge:stalled:{run_id}", OUTCOME_ACTED)+ # Credited to whoever resolved it, like alerts — not to everyone nudged.+ resolve_by_ref(+ f"nudge:stalled:{run_id}", OUTCOME_ACTED,+ person_ids={resolution.person_id} if resolution.person_id is not None else None,+ )audit_log("human_resolution",diff --git a/packages/core/tests/unit/test_extraction_gate.py b/packages/core/tests/unit/test_extraction_gate.pyindex 02c05092..50f1e7f1 100644--- a/packages/core/tests/unit/test_extraction_gate.py+++ b/packages/core/tests/unit/test_extraction_gate.py@@ -359,6 +359,8 @@ async def test_one_malformed_kind_does_not_lose_the_others(db: Path) -> None:"status": "active","summary": "Down to 400k","db_path": db,+ # No principal on this roster, so the update credits nobody.+ "updated_by_person_id": None,}assert audit[0]["details"]["stored"]["initiatives"] == 1assert audit[0]["details"]["dropped"] == [diff --git a/packages/core/tests/unit/test_outcomes.py b/packages/core/tests/unit/test_outcomes.pyindex ebf49be0..692858c2 100644--- a/packages/core/tests/unit/test_outcomes.py+++ b/packages/core/tests/unit/test_outcomes.py@@ -113,10 +113,30 @@ def test_loop_reported_done_resolves_its_chases_acted(team: SimpleNamespace) ->due_at=datetime.now(UTC))assert loop_id is not None_seed(team.sara, outcomes.SOURCE_OPEN_LOOP, None, 1, ref=f"nudge:commitment:{loop_id}")- open_loops.close_open_loop(loop_id, reason="reported_done")+ open_loops.close_open_loop(loop_id, reason="reported_done", closed_by_person_id=team.sara)assert _outcome_rows()[0]["outcome"] == "acted"+def test_principal_reporting_someone_elses_loop_done_does_not_credit_them(+ team: SimpleNamespace,+) -> None:+ loop_id = open_loops.open_loop(owner_person_id=team.sara, description="send the quote",+ due_at=datetime.now(UTC))+ assert loop_id is not None+ _seed(team.sara, outcomes.SOURCE_OPEN_LOOP, None, 1, ref=f"nudge:commitment:{loop_id}")+ assert open_loops.close_open_loop(loop_id, reason="reported_done",+ closed_by_person_id=team.principal)+ assert _outcome_rows()[0]["outcome"] is None+++def test_acted_overrides_an_earlier_ignored_but_a_reply_does_not(team: SimpleNamespace) -> None:+ _seed(team.sara, outcomes.SOURCE_OPEN_LOOP, "ignored", 1, ref="nudge:commitment:7")+ _seed(team.sara, outcomes.SOURCE_OPEN_LOOP, "ignored", 1, ref="nudge:commitment:8")+ outcomes.resolve_by_ref("nudge:commitment:7", outcomes.OUTCOME_ACTED)+ outcomes.resolve_by_ref("nudge:commitment:8", outcomes.OUTCOME_REPLIED)+ assert [r["outcome"] for r in _outcome_rows()] == ["acted", "ignored"]++def test_loop_expiry_does_not_count_as_acted(team: SimpleNamespace) -> None:loop_id = open_loops.open_loop(owner_person_id=team.sara, description="send the quote",due_at=datetime.now(UTC))@@ -142,6 +162,14 @@ def test_alert_ack_credits_only_its_owner_and_the_principal(team: SimpleNamespacassert [r["outcome"] for r in _outcome_rows()] == ["acted", None, "acted"]+def test_expired_alert_voids_even_already_ignored_dms(team: SimpleNamespace) -> None:+ from openexecutive.alerts.lifecycle import resolve_alert_outreach++ _seed(team.sara, outcomes.SOURCE_ALERT_REVIEW, "ignored", 1, ref="alert:11")+ resolve_alert_outreach(_alert(11), "expired") # type: ignore[arg-type]+ assert _outcome_rows()[0]["outcome"] == "void"++def test_dismissed_alert_voids_its_dms_and_never_counts_against_anyone(team: SimpleNamespace) -> None:from openexecutive.alerts.lifecycle import record_ack_feedback@@ -176,21 +204,42 @@ async def test_resolved_approval_credits_its_nudges(wf_persistence.create_run("run-1", "test_wf", "Test run", {})wf_persistence.save_checkpoint("run-1", json.dumps({"channel": "slack", "channel_ref": "U"}),team.sara, datetime.now(UTC) + timedelta(hours=1))+ ben = people_store.upsert_person(full_name="Ben Ortiz", slack_user_id="U_BEN")_seed(team.sara, outcomes.SOURCE_NUDGE_STALLED, None, 1, ref="nudge:stalled:run-1")+ _seed(ben, outcomes.SOURCE_NUDGE_STALLED, None, 1, ref="nudge:stalled:run-1")resolution = WaitForHumanResolution(run_id="run-1", reply_text="approved", source_channel="web", source_message_id="m",parsed_decision={"decision": "approve", "note": ""}, person_id=team.sara,)assert await apply_resolution("run-1", resolution)- assert _outcome_rows()[0]["outcome"] == "acted"+ # Only the approver's nudge landed; Ben's is still open.+ assert [r["outcome"] for r in _outcome_rows()] == ["acted", None]-def test_initiative_update_credits_its_check_ins(team: SimpleNamespace) -> None:+def test_initiative_update_credits_only_the_updaters_check_ins(team: SimpleNamespace) -> None:+ episodic.store_initiative("Launch", "active", db_path=episodic.DB_PATH)+ [init] = episodic.get_active_initiatives(db_path=episodic.DB_PATH)+ ref = f"nudge:initiative:{init.id}"+ _seed(team.sara, outcomes.SOURCE_NUDGE_INITIATIVE, None, 1, ref=ref)+ _seed(team.principal, outcomes.SOURCE_NUDGE_INITIATIVE, None, 1, ref=ref)+ # A same-status, same-summary re-mention is not an answer.+ episodic.store_initiative("Launch", "active", db_path=episodic.DB_PATH,+ updated_by_person_id=team.sara)+ assert [r["outcome"] for r in _outcome_rows()] == [None, None]+ episodic.store_initiative("Launch", "active", summary="on track", db_path=episodic.DB_PATH,+ updated_by_person_id=team.sara)+ assert [r["outcome"] for r in _outcome_rows()] == ["acted", None]+++def test_anonymous_initiative_edit_credits_nobody(team: SimpleNamespace) -> None:+ """``PATCH /memories/initiatives/{id}`` has no caller identity and calls+ ``update_initiative`` without an updater, so an edit through it must not+ mark anyone's check-ins as answered."""episodic.store_initiative("Launch", "active", db_path=episodic.DB_PATH)[init] = episodic.get_active_initiatives(db_path=episodic.DB_PATH)_seed(team.sara, outcomes.SOURCE_NUDGE_INITIATIVE, None, 1, ref=f"nudge:initiative:{init.id}")- episodic.store_initiative("Launch", "active", summary="on track", db_path=episodic.DB_PATH)- assert _outcome_rows()[0]["outcome"] == "acted"+ assert episodic.update_initiative(init.id, summary="x", db_path=episodic.DB_PATH)+ assert _outcome_rows()[0]["outcome"] is Nonedef test_principal_tidying_a_loop_does_not_credit_the_owner(team: SimpleNamespace) -> None:@@ -227,6 +276,25 @@ def test_email_cc_is_not_counted_as_outreach(team: SimpleNamespace, monkeypatch:assert [r["person_id"] for r in _outcome_rows()] == [team.sara]+def test_email_outcome_goes_to_the_first_rostered_to_address(+ team: SimpleNamespace, monkeypatch: pytest.MonkeyPatch+) -> None:+ from openexecutive.orchestrator import mcp_gateway+ from openexecutive.orchestrator.schedule_tools import current_session+ from openexecutive.orchestrator.session import Session++ people_store.update_person(team.sara, email="[email protected]")+ token = current_session.set(Session())+ try:+ with outcomes.tag_proactive(outcomes.SOURCE_NUDGE_COMMITMENT, "nudge:commitment:1"):+ mcp_gateway._record_email_outbound_context(+ {"to": ["[email protected]", "[email protected]"], "body": "Any update?"}+ )+ finally:+ current_session.reset(token)+ assert [r["person_id"] for r in _outcome_rows()] == [team.sara]++def test_rates_sweep_on_read_even_without_a_nudge_scan(team: SimpleNamespace) -> None:old = (datetime.now(UTC) - timedelta(hours=100)).isoformat()with sqlite3.connect(str(episodic.DB_PATH)) as conn:@@ -261,6 +329,21 @@ def test_acceptance_counts(team: SimpleNamespace) -> None:assert (refl.sent, refl.resolved, refl.pending) == (4, 3, 1)+def test_muted_reads_the_latest_sends_by_time_not_insert_order(team: SimpleNamespace) -> None:+ now = datetime.now(UTC)+ with sqlite3.connect(str(episodic.DB_PATH)) as conn:+ # The reply is the newest send even though its row was written first.+ for age_h, outcome in [(0, "replied"), (5, "ignored"), (4, "ignored"), (3, "ignored"),+ (2, "ignored"), (1, "ignored")]:+ conn.execute(+ "INSERT INTO proactive_outcomes (created_at, person_id, source, channel, "+ "channel_ref, outcome) VALUES (?, ?, ?, 'slack_dm', 'x', ?)",+ ((now - timedelta(hours=age_h)).isoformat(), team.sara,+ outcomes.SOURCE_OPEN_LOOP, outcome),+ )+ assert outcomes.muted_pairs(min_sends=5) == set()++def test_muted_needs_the_last_n_all_unanswered(team: SimpleNamespace) -> None:_seed(team.sara, outcomes.SOURCE_OPEN_LOOP, "ignored", 5)_seed(team.principal, outcomes.SOURCE_OPEN_LOOP, "ignored", 4)