Skip to content

AI-powered virtual executive team — a single coherent executive persona backed by 8 specialist agents (FastAPI + Next.js).

fix: address round-2 review — CORS default, trust-host override, precedence docs

Claude7c642773dacf
diff --git a/.env.example b/.env.example
index 01cdee50..9b981ad5 100644
--- a/.env.example
+++ b/.env.example
@@ -31,9 +31,12 @@ AUTH_URL=
# openssl rand -hex 32
BACKEND_SHARED_SECRET=
-# Comma-separated extra CORS origins for the FastAPI backend (the UI's public
-# Fly URL goes here once deployed). localhost is always allowed.
-BACKEND_ALLOWED_ORIGINS=https://openexec-ui-dev.fly.dev
+# Comma-separated extra CORS origins for the FastAPI backend; localhost is
+# always allowed. Deployment-only — LEAVE BLANK for local dev: with the
+# shared-secret gate unset, listing a public origin here lets scripts on
+# that origin read your local API with credentials.
+# On deploy: BACKEND_ALLOWED_ORIGINS=https://your-ui-app.fly.dev
+BACKEND_ALLOWED_ORIGINS=
# Model configuration (defaults shown)
DEFAULT_MODEL=claude-sonnet-4-6
diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml
index adf8563a..458ea731 100644
--- a/docker/docker-compose.yml
+++ b/docker/docker-compose.yml
@@ -51,7 +51,7 @@ services:
- AUTH_SECRET=${AUTH_SECRET:-}
- AUTH_GOOGLE_ID=${AUTH_GOOGLE_ID:-}
- AUTH_GOOGLE_SECRET=${AUTH_GOOGLE_SECRET:-}
- - AUTH_TRUST_HOST=${AUTH_TRUST_HOST:-true}
+ - AUTH_TRUST_HOST=${AUTH_TRUST_HOST-true}
- AUTH_URL=${AUTH_URL:-}
- ALLOWED_EMAILS=${ALLOWED_EMAILS:-}
- BACKEND_SHARED_SECRET=${BACKEND_SHARED_SECRET:-}
diff --git a/docs/auth.md b/docs/auth.md
index ae14daee..a6706716 100644
--- a/docs/auth.md
+++ b/docs/auth.md
@@ -82,11 +82,18 @@ ANTHROPIC_API_KEY=sk-ant-...
Then `make dev` and visit http://localhost:3000.
+For Docker, use `make docker` (not a bare `docker compose -f
+docker/docker-compose.yml up`): the Makefile passes `--env-file .env`, which
+is what feeds the UI container's `AUTH_*` / `BACKEND_SHARED_SECRET` values.
+If you invoke compose directly, add `--env-file .env` yourself.
+
A `packages/ui/.env.local` (also gitignored) still works, but note the
precedence: under `make dev` / `make docker` the root `.env` is exported into
the process environment before Next.js starts, and Next never overrides an
already-set variable — so **for any key present in both files, the root `.env`
-wins**. Use `.env.local` only for UI-only keys that aren't in the root file.
+wins — including keys left blank in the root file** (a blank export still
+counts as set). Use `.env.local` only for keys absent from the root `.env`
+entirely.
Plain `npm run dev` in `packages/ui` (without `make dev`) reads only
`packages/ui/.env*`, not the root `.env`.