π OpenHands: AI-Driven Development
fix(enterprise): log automation HTTP response failures as errors (#15004)
wgu90258cee25caa
diff --git a/enterprise/server/services/automation_event_service.py b/enterprise/server/services/automation_event_service.pyindex 14f2013213..4d797d417c 100644--- a/enterprise/server/services/automation_event_service.py+++ b/enterprise/server/services/automation_event_service.py@@ -618,9 +618,9 @@ class AutomationEventService:f'{resp.status} for {source} org {org_id}: {body}')elif resp.status >= 400:- # 4xx = client/contract problem, not a downstream outage+ # 4xx = contract/auth problem; the event was not delivered.body = await self._read_response_body(resp)- logger.warning(+ logger.error(f'[AutomationEventService] Automation service returned 'f'{resp.status} for {source} org {org_id}: {body}')diff --git a/enterprise/tests/unit/server/services/test_automation_event_service.py b/enterprise/tests/unit/server/services/test_automation_event_service.pyindex 10b7bb3c13..db8600831e 100644--- a/enterprise/tests/unit/server/services/test_automation_event_service.py+++ b/enterprise/tests/unit/server/services/test_automation_event_service.py@@ -1044,11 +1044,11 @@ class TestSendToAutomationService:mock_logger.warning.assert_not_called()@pytest.mark.asyncio- async def test_send_4xx_logs_warning(self, mock_token_manager):+ async def test_send_4xx_logs_error(self, mock_token_manager):"""GIVEN: Automation service returns 4xx (client error)WHEN: _send_to_automation_service is called- THEN: Warning is logged (contract/client problem, not downstream outage)+ THEN: Error is logged because the event was not delivered"""org_id = uuid.UUID('12345678-1234-5678-1234-567812345678')payload = {'organization': {'git_org': 'test'}, 'payload': {}}@@ -1084,9 +1084,9 @@ class TestSendToAutomationService:ProviderType.GITHUB, org_id, payload)- mock_logger.warning.assert_called()- assert '400' in str(mock_logger.warning.call_args)- mock_logger.error.assert_not_called()+ mock_logger.error.assert_called()+ assert '400' in str(mock_logger.error.call_args)+ mock_logger.warning.assert_not_called()class TestSignPayload: