π OpenHands: AI-Driven Development
fix(frontend): avoid dirty language filter input (#14812)
mehmet turac04b876e8a279
diff --git a/frontend/__tests__/routes/app-settings.test.tsx b/frontend/__tests__/routes/app-settings.test.tsxindex a40d21d8e6..f4201f3046 100644--- a/frontend/__tests__/routes/app-settings.test.tsx+++ b/frontend/__tests__/routes/app-settings.test.tsx@@ -173,6 +173,25 @@ describe("Form submission", () => {expect(submit).toBeDisabled();});+ it("should keep the submit button disabled while filtering languages without selecting one", async () => {+ const getSettingsSpy = vi.spyOn(SettingsService, "getSettings");+ getSettingsSpy.mockResolvedValue(MOCK_DEFAULT_USER_SETTINGS);++ const user = userEvent.setup();+ renderAppSettingsScreen();++ const language = await screen.findByTestId("language-input");+ const submit = await screen.findByTestId("submit-button");++ expect(language).toHaveValue("English");+ expect(submit).toBeDisabled();++ await user.click(language);+ await user.keyboard("Nor");++ expect(submit).toBeDisabled();+ });+it("should call handleCaptureConsents with true when the analytics switch is toggled", async () => {const getSettingsSpy = vi.spyOn(SettingsService, "getSettings");getSettingsSpy.mockResolvedValue(MOCK_DEFAULT_USER_SETTINGS);diff --git a/frontend/src/components/features/settings/app-settings/language-input.tsx b/frontend/src/components/features/settings/app-settings/language-input.tsxindex 4e41c71f62..51be4af2ab 100644--- a/frontend/src/components/features/settings/app-settings/language-input.tsx+++ b/frontend/src/components/features/settings/app-settings/language-input.tsx@@ -1,3 +1,4 @@+import type { Key } from "react";import { useTranslation } from "react-i18next";import { AvailableLanguages } from "#/i18n";import { I18nKey } from "#/i18n/declaration";@@ -15,12 +16,18 @@ export function LanguageInput({name,}: LanguageInputProps) {const { t } = useTranslation();+ const handleSelectionChange = (key: Key | null) => {+ const language = AvailableLanguages.find((l) => l.value === key);+ if (language) {+ onChange(language.label);+ }+ };return (<SettingsDropdownInputtestId={name}name={name}- onInputChange={onChange}+ onSelectionChange={handleSelectionChange}label={t(I18nKey.SETTINGS$LANGUAGE)}items={AvailableLanguages.map((l) => ({key: l.value,