Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(frontend): make secrets table responsive when descriptions are long (#12363)

Hiep Le0e3332d9749b
diff --git a/frontend/src/components/features/settings/secrets-settings/secret-list-item.tsx b/frontend/src/components/features/settings/secrets-settings/secret-list-item.tsx
index c1a40f68ce..2944988e89 100644
--- a/frontend/src/components/features/settings/secrets-settings/secret-list-item.tsx
+++ b/frontend/src/components/features/settings/secrets-settings/secret-list-item.tsx
@@ -30,40 +30,39 @@ export function SecretListItem({
onDelete,
}: SecretListItemProps) {
return (
- <tr
- data-testid="secret-item"
- className="flex w-full items-center border-t border-tertiary"
- >
- <td className="p-3 w-1/4 text-sm text-content-2 truncate" title={title}>
+ <tr data-testid="secret-item" className="border-t border-tertiary">
+ <td className="p-3 text-sm text-content-2 truncate" title={title}>
{title}
</td>
<td
- className="p-3 w-1/2 truncate overflow-hidden whitespace-nowrap text-sm text-content-2 opacity-80 italic"
+ className="p-3 truncate overflow-hidden whitespace-nowrap text-sm text-content-2 opacity-80 italic"
title={description || ""}
>
{description || ""}
</td>
- <td className="p-3 w-1/4 flex items-center justify-end gap-4">
- <button
- data-testid="edit-secret-button"
- type="button"
- onClick={onEdit}
- aria-label={`Edit ${title}`}
- className="cursor-pointer"
- >
- <FaPencil size={16} />
- </button>
- <button
- data-testid="delete-secret-button"
- type="button"
- onClick={onDelete}
- aria-label={`Delete ${title}`}
- className="cursor-pointer"
- >
- <FaTrash size={16} />
- </button>
+ <td className="p-3">
+ <div className="flex items-center justify-end gap-4">
+ <button
+ data-testid="edit-secret-button"
+ type="button"
+ onClick={onEdit}
+ aria-label={`Edit ${title}`}
+ className="cursor-pointer"
+ >
+ <FaPencil size={16} />
+ </button>
+ <button
+ data-testid="delete-secret-button"
+ type="button"
+ onClick={onDelete}
+ aria-label={`Delete ${title}`}
+ className="cursor-pointer"
+ >
+ <FaTrash size={16} />
+ </button>
+ </div>
</td>
</tr>
);
diff --git a/frontend/src/routes/secrets-settings.tsx b/frontend/src/routes/secrets-settings.tsx
index 6329a90e46..d6e81fbf97 100644
--- a/frontend/src/routes/secrets-settings.tsx
+++ b/frontend/src/routes/secrets-settings.tsx
@@ -85,9 +85,9 @@ function SecretsSettingsScreen() {
{view === "list" && (
<div className="border border-tertiary rounded-md overflow-hidden">
- <table className="w-full">
+ <table className="w-full min-w-full table-fixed">
<thead className="bg-base-tertiary">
- <tr className="flex w-full items-center">
+ <tr>
<th className="w-1/4 text-left p-3 text-sm font-medium">
{t(I18nKey.SETTINGS$NAME)}
</th>