π OpenHands: AI-Driven Development
fix(settings): show ACP-disabled tooltip on desktop (drop pointer-events-none) (#1499)
Engel Nyst1294b08944bd
diff --git a/.pr/cloud-settings-button-closeup.png b/.pr/cloud-settings-button-closeup.pngdeleted file mode 100644index 716cbc9943..0000000000Binary files a/.pr/cloud-settings-button-closeup.png and /dev/null differdiff --git a/.pr/cloud-settings-button-hidden-local-backend.png b/.pr/cloud-settings-button-hidden-local-backend.pngdeleted file mode 100644index d6d1bff7fe..0000000000Binary files a/.pr/cloud-settings-button-hidden-local-backend.png and /dev/null differdiff --git a/.pr/cloud-settings-button-visible.png b/.pr/cloud-settings-button-visible.pngdeleted file mode 100644index 15a21c9e25..0000000000Binary files a/.pr/cloud-settings-button-visible.png and /dev/null differdiff --git a/__tests__/components/features/settings/settings-navigation.test.tsx b/__tests__/components/features/settings/settings-navigation.test.tsxindex bd87782fe3..7c710bef5b 100644--- a/__tests__/components/features/settings/settings-navigation.test.tsx+++ b/__tests__/components/features/settings/settings-navigation.test.tsx@@ -1,5 +1,5 @@import type { ReactNode } from "react";-import { render, screen, waitFor, within } from "@testing-library/react";+import { render, screen, within } from "@testing-library/react";import userEvent from "@testing-library/user-event";import { describe, expect, it, vi } from "vitest";import { MemoryRouter } from "react-router";@@ -149,6 +149,37 @@ describe("SettingsNavigation", () => {expect(condenserLink).toHaveAttribute("aria-disabled", "true");});+ it("keeps pointer events on disabled-by-ACP items so the hover tooltip can open", () => {+ // Regression for the missing "Disabled while {agent} is active" tooltip+ // on desktop: the disabled link used to also get ``pointer-events-none``,+ // which stops HeroUI's pointer-driven Tooltip from ever firing β so the+ // explanation never reached the user (reported on macOS desktop). A+ // disabled item that HAS a reason must stay greyed (opacity-50) but keep+ // receiving pointer events.+ renderSettingsNavigation(+ <SettingsNavigation+ isMobileMenuOpen={false}+ onCloseMobileMenu={vi.fn()}+ navigationItems={[+ {+ type: "item",+ item: llmItem,+ disabled: true,+ disabledAgentName: "Claude Code",+ },+ ]}+ />,+ );++ const desktopNav = screen.getByTestId("settings-navbar-desktop");+ const llmLink = within(desktopNav).getByTestId(+ "sidebar-settings-/settings/llm",+ );+ expect(llmLink).toHaveAttribute("aria-disabled", "true");+ expect(llmLink.className).toContain("opacity-50");+ expect(llmLink.className).not.toContain("pointer-events-none");+ });+it("leaves enabled items clickable in the desktop sidebar", () => {renderSettingsNavigation(<SettingsNavigationdiff --git a/src/components/features/sidebar/sidebar-nav-link.tsx b/src/components/features/sidebar/sidebar-nav-link.tsxindex 8a30282e77..4fcde6509b 100644--- a/src/components/features/sidebar/sidebar-nav-link.tsx+++ b/src/components/features/sidebar/sidebar-nav-link.tsx@@ -73,10 +73,10 @@ export function SidebarNavLink({data-testid={testId}tabIndex={disabled ? -1 : 0}aria-label={collapsed ? label : undefined}- // Announce the disabled state to assistive tech. The visual disable- // (opacity + pointer-events) plus tabIndex=-1 + preventDefault gives- // sighted/keyboard users the right behaviour already; this closes- // the screen-reader gap so the link doesn't sound "actionable."+ // Announce the disabled state to assistive tech. The visual disabled+ // styling plus tabIndex=-1 + preventDefault gives sighted/keyboard users+ // the right behaviour already; this closes the screen-reader gap so the+ // link doesn't sound "actionable."aria-disabled={disabled || undefined}onClick={(e) => {if (disabled) {@@ -89,7 +89,9 @@ export function SidebarNavLink({(active? SIDEBAR_ROW_INTERACTIVE_CLASS.active: SIDEBAR_ROW_INTERACTIVE_CLASS.idle),- disabled && "pointer-events-none opacity-50",+ disabled && "opacity-50",+ // HeroUI Tooltip is pointer-driven, so keep hover events for explanations.+ disabled && !disabledReason && "pointer-events-none",)}>{icon ? (