π OpenHands: AI-Driven Development
test: strengthen chat event content (#17362)
aivong-openhands13fa6b88acfd
diff --git a/src/components/features/chat/chat-error-details.test.tsx b/src/components/features/chat/chat-error-details.test.tsxnew file mode 100644index 0000000000..6cd2b915c3--- /dev/null+++ b/src/components/features/chat/chat-error-details.test.tsx@@ -0,0 +1,101 @@+import { fireEvent, render, screen, within } from "@testing-library/react";+import { afterEach, describe, expect, it, vi } from "vitest";+import { ErrorMessage } from "./error-message";++const i18nMocks = vi.hoisted(() => ({+ exists: vi.fn(),+}));++const useTranslationMock = vi.hoisted(() =>+ vi.fn((namespace: string) => ({+ t: (key: string) =>+ namespace === "openhands" ? `translated:${key}` : `missing:${key}`,+ })),+);++vi.mock("#/i18n", () => ({+ default: {+ exists: i18nMocks.exists,+ },+}));++vi.mock("react-i18next", async (importOriginal) => ({+ ...(await importOriginal<typeof import("react-i18next")>()),+ useTranslation: useTranslationMock,+}));++interface ErrorMessageScenario {+ errorId?: string;+ translationExists?: boolean;+ defaultMessage?: string;+}++function renderChatError({+ errorId,+ translationExists = false,+ defaultMessage = "Agent failed during **repository setup**.",+}: ErrorMessageScenario = {}) {+ i18nMocks.exists.mockReturnValue(translationExists);++ return render(+ <ErrorMessage errorId={errorId} defaultMessage={defaultMessage} />,+ );+}++afterEach(() => {+ vi.clearAllMocks();+});++describe("chat error details", () => {+ it("shows the generic heading and lets the user reveal and hide details", () => {+ renderChatError();++ expect(i18nMocks.exists).not.toHaveBeenCalled();+ expect(+ screen.getByText("translated:CHAT_INTERFACE$AGENT_ERROR_MESSAGE"),+ ).toBeInTheDocument();+ expect(screen.queryByTestId("markdown-renderer")).not.toBeInTheDocument();++ const detailsToggle = screen.getByRole("button");+ fireEvent.click(detailsToggle);++ const details = screen.getByTestId("markdown-renderer");+ expect(details).toHaveTextContent("Agent failed during repository setup.");+ expect(within(details).getByText("repository setup").tagName).toBe(+ "STRONG",+ );++ fireEvent.click(detailsToggle);++ expect(screen.queryByTestId("markdown-renderer")).not.toBeInTheDocument();+ });++ it("uses the generic heading when the backend error ID is unknown", () => {+ renderChatError({ errorId: "ERROR$NEW_BACKEND_FAILURE" });++ expect(i18nMocks.exists).toHaveBeenCalledOnce();+ expect(i18nMocks.exists).toHaveBeenCalledWith("ERROR$NEW_BACKEND_FAILURE");+ expect(+ screen.getByText("translated:CHAT_INTERFACE$AGENT_ERROR_MESSAGE"),+ ).toBeInTheDocument();+ expect(+ screen.queryByText("ERROR$NEW_BACKEND_FAILURE"),+ ).not.toBeInTheDocument();+ });++ it("uses a translated backend error ID when it is available", () => {+ renderChatError({+ errorId: "ERROR$RATE_LIMITED",+ translationExists: true,+ });++ expect(i18nMocks.exists).toHaveBeenCalledOnce();+ expect(i18nMocks.exists).toHaveBeenCalledWith("ERROR$RATE_LIMITED");+ expect(+ screen.getByText("translated:ERROR$RATE_LIMITED"),+ ).toBeInTheDocument();+ expect(+ screen.queryByText("translated:CHAT_INTERFACE$AGENT_ERROR_MESSAGE"),+ ).not.toBeInTheDocument();+ });+});diff --git a/src/components/features/chat/path-component.test.tsx b/src/components/features/chat/path-component.test.tsxnew file mode 100644index 0000000000..68bbca969a--- /dev/null+++ b/src/components/features/chat/path-component.test.tsx@@ -0,0 +1,183 @@+/* eslint-disable i18next/no-literal-string -- test fixtures use literal path strings */+import { fireEvent, render, screen } from "@testing-library/react";+import { afterEach, describe, expect, it, vi } from "vitest";+import EventLogger from "#/utils/event-logger";+import {+ PathComponent,+ PathInteractiveContext,+ isLikelyDirectory,+} from "./path-component";+import { NavigationProvider } from "#/context/navigation-context";+import { openWorkspaceFile } from "#/services/canvas-ui";++vi.mock("#/services/canvas-ui", () => ({ openWorkspaceFile: vi.fn() }));++afterEach(() => {+ vi.clearAllMocks();+ vi.restoreAllMocks();+});++describe("isLikelyDirectory", () => {+ it.each([+ ["", false],+ ["src/", true],+ ["src\\", true],+ ["src/components", true],+ ["src/components/file.tsx", false],+ ["\\file.txt", false],+ [".gitignore", false],+ ])("classifies %j as %s", (path, expected) => {+ expect(isLikelyDirectory(path)).toBe(expected);+ });+});++describe("PathComponent", () => {+ it("opens the decoded path in the current conversation without toggling its parent", () => {+ const onParentClick = vi.fn();+ const subject = (conversationId: string) => (+ <NavigationProvider+ value={{+ conversationId,+ currentPath: "/",+ isNavigating: false,+ navigate: vi.fn(),+ }}+ >+ <div onClick={onParentClick}>+ <PathComponent>/workspace/a&b/readme.md</PathComponent>+ </div>+ </NavigationProvider>+ );+ const { rerender } = render(subject("first"));+ fireEvent.click(screen.getByRole("button", { name: "readme.md" }));+ expect(openWorkspaceFile).toHaveBeenLastCalledWith(+ "/workspace/a&b/readme.md",+ "first",+ );+ rerender(subject("second"));+ fireEvent.click(screen.getByRole("button", { name: "readme.md" }));+ expect(openWorkspaceFile).toHaveBeenLastCalledWith(+ "/workspace/a&b/readme.md",+ "second",+ );+ expect(onParentClick).not.toHaveBeenCalled();+ });++ it("keeps paths noninteractive inside a parent toggle", () => {+ const toggle = vi.fn();+ render(+ <button type="button" onClick={toggle}>+ <PathInteractiveContext.Provider value={false}>+ <PathComponent>/workspace/readme.md</PathComponent>+ </PathInteractiveContext.Provider>+ </button>,+ );+ expect(screen.getAllByRole("button")).toHaveLength(1);+ fireEvent.click(screen.getByText("readme.md"));+ expect(toggle).toHaveBeenCalledOnce();+ expect(openWorkspaceFile).not.toHaveBeenCalled();+ });+ it("shows a decoded Unix filename and preserves the decoded path as its title", () => {+ render(<PathComponent>/workspace/a&b/readme.md</PathComponent>);++ expect(screen.getByText("readme.md")).toHaveAttribute(+ "title",+ "/workspace/a&b/readme.md",+ );+ });++ it("extracts filenames from Windows paths", () => {+ render(<PathComponent>{"C:\\workspace\\src\\index.ts"}</PathComponent>);++ expect(screen.getByText("index.ts")).toHaveAttribute(+ "title",+ "C:\\workspace\\src\\index.ts",+ );+ });++ it("marks an extensionless final segment as a directory", () => {+ render(<PathComponent>/workspace/project/docs</PathComponent>);++ expect(screen.getByText("docs/")).toHaveAttribute(+ "title",+ "/workspace/project/docs",+ );+ });++ it("renders an empty string as an empty path", () => {+ const { container } = render(<PathComponent>{""}</PathComponent>);++ const pathElement = container.querySelector(+ '[data-testid="path-component-link"]',+ );+ expect(pathElement).toHaveAttribute("title", "");+ expect(pathElement).toBeEmptyDOMElement();+ });++ it("processes string array entries without replacing React nodes", () => {+ render(+ <PathComponent>+ {["/workspace/src/app.tsx", <em key="separator">through</em>, "tests"]}+ </PathComponent>,+ );++ expect(screen.getByText("app.tsx")).toHaveAttribute(+ "title",+ "/workspace/src/app.tsx",+ );+ expect(screen.getByText("through").tagName).toBe("EM");+ expect(screen.getByText("tests/")).toHaveAttribute("title", "tests");+ expect(screen.getByText("through").closest("span")).toHaveClass(+ "font-normal",+ );+ });++ it("renders multiple string paths without React key collisions", () => {+ const errorSpy = vi.spyOn(console, "error").mockImplementation(() => {});++ render(+ <PathComponent>+ {["/workspace/src/one.ts", "/workspace/src/two.ts"]}+ </PathComponent>,+ );++ expect(screen.getByText("one.ts")).toBeInTheDocument();+ expect(screen.getByText("two.ts")).toBeInTheDocument();+ expect(errorSpy).not.toHaveBeenCalled();+ });++ it("passes through a single non-string child", () => {+ render(+ <PathComponent>+ <em>unchanged</em>+ </PathComponent>,+ );++ expect(screen.getByText("unchanged").tagName).toBe("EM");+ expect(screen.getByText("unchanged").closest("span")).toHaveClass(+ "font-mono",+ );+ });++ it("falls back to the original path and logs decoding errors", () => {+ const createElement = document.createElement.bind(document);+ vi.spyOn(document, "createElement").mockImplementation(+ (tagName, options) => {+ if (tagName === "textarea") {+ throw new Error("decode failed");+ }+ return createElement(tagName, options);+ },+ );+ const errorSpy = vi+ .spyOn(EventLogger, "error")+ .mockImplementation(() => {});++ render(<PathComponent>/workspace/readme.md</PathComponent>);++ expect(screen.getByText("/workspace/readme.md")).not.toHaveAttribute(+ "title",+ );+ expect(errorSpy).toHaveBeenCalledWith("Error: decode failed");+ });+});