π OpenHands: AI-Driven Development
fix(app-server): restore previous DB pool_size default (#15333)
dylan1a8beb35b4a8
diff --git a/openhands/app_server/services/db_session_injector.py b/openhands/app_server/services/db_session_injector.pyindex 18ebdfedc2..955919cfcb 100644--- a/openhands/app_server/services/db_session_injector.py+++ b/openhands/app_server/services/db_session_injector.py@@ -34,8 +34,8 @@ class DbSessionInjector(BaseModel, Injector[AsyncSession]):user: str | None = Nonepassword: SecretStr | None = Noneecho: bool = False- # Defaults follow SQLAlchemy's own pool_size=5, max_overflow=10)- pool_size: int = 5+ # can be overriden with DB_POOL_SIZE / DB_MAX_OVERFLOW (see fill_empty_fields).+ pool_size: int = 25max_overflow: int = 10pool_recycle: int = 1800pool_use_lifo: bool = Truediff --git a/tests/unit/app_server/test_db_session_injector.py b/tests/unit/app_server/test_db_session_injector.pyindex fddab1e76f..dc0e07d128 100644--- a/tests/unit/app_server/test_db_session_injector.py+++ b/tests/unit/app_server/test_db_session_injector.py@@ -103,7 +103,7 @@ class TestDbSessionInjectorConfiguration:service.password.get_secret_value() == 'postgres') # Default from env var processingassert service.echo is False- assert service.pool_size == 5+ assert service.pool_size == 25assert service.max_overflow == 10assert service.pool_use_lifo is Trueassert service.gcp_db_instance is None@@ -221,7 +221,7 @@ class TestDbSessionInjectorConnections:# Verify other parametersassert call_args[1]['connect_args'] == {}- assert call_args[1]['pool_size'] == 5+ assert call_args[1]['pool_size'] == 25assert call_args[1]['max_overflow'] == 10assert call_args[1]['pool_pre_ping']assert call_args[1]['pool_use_lifo'] is True@@ -255,7 +255,7 @@ class TestDbSessionInjectorConnections:# Verify other parametersassert call_args[1]['connect_args'] == {}- assert call_args[1]['pool_size'] == 5+ assert call_args[1]['pool_size'] == 25assert call_args[1]['max_overflow'] == 10assert call_args[1]['pool_pre_ping']assert call_args[1]['pool_use_lifo'] is True