π OpenHands: AI-Driven Development
fix: hide Code tab when active backend is local (#272)
Hiep Le1c64a52d2c18
diff --git a/__tests__/components/features/conversation/conversation-tabs-context-menu.test.tsx b/__tests__/components/features/conversation/conversation-tabs-context-menu.test.tsxindex 9944b8e391..bad786abd4 100644--- a/__tests__/components/features/conversation/conversation-tabs-context-menu.test.tsx+++ b/__tests__/components/features/conversation/conversation-tabs-context-menu.test.tsx@@ -3,6 +3,13 @@ import userEvent from "@testing-library/user-event";import { describe, it, expect, vi, beforeEach } from "vitest";import { ConversationTabsContextMenu } from "#/components/features/conversation/conversation-tabs/conversation-tabs-context-menu";import { useConversationStore } from "#/stores/conversation-store";+import { ActiveBackendProvider } from "#/contexts/active-backend-context";+import { __resetActiveStoreForTests } from "#/api/backend-registry/active-store";+import {+ ACTIVE_BACKEND_STORAGE_KEY,+ BACKENDS_STORAGE_KEY,+} from "#/api/backend-registry/storage";+import type { Backend } from "#/api/backend-registry/types";const CONVERSATION_ID = "conv-abc123";@@ -18,9 +25,19 @@ vi.mock("#/hooks/use-task-list", () => ({}),}));+function seedActiveBackend(backend: Backend): void {+ localStorage.setItem(BACKENDS_STORAGE_KEY, JSON.stringify([backend]));+ localStorage.setItem(+ ACTIVE_BACKEND_STORAGE_KEY,+ JSON.stringify({ backendId: backend.id, orgId: null }),+ );+ __resetActiveStoreForTests();+}+describe("ConversationTabsContextMenu", () => {beforeEach(() => {localStorage.clear();+ __resetActiveStoreForTests();mockHasTaskList = false;useConversationStore.setState({selectedTab: "editor",@@ -40,10 +57,10 @@ describe("ConversationTabsContextMenu", () => {it("should render all default tabs when open", () => {render(<ConversationTabsContextMenu isOpen={true} onClose={vi.fn()} />);+ // Default active backend is local, so the Code (vscode) entry is hidden.const expectedTabs = ["COMMON$PLANNER","COMMON$CHANGES",- "COMMON$CODE","COMMON$TERMINAL","COMMON$APP","COMMON$BROWSER",@@ -53,6 +70,27 @@ describe("ConversationTabsContextMenu", () => {}});+ it("should show the Code entry when the active backend is cloud", () => {+ // Arrange+ seedActiveBackend({+ id: "cloud-test",+ name: "Cloud Test",+ host: "https://app.example.com",+ apiKey: "secret",+ kind: "cloud",+ });++ // Act+ render(+ <ActiveBackendProvider>+ <ConversationTabsContextMenu isOpen={true} onClose={vi.fn()} />+ </ActiveBackendProvider>,+ );++ // Assert+ expect(screen.getByText("COMMON$CODE")).toBeInTheDocument();+ });+it("should re-pin a tab when clicking an unpinned tab", async () => {const user = userEvent.setup();diff --git a/__tests__/components/features/conversation/conversation-tabs.test.tsx b/__tests__/components/features/conversation/conversation-tabs.test.tsxindex fc4f8f503e..92c5dd5b07 100644--- a/__tests__/components/features/conversation/conversation-tabs.test.tsx+++ b/__tests__/components/features/conversation/conversation-tabs.test.tsx@@ -6,6 +6,13 @@ import { MemoryRouter } from "react-router";import { ConversationTabs } from "#/components/features/conversation/conversation-tabs/conversation-tabs";import { useConversationStore } from "#/stores/conversation-store";import { AgentState } from "#/types/agent-state";+import { ActiveBackendProvider } from "#/contexts/active-backend-context";+import { __resetActiveStoreForTests } from "#/api/backend-registry/active-store";+import {+ ACTIVE_BACKEND_STORAGE_KEY,+ BACKENDS_STORAGE_KEY,+} from "#/api/backend-registry/storage";+import type { Backend } from "#/api/backend-registry/types";const TASK_CONVERSATION_ID = "task-ec03fb2ab8604517b24af632b058c2fd";const REAL_CONVERSATION_ID = "conv-abc123";@@ -50,7 +57,7 @@ const createWrapper = (conversationId: string) => {return ({ children }: { children: React.ReactNode }) => (<MemoryRouter initialEntries={[`/conversations/${conversationId}`]}><QueryClientProvider client={new QueryClient()}>- {children}+ <ActiveBackendProvider>{children}</ActiveBackendProvider></QueryClientProvider></MemoryRouter>);@@ -74,6 +81,15 @@ const seedConversationState = ();};+function seedActiveBackend(backend: Backend): void {+ localStorage.setItem(BACKENDS_STORAGE_KEY, JSON.stringify([backend]));+ localStorage.setItem(+ ACTIVE_BACKEND_STORAGE_KEY,+ JSON.stringify({ backendId: backend.id, orgId: null }),+ );+ __resetActiveStoreForTests();+}+const setActiveTabState = (tab: "editor" | "planner") => {seedConversationState(REAL_CONVERSATION_ID, {selectedTab: tab,@@ -89,6 +105,7 @@ const setActiveTabState = (tab: "editor" | "planner") => {describe("ConversationTabs localStorage behavior", () => {beforeEach(() => {localStorage.clear();+ __resetActiveStoreForTests();vi.resetAllMocks();mockRefetchGitChanges.mockReset();mockHandleBuildPlanClick.mockReset();@@ -332,6 +349,53 @@ describe("ConversationTabs localStorage behavior", () => {});});+ describe("vscode tab visibility by backend kind", () => {+ beforeEach(() => {+ mockConversationId = REAL_CONVERSATION_ID;+ });++ it("should hide the vscode tab when the active backend is local", () => {+ // Arrange+ seedActiveBackend({+ id: "local-test",+ name: "Local Test",+ host: "http://localhost:8000",+ apiKey: "",+ kind: "local",+ });++ // Act+ render(<ConversationTabs />, {+ wrapper: createWrapper(REAL_CONVERSATION_ID),+ });++ // Assert+ expect(+ screen.queryByTestId("conversation-tab-vscode"),+ ).not.toBeInTheDocument();+ });++ it("should show the vscode tab when the active backend is cloud", () => {+ // Arrange+ seedActiveBackend({+ id: "cloud-test",+ name: "Cloud Test",+ host: "https://app.example.com",+ apiKey: "secret",+ kind: "cloud",+ });++ // Act+ render(<ConversationTabs />, {+ wrapper: createWrapper(REAL_CONVERSATION_ID),+ });++ // Assert+ expect(+ screen.getByTestId("conversation-tab-vscode"),+ ).toBeInTheDocument();+ });+ });describe("tasklist tab", () => {beforeEach(() => {diff --git a/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsx b/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsxindex 3f4b465f3b..6ac7ade37c 100644--- a/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsx+++ b/src/components/features/conversation/conversation-tabs/conversation-tabs-context-menu.tsx@@ -16,6 +16,7 @@ import PillFillIcon from "#/icons/pill-fill.svg?react";import LessonPlanIcon from "#/icons/lesson-plan.svg?react";import DoubleCheckIcon from "#/icons/double-check.svg?react";import { useTaskList } from "#/hooks/use-task-list";+import { useActiveBackend } from "#/contexts/active-backend-context";interface ConversationTabsContextMenuProps {isOpen: boolean;@@ -35,6 +36,7 @@ export function ConversationTabsContextMenu({useConversationStore();const { hasTaskList } = useTaskList();+ const { backend } = useActiveBackend();const tabConfig = [{@@ -57,6 +59,11 @@ export function ConversationTabsContextMenu({});}+ // Hide the VSCode pin/unpin entry on local backends, mirroring the tab bar.+ const visibleTabConfig = tabConfig.filter(+ ({ tab }) => tab !== "vscode" || backend.kind === "cloud",+ );+if (!isOpen) return null;const handleTabClick = (tab: string) => {@@ -78,7 +85,7 @@ export function ConversationTabsContextMenu({position="bottom"className="mt-2 w-fit z-[9999]">- {tabConfig.map(({ tab, icon: Icon, i18nKey }) => {+ {visibleTabConfig.map(({ tab, icon: Icon, i18nKey }) => {const pinned = !state.unpinnedTabs.includes(tab);return (<ContextMenuListItemdiff --git a/src/components/features/conversation/conversation-tabs/conversation-tabs.tsx b/src/components/features/conversation/conversation-tabs/conversation-tabs.tsxindex ce79948d65..8badcb3a8e 100644--- a/src/components/features/conversation/conversation-tabs/conversation-tabs.tsx+++ b/src/components/features/conversation/conversation-tabs/conversation-tabs.tsx@@ -20,6 +20,7 @@ import { ConversationTabsContextMenu } from "./conversation-tabs-context-menu";import { useConversationId } from "#/hooks/use-conversation-id";import { useSelectConversationTab } from "#/hooks/use-select-conversation-tab";import { useTaskList } from "#/hooks/use-task-list";+import { useActiveBackend } from "#/contexts/active-backend-context";import { useUnifiedGetGitChanges } from "#/hooks/query/use-unified-get-git-changes";import { useHandleBuildPlanClick } from "#/hooks/use-handle-build-plan-click";import { useAgentState } from "#/hooks/use-agent-state";@@ -37,6 +38,7 @@ export function ConversationTabs() {useConversationLocalStorageState(conversationId);const { hasTaskList } = useTaskList();+ const { backend } = useActiveBackend();const { refetch: refetchGitChanges, isFetching: isFetchingGitChanges } =useUnifiedGetGitChanges();@@ -148,10 +150,12 @@ export function ConversationTabs() {});}- // Filter out unpinned tabs- const visibleTabs = tabs.filter(- (tab) => !persistedState.unpinnedTabs.includes(tab.tabValue),- );+ // Filter out unpinned tabs, and hide the VSCode tab on local backends+ // (the agent-server's VSCode URL is only reachable in cloud deployments).+ const visibleTabs = tabs.filter((tab) => {+ if (tab.tabValue === "vscode" && backend.kind !== "cloud") return false;+ return !persistedState.unpinnedTabs.includes(tab.tabValue);+ });const isAgentRunning =curAgentState === AgentState.RUNNING ||