Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix: drop low-contrast placeholders from LLM provider/model dropdowns (#706)

Hiep Le1df24af56adf
diff --git a/__tests__/components/modals/settings/model-selector.test.tsx b/__tests__/components/modals/settings/model-selector.test.tsx
index a471234ece..fcc7767501 100644
--- a/__tests__/components/modals/settings/model-selector.test.tsx
+++ b/__tests__/components/modals/settings/model-selector.test.tsx
@@ -137,4 +137,14 @@ describe("ModelSelector", () => {
});
});
+ it("should not render placeholder text on the provider or model inputs", () => {
+ renderWithQuery(<ModelSelector />);
+
+ const providerInput = screen.getByLabelText("LLM Provider");
+ const modelInput = screen.getByLabelText("LLM Model");
+
+ expect(providerInput.getAttribute("placeholder") ?? "").toBe("");
+ expect(modelInput.getAttribute("placeholder") ?? "").toBe("");
+ });
+
});
diff --git a/src/components/shared/modals/settings/model-selector.tsx b/src/components/shared/modals/settings/model-selector.tsx
index a4272b90ee..84b4b5f3eb 100644
--- a/src/components/shared/modals/settings/model-selector.tsx
+++ b/src/components/shared/modals/settings/model-selector.tsx
@@ -132,7 +132,6 @@ export function ModelSelector({
name="llm-provider-input"
isDisabled={isDisabled}
aria-label={t(I18nKey.LLM$PROVIDER)}
- placeholder={t(I18nKey.LLM$SELECT_PROVIDER_PLACEHOLDER)}
isClearable={false}
onSelectionChange={(e) => {
if (e?.toString()) handleChangeProvider(e.toString());
@@ -150,7 +149,7 @@ export function ModelSelector({
inputProps={{
classNames: {
inputWrapper:
- "bg-tertiary border border-[var(--oh-border-input)] h-10 w-full rounded-sm p-2 placeholder:italic",
+ "bg-tertiary border border-[var(--oh-border-input)] h-10 w-full rounded-sm p-2",
},
}}
>
@@ -204,7 +203,6 @@ export function ModelSelector({
isLoading={isLoadingModels}
name="llm-model-input"
aria-label={t(I18nKey.LLM$MODEL)}
- placeholder={t(I18nKey.LLM$SELECT_MODEL_PLACEHOLDER)}
isClearable={false}
onSelectionChange={(e) => {
if (e?.toString()) handleChangeModel(e.toString());
@@ -222,7 +220,7 @@ export function ModelSelector({
inputProps={{
classNames: {
inputWrapper:
- "bg-tertiary border border-[var(--oh-border-input)] h-10 w-full rounded-sm p-2 placeholder:italic",
+ "bg-tertiary border border-[var(--oh-border-input)] h-10 w-full rounded-sm p-2",
},
}}
>