Skip to content

πŸ™Œ OpenHands: AI-Driven Development

fix(themes): use readable validation and service errors (#18330)

Engel Nyst2bdc0e9d6c59
diff --git a/specs/form-feedback.md b/specs/form-feedback.md
new file mode 100644
index 0000000000..0627ac6412
--- /dev/null
+++ b/specs/form-feedback.md
@@ -0,0 +1,4 @@
+# Form feedback theme contract
+
+### FF-001: Theme-aware validation and load errors
+- [x] Form validation, profile load failures, missing-model guidance, and inline service errors shall use the host-overridable feedback-error text role. Invalid manifest control borders shall use semantic danger. Preserve messages, ARIA state, validation, retries, save behavior, and transport contracts; small error text must remain readable in all five themes.
diff --git a/src/components/features/conversation-panel/edit-conversation-tags-modal.tsx b/src/components/features/conversation-panel/edit-conversation-tags-modal.tsx
index 9ab5e2f0a7..1888d08c18 100644
--- a/src/components/features/conversation-panel/edit-conversation-tags-modal.tsx
+++ b/src/components/features/conversation-panel/edit-conversation-tags-modal.tsx
@@ -232,7 +232,7 @@ export function EditConversationTagsModal({
<p
role="alert"
data-testid="edit-tags-error"
- className="text-xs text-red-400"
+ className="text-xs text-feedback-error"
>
{t(errorKey)}
</p>
diff --git a/src/components/features/home/shared/error-message.tsx b/src/components/features/home/shared/error-message.tsx
index df4cc05e99..8370f7f461 100644
--- a/src/components/features/home/shared/error-message.tsx
+++ b/src/components/features/home/shared/error-message.tsx
@@ -14,7 +14,7 @@ export function ErrorMessage({
if (!isError) return null;
return (
- <div className="text-red-500 text-sm mt-1" data-testid={testId}>
+ <div className="text-feedback-error text-sm mt-1" data-testid={testId}>
{message}
</div>
);
diff --git a/src/components/features/home/workspace-dropdown/folder-browser-modal.tsx b/src/components/features/home/workspace-dropdown/folder-browser-modal.tsx
index fe9f834353..31a68cab87 100644
--- a/src/components/features/home/workspace-dropdown/folder-browser-modal.tsx
+++ b/src/components/features/home/workspace-dropdown/folder-browser-modal.tsx
@@ -319,7 +319,7 @@ export function FolderBrowserModal({
)}
{isError && (
<li
- className="px-4 py-2 text-sm text-red-400"
+ className="px-4 py-2 text-sm text-feedback-error"
data-testid="folder-browser-error"
>
{(error as Error | undefined)?.message ??
diff --git a/src/components/features/manifest/manifest-form-field.tsx b/src/components/features/manifest/manifest-form-field.tsx
index 76f22c1c58..d54638c29c 100644
--- a/src/components/features/manifest/manifest-form-field.tsx
+++ b/src/components/features/manifest/manifest-form-field.tsx
@@ -182,7 +182,7 @@ export function SetupFormField({
onBlur={onBlur}
className={cn(
formControlMultilineFieldClassName,
- error && "border-red-500",
+ error && "border-semantic-danger",
)}
/>
<FieldError testId={testId} error={error} />
@@ -209,7 +209,7 @@ export function SetupFormField({
className={cn(
formControlSettingsFieldClassName,
"file:mr-3 file:rounded-md file:border-0 file:bg-neutral-700 file:px-3 file:py-1.5 file:text-sm file:text-white",
- error && "border-red-500",
+ error && "border-semantic-danger",
)}
/>
{fieldText(value) && (
@@ -237,7 +237,7 @@ export function SetupFormField({
onBlur={onBlur}
className={cn(
formControlMultilineFieldClassName,
- error && "border-red-500",
+ error && "border-semantic-danger",
)}
/>
<FieldError testId={testId} error={error} />
@@ -281,7 +281,7 @@ function FieldLabelText({ field }: { field: SetupFormFieldDefinition }) {
<span className="flex items-center gap-2 text-sm">
{field.label}
{field.required && (
- <span className="text-sm leading-none text-red-400" aria-hidden>
+ <span className="text-sm leading-none text-feedback-error" aria-hidden>
*
</span>
)}
@@ -297,13 +297,14 @@ function FieldLabel({ field }: { field: SetupFormFieldDefinition }) {
);
}
+// @spec FF-001 β€” Manifest validation feedback follows the host error role
function FieldError({ testId, error }: { testId: string; error?: string }) {
if (!error) return null;
return (
<p
role="alert"
data-testid={`${testId}-error`}
- className="-mt-1 text-xs text-red-400"
+ className="-mt-1 text-xs text-feedback-error"
>
{error}
</p>
diff --git a/src/components/features/manifest/manifest-setup-dialog.tsx b/src/components/features/manifest/manifest-setup-dialog.tsx
index d4db1d5808..b232222669 100644
--- a/src/components/features/manifest/manifest-setup-dialog.tsx
+++ b/src/components/features/manifest/manifest-setup-dialog.tsx
@@ -601,7 +601,7 @@ export function SetupDialog({ entry, onClose }: SetupDialogProps) {
key={message}
role="alert"
data-testid="setup-form-error"
- className="pt-4 text-sm text-red-400"
+ className="pt-4 text-sm text-feedback-error"
>
{message}
</p>
diff --git a/src/components/features/mcp-page/mcp-server-health.tsx b/src/components/features/mcp-page/mcp-server-health.tsx
index 0554e6725d..a69ed44675 100644
--- a/src/components/features/mcp-page/mcp-server-health.tsx
+++ b/src/components/features/mcp-page/mcp-server-health.tsx
@@ -139,7 +139,7 @@ export function McpServerHealthSection({
data-testid={`mcp-health-label-${server.id}`}
className={cn(
"line-clamp-2 break-words text-xs",
- isFailed ? "text-red-500" : "text-tertiary-alt",
+ isFailed ? "text-feedback-error" : "text-tertiary-alt",
)}
title={label}
>
diff --git a/src/components/features/mcp-page/native-integration-panel.tsx b/src/components/features/mcp-page/native-integration-panel.tsx
index 16858ba4df..8f80adcb92 100644
--- a/src/components/features/mcp-page/native-integration-panel.tsx
+++ b/src/components/features/mcp-page/native-integration-panel.tsx
@@ -132,7 +132,10 @@ export function NativeIntegrationPanel({
</div>
{error && (
- <p data-testid="mcp-native-error" className="text-sm text-red-500">
+ <p
+ data-testid="mcp-native-error"
+ className="text-sm text-feedback-error"
+ >
{error}
</p>
)}
diff --git a/src/components/features/settings/agent-profiles/agent-profiles-body.tsx b/src/components/features/settings/agent-profiles/agent-profiles-body.tsx
index 4cf06ddccc..4d645ee833 100644
--- a/src/components/features/settings/agent-profiles/agent-profiles-body.tsx
+++ b/src/components/features/settings/agent-profiles/agent-profiles-body.tsx
@@ -50,7 +50,7 @@ export function AgentProfilesBody({
data-testid="agent-profiles-load-error"
className={extensionModuleEmptyStateClassName}
>
- <p className="text-sm text-red-400">
+ <p className="text-sm text-feedback-error">
{t(I18nKey.SETTINGS$PROFILES_LOAD_ERROR)}
</p>
</div>
diff --git a/src/components/features/settings/agent-profiles/agent-profiles-local-view.tsx b/src/components/features/settings/agent-profiles/agent-profiles-local-view.tsx
index 5f0d20dc51..3a3af4f316 100644
--- a/src/components/features/settings/agent-profiles/agent-profiles-local-view.tsx
+++ b/src/components/features/settings/agent-profiles/agent-profiles-local-view.tsx
@@ -336,6 +336,7 @@ export function AgentProfilesLocalView() {
}
/>
+ {/* @spec FF-001 β€” Profile validation feedback follows the host error role */}
{/* OpenHands profiles reference an LLM profile (required). */}
{isOpenHands &&
(llmProfiles.length > 0 ? (
@@ -353,7 +354,7 @@ export function AgentProfilesLocalView() {
) : (
<p
data-testid="agent-profile-no-llm"
- className="text-sm text-red-400"
+ className="text-sm text-feedback-error"
>
{t(I18nKey.SETTINGS$AGENT_PROFILE_NO_LLM)}
</p>
diff --git a/src/components/features/settings/llm-profiles/profiles-body.tsx b/src/components/features/settings/llm-profiles/profiles-body.tsx
index ead3f0b772..87a709c13f 100644
--- a/src/components/features/settings/llm-profiles/profiles-body.tsx
+++ b/src/components/features/settings/llm-profiles/profiles-body.tsx
@@ -132,7 +132,7 @@ export function ProfilesBody({
data-testid="profiles-load-error"
className={extensionModuleEmptyStateClassName}
>
- <p className="text-sm text-red-400">
+ <p className="text-sm text-feedback-error">
{t(I18nKey.SETTINGS$PROFILES_LOAD_ERROR)}
</p>
</div>
diff --git a/src/components/features/settings/llm-profiles/provider-connections-manager.tsx b/src/components/features/settings/llm-profiles/provider-connections-manager.tsx
index 12d849e40b..c6977c11c8 100644
--- a/src/components/features/settings/llm-profiles/provider-connections-manager.tsx
+++ b/src/components/features/settings/llm-profiles/provider-connections-manager.tsx
@@ -56,7 +56,7 @@ export function ProviderConnectionsManager({
data-testid="provider-connections-load-error"
className={extensionModuleEmptyStateClassName}
>
- <p className="text-sm text-red-400">
+ <p className="text-sm text-feedback-error">
{t(I18nKey.SETTINGS$PROVIDER_CONNECTIONS_LOAD_ERROR)}
</p>
</div>
diff --git a/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx b/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx
index d9d0a08e30..593d0b9108 100644
--- a/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx
+++ b/src/components/features/settings/meta-llm-profiles/meta-llm-settings-view.tsx
@@ -347,7 +347,9 @@ export function MetaLlmSettingsView() {
) : null}
{error ? (
- <p className="text-sm text-red-400">{t(I18nKey.ERROR$GENERIC)}</p>
+ <p className="text-sm text-feedback-error">
+ {t(I18nKey.ERROR$GENERIC)}
+ </p>
) : null}
{!isLoading && !error && metaProfiles.length === 0 ? (
diff --git a/src/components/features/settings/meta-llm-profiles/meta-profile-editor.tsx b/src/components/features/settings/meta-llm-profiles/meta-profile-editor.tsx
index 65a612557f..4689f98d5b 100644
--- a/src/components/features/settings/meta-llm-profiles/meta-profile-editor.tsx
+++ b/src/components/features/settings/meta-llm-profiles/meta-profile-editor.tsx
@@ -214,7 +214,7 @@ export function MetaProfileEditor({
{isDuplicateName ? (
<p
data-testid="meta-profile-name-taken"
- className="text-xs text-red-400"
+ className="text-xs text-feedback-error"
>
{t(I18nKey.SETTINGS$META_PROFILE_NAME_TAKEN)}
</p>
diff --git a/src/components/shared/risk-alert.tsx b/src/components/shared/risk-alert.tsx
index 5888a108ec..86bcb0546e 100644
--- a/src/components/shared/risk-alert.tsx
+++ b/src/components/shared/risk-alert.tsx
@@ -21,7 +21,7 @@ export function RiskAlert({
return (
<div
className={cn(
- "flex items-center gap-3.5 bg-[#4A0709] border border-[#FF0006] text-red-400 rounded-xl px-3.5 h-13 text-sm text-white",
+ "flex items-center gap-3.5 bg-[#4A0709] border border-[#FF0006] text-feedback-error rounded-xl px-3.5 h-13 text-sm text-white",
className,
)}
>
diff --git a/src/routes/agent-settings.tsx b/src/routes/agent-settings.tsx
index de58f93a3a..6682a5cd9c 100644
--- a/src/routes/agent-settings.tsx
+++ b/src/routes/agent-settings.tsx
@@ -1001,7 +1001,7 @@ export function AgentSettingsScreen({
className="flex items-center gap-2"
data-testid="agent-settings-tools-load-failed"
>
- <Typography.Text className="text-xs text-red-400">
+ <Typography.Text className="text-xs text-feedback-error">
{t(I18nKey.SETTINGS$AGENT_PROFILE_TOOLS_LOAD_FAILED)}{" "}
{t(I18nKey.SETTINGS$AGENT_PROFILE_TOOLS_KEPT_ON_SAVE)}
</Typography.Text>
diff --git a/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts b/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts
index 39d5cefd6d..c458852f33 100644
--- a/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts
+++ b/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts
@@ -685,6 +685,38 @@ test.describe("UI regressions", () => {
await expect(dropdown).toBeEnabled({ timeout: 15_000 });
await expect(dropdown).toHaveValue("");
});
+
+ // @spec FF-001 β€” Validation feedback follows the embedding host's error role
+ test("profile validation feedback follows the host error role", async ({
+ page,
+ }) => {
+ await routeSessionApiKey(page);
+ // Isolate the missing-model state from profiles saved by earlier scenarios.
+ // Mock the underlying read contract, while the real editor and built CSS run.
+ await page.route("**/api/profiles", async (route, request) => {
+ if (request.method() !== "GET") return route.fallback();
+ return route.fulfill({
+ contentType: "application/json",
+ body: JSON.stringify({ profiles: [], active_profile: null }),
+ });
+ });
+ await page.goto("/settings/agents", { waitUntil: "domcontentloaded" });
+ await page.getByTestId("add-agent-profile").click();
+ await expect(page.getByTestId("agent-profile-no-llm")).toBeVisible();
+ await page.getByTestId("agent-profile-no-llm").evaluate((el) => {
+ const scope = el.closest("[data-agent-server-ui]");
+ if (!scope) throw new Error("Agent Server UI theme scope not found");
+ (scope as HTMLElement).style.setProperty(
+ "--oh-feedback-error",
+ "#8b1029",
+ );
+ });
+ await expect(page.getByTestId("agent-profile-no-llm")).toHaveCSS(
+ "color",
+ "rgb(139, 16, 41)",
+ );
+ });
+
// @spec WN-001 β€” Home warning icon follows the embedding host warning role
test("home warning icon follows the host warning color", async ({ page }) => {
await routeSessionApiKey(page);