π OpenHands: AI-Driven Development
refactor(acp): drop obsolete ClientAcpProviderRegistry cast, use SDK type (#1873)
Vasco Schiavo2dbb753cf98f
diff --git a/__tests__/constants/acp-providers.test.ts b/__tests__/constants/acp-providers.test.tsindex 8c99c4599d..ca65e08aa4 100644--- a/__tests__/constants/acp-providers.test.ts+++ b/__tests__/constants/acp-providers.test.ts@@ -1,4 +1,5 @@import { describe, expect, it } from "vitest";+import { getAcpProvider as getClientAcpProvider } from "@openhands/typescript-client";import {ACP_CUSTOM_PRESET_KEY,ACP_PROVIDERS,@@ -40,6 +41,26 @@ describe("getAcpProviderDisplayName", () => {});describe("ACP provider registry", () => {+ it("sources display_name / default_command / models from the SDK, not a local mirror", () => {+ // Core invariant of agent-canvas#678: the registry data fields must come+ // straight from @openhands/typescript-client's getAcpProvider(), so the+ // Python SDK stays the single source of truth. Only the UI-only overlay+ // (icon + description_key) is layered on locally.+ for (const provider of ACP_PROVIDERS) {+ const sdk = getClientAcpProvider(provider.key);+ expect(sdk, provider.key).not.toBeNull();+ expect(provider.display_name).toBe(sdk!.display_name);+ expect(provider.default_command).toEqual([...sdk!.default_command]);+ expect(provider.available_models).toEqual(+ sdk!.available_models.map((m) => ({ id: m.id, label: m.label })),+ );+ expect(provider.default_model).toBe(sdk!.default_model ?? undefined);+ // UI-only overlay stays local.+ expect(provider.icon).toBeTruthy();+ expect(provider.description_key).toBeTruthy();+ }+ });+it("keeps every built-in default model in the UX suggestions", () => {for (const provider of ACP_PROVIDERS) {expect(provider.default_model, provider.key).toBeTruthy();diff --git a/src/constants/acp-providers.ts b/src/constants/acp-providers.tsindex 584e99da01..854d82feaa 100644--- a/src/constants/acp-providers.ts+++ b/src/constants/acp-providers.ts@@ -1,14 +1,6 @@import { getAcpProvider as getClientAcpProvider } from "@openhands/typescript-client";import { I18nKey } from "#/i18n/declaration";-/** Upstream registry fields not yet on the pinned client's exported type. */-type ClientAcpProviderRegistry = NonNullable<- ReturnType<typeof getClientAcpProvider>-> & {- available_models?: Array<{ id: string; label: string }>;- default_model?: string;-};-export type ACPProviderIcon =| "claude-code"| "codex"@@ -159,7 +151,7 @@ const ACP_PROVIDER_UI: Record<export const ACP_PROVIDERS: ACPProviderConfig[] = Object.entries(ACP_PROVIDER_UI,).map(([key, ui]) => {- const info = getClientAcpProvider(key) as ClientAcpProviderRegistry | null;+ const info = getClientAcpProvider(key);return {key,display_name: info?.display_name ?? key,