π OpenHands: AI-Driven Development
Fix flaky test_tool_call_validation_error_handling test (#12110)
Graham Neubig305396550afb
diff --git a/tests/unit/controller/test_agent_controller.py b/tests/unit/controller/test_agent_controller.pyindex 88b04b5738..3da87ecfdf 100644--- a/tests/unit/controller/test_agent_controller.py+++ b/tests/unit/controller/test_agent_controller.py@@ -24,6 +24,7 @@ from openhands.core.schema import AgentStatefrom openhands.events import Event, EventSource, EventStream, EventStreamSubscriberfrom openhands.events.action import ChangeAgentStateAction, CmdRunAction, MessageActionfrom openhands.events.action.agent import CondensationAction, RecallAction+from openhands.events.action.empty import NullActionfrom openhands.events.action.message import SystemMessageActionfrom openhands.events.event import RecallTypefrom openhands.events.observation import (@@ -319,13 +320,22 @@ async def test_tool_call_validation_error_handling(controller.state.agent_state = AgentState.RUNNING- # Mock the agent.step method to raise a BadRequestError with tool validation failure+ # Track call count to only raise error on first call+ # This prevents a feedback loop where ErrorObservation triggers another step+ # which raises the same error again (since the mock always raises)+ call_count = 0+def mock_step(state):- raise BadRequestError(- message='litellm.BadRequestError: GroqException - {"error":{"message":"tool call validation failed: parameters for tool str_replace_editor did not match schema: errors: [missing properties: \'path\']","type":"invalid_request_error","code":"tool_use_failed"}}',- model='groq/llama3-8b-8192',- llm_provider='groq',- )+ nonlocal call_count+ call_count += 1+ if call_count == 1:+ raise BadRequestError(+ message='litellm.BadRequestError: GroqException - {"error":{"message":"tool call validation failed: parameters for tool str_replace_editor did not match schema: errors: [missing properties: \'path\']","type":"invalid_request_error","code":"tool_use_failed"}}',+ model='groq/llama3-8b-8192',+ llm_provider='groq',+ )+ # Return NullAction on subsequent calls to break the feedback loop+ return NullAction()mock_agent.step = mock_step