π OpenHands: AI-Driven Development
fix(themes): make backend connection feedback readable (#18321)
Engel Nyst3be48bfaf7ea
diff --git a/__tests__/components/backends/api-key-entry-screen.test.tsx b/__tests__/components/backends/api-key-entry-screen.test.tsxindex 3544d1525d..ac509314cf 100644--- a/__tests__/components/backends/api-key-entry-screen.test.tsx+++ b/__tests__/components/backends/api-key-entry-screen.test.tsx@@ -196,9 +196,6 @@ describe("ApiKeyEntryScreen", () => {await waitFor(() => {expect(screen.getByTestId("api-key-entry-status")).toBeInTheDocument();});- expect(screen.getByTestId("api-key-entry-status")).toHaveClass(- "text-red-400",- );expect(screen.getByTestId("api-key-entry-status").textContent).toContain("AUTH$INVALID_KEY",);@@ -265,8 +262,8 @@ describe("ApiKeyEntryScreen", () => {await fillRequiredFields(user, { apiKey: "wrong-key" });await user.click(screen.getByTestId("api-key-entry-submit"));await waitFor(() => {- expect(screen.getByTestId("api-key-entry-status")).toHaveClass(- "text-red-400",+ expect(screen.getByTestId("api-key-entry-status")).toHaveTextContent(+ "AUTH$INVALID_KEY",);});diff --git a/specs/backend-management.md b/specs/backend-management.mdindex 53df60a0bb..8c18705ea5 100644--- a/specs/backend-management.md+++ b/specs/backend-management.md@@ -9,4 +9,7 @@- [x] Switching backends shall redirect to the same section but on the new backend. The user shall never see stale data from the previous backend.### BM-003: Fallback on active backend removal-- [x] Removing the currently active backend shall fall back to a remaining local backend. The user shall never be left without an active backend.\ No newline at end of file+- [x] Removing the currently active backend shall fall back to a remaining local backend. The user shall never be left without an active backend.++### BM-004: Theme-aware connection feedback+- [x] Connection errors, disabled-backend diagnostics, and connected/disconnected status text shall use the host-overridable feedback roles in all five themes. Small feedback text shall remain readable on its actual surface, including tinted error panels.diff --git a/src/components/features/backends/api-key-entry-screen.tsx b/src/components/features/backends/api-key-entry-screen.tsxindex cc346fb270..b5326023f6 100644--- a/src/components/features/backends/api-key-entry-screen.tsx+++ b/src/components/features/backends/api-key-entry-screen.tsx@@ -118,8 +118,8 @@ export default function ApiKeyEntryScreen() {data-testid={`${testIdRoot}-status`}className={connectionStatus === "error"- ? "text-red-400"- : "text-green-400"+ ? "text-feedback-error"+ : "text-feedback-success"}>{connectionStatus === "error"diff --git a/src/components/features/backends/backend-form-modal.tsx b/src/components/features/backends/backend-form-modal.tsxindex 5ba1a532b7..269ff3531f 100644--- a/src/components/features/backends/backend-form-modal.tsx+++ b/src/components/features/backends/backend-form-modal.tsx@@ -267,12 +267,13 @@ function BackendStatusBadge({) : null}</div>+ {/* @spec BM-004 β Theme-aware backend connection feedback */}{disabled ? (<divdata-testid={`${testIdRoot}-status-error`}- className="flex flex-col gap-1 rounded-md border border-red-500/40 bg-red-500/10 p-3 text-sm"+ className="flex flex-col gap-1 rounded-md border border-semantic-danger/40 bg-semantic-danger/5 p-3 text-sm">- <span className="font-semibold text-red-300">+ <span className="font-semibold text-feedback-error">{t(I18nKey.BACKEND$HEALTH_FAILED_TITLE)}</span><span className="text-xs text-text-tertiary">@@ -283,7 +284,7 @@ function BackendStatusBadge({{lastError ? (<spandata-testid={`${testIdRoot}-status-error-message`}- className="text-xs text-red-300 whitespace-pre-wrap break-words"+ className="text-xs text-feedback-error whitespace-pre-wrap break-words">{lastError}</span>@@ -658,7 +659,7 @@ export function BackendForm({<divrole="alert"data-testid={`${testIdRoot}-error`}- className="rounded-md border border-red-500/40 bg-red-500/10 p-3 text-sm text-red-300 whitespace-pre-wrap break-words"+ className="rounded-md border border-semantic-danger/40 bg-semantic-danger/5 p-3 text-sm text-feedback-error whitespace-pre-wrap break-words">{connectionError}</div>@@ -928,7 +929,7 @@ function ManualConnectionColumn({<divrole="alert"data-testid={`${testIdRoot}-error`}- className="rounded-md border border-red-500/40 bg-red-500/10 p-3 text-sm text-red-300 whitespace-pre-wrap break-words"+ className="rounded-md border border-semantic-danger/40 bg-semantic-danger/5 p-3 text-sm text-feedback-error whitespace-pre-wrap break-words">{connectionError}</div>diff --git a/src/components/features/backends/backend-row.tsx b/src/components/features/backends/backend-row.tsxindex b03b023eb9..de4b49d90d 100644--- a/src/components/features/backends/backend-row.tsx+++ b/src/components/features/backends/backend-row.tsx@@ -54,9 +54,9 @@ export function BackendRow({: getBackendStatusLabel(t, backend, health);const statusClassName =health?.isConnected === true- ? "text-green-300"+ ? "text-feedback-success": health?.isConnected === false- ? "text-red-300"+ ? "text-feedback-error": "text-muted";const dotStatus = isInvalidApiKey ? false : (health?.isConnected ?? null);const lockedCloudHost = getLockedCloudHost();@@ -113,7 +113,7 @@ export function BackendRow({<spandata-testid={`manage-backends-status-detail-${backend.name}`}title={statusDetail}- className="text-xs text-red-300/80 whitespace-normal break-words"+ className="text-xs text-feedback-error whitespace-normal break-words">{statusDetail}</span>diff --git a/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts b/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.tsindex b432538107..39d5cefd6d 100644--- a/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts+++ b/tests/e2e/mock-llm/regressions/mock-llm-ui-regressions.spec.ts@@ -416,6 +416,40 @@ test.describe("UI regressions", () => {expect(probeStyles.outsideBackground).toBe("rgba(0, 0, 0, 0)");});+ // @spec BM-004 β Backend feedback consumes the embedding host's theme roles+ test("backend connection feedback follows host color overrides", async ({+ page,+ }) => {+ await routeSessionApiKey(page);+ await page.goto("/", { waitUntil: "domcontentloaded" });+ const shell = page.locator("[data-agent-server-ui]").first();+ await expect(shell).toBeVisible();+ await shell.evaluate((el) => {+ const scope = el as HTMLElement;+ scope.style.setProperty("--oh-feedback-error", "#8b1029");+ scope.style.setProperty("--oh-feedback-success", "#17642f");+ });++ await page.getByTestId("backend-selector").click();+ await page.getByTestId("manage-backends-menu-item").click();+ await expect(page.getByTestId("manage-backends-status-Local")).toHaveCSS(+ "color",+ "rgb(23, 100, 47)",+ );+ await page.getByTestId("manage-backends-done").click();++ await page.getByTestId("backend-selector").click();+ await page.getByTestId("add-backend-menu-item").click();+ await page.getByTestId("add-backend-option-agent-server").click();+ await page.getByTestId("add-backend-name").fill("Unavailable server");+ await page.getByTestId("add-backend-host").fill("http://127.0.0.1:9");+ await page.getByTestId("add-backend-submit").click();+ await expect(page.getByTestId("add-backend-error")).toHaveCSS(+ "color",+ "rgb(139, 16, 41)",+ );+ });+// ββ critic result rendering ββββββββββββββββββββββββββββββββββββββtest("renders critic results on agent messages and finish actions", async ({