π OpenHands: AI-Driven Development
Add typing to session directory (#8339)
Graham Neubig3eb0afa1e5fa
diff --git a/openhands/server/session/agent_session.py b/openhands/server/session/agent_session.pyindex 4cb2dd6dee..5572ee56fc 100644--- a/openhands/server/session/agent_session.py+++ b/openhands/server/session/agent_session.py@@ -58,7 +58,7 @@ class AgentSession:file_store: FileStore,status_callback: Callable | None = None,user_id: str | None = None,- ):+ ) -> None:"""Initializes a new instance of the Session classParameters:@@ -89,7 +89,7 @@ class AgentSession:selected_branch: str | None = None,initial_message: MessageAction | None = None,replay_json: str | None = None,- ):+ ) -> None:"""Starts the Agent sessionParameters:- runtime_name: The name of the runtime associated with the session@@ -188,7 +188,7 @@ class AgentSession:},)- async def close(self):+ async def close(self) -> None:"""Closes the Agent session"""if self._closed:return@@ -245,7 +245,7 @@ class AgentSession:assert isinstance(replay_events[0], MessageAction)return replay_events[0]- def _create_security_analyzer(self, security_analyzer: str | None):+ def _create_security_analyzer(self, security_analyzer: str | None) -> None:"""Creates a SecurityAnalyzer instance that will be used to analyze the agent actionsParameters:diff --git a/openhands/server/session/conversation.py b/openhands/server/session/conversation.pyindex b827996e4c..32915ecb10 100644--- a/openhands/server/session/conversation.py+++ b/openhands/server/session/conversation.py@@ -38,10 +38,10 @@ class Conversation:headless_mode=False,)- async def connect(self):+ async def connect(self) -> None:await self.runtime.connect()- async def disconnect(self):+ async def disconnect(self) -> None:if self.event_stream:self.event_stream.close()asyncio.create_task(call_sync_from_async(self.runtime.close))diff --git a/openhands/server/session/session.py b/openhands/server/session/session.pyindex 58a75032f2..d53bbb0033 100644--- a/openhands/server/session/session.py+++ b/openhands/server/session/session.py@@ -73,7 +73,7 @@ class Session:self.loop = asyncio.get_event_loop()self.user_id = user_id- async def close(self):+ async def close(self) -> None:if self.sio:await self.sio.emit('oh_event',@@ -90,7 +90,7 @@ class Session:settings: Settings,initial_message: MessageAction | None,replay_json: str | None,- ):+ ) -> None:self.agent_session.event_stream.add_event(AgentStateChangedObservation('', AgentState.LOADING),EventSource.ENVIRONMENT,@@ -195,10 +195,10 @@ class Session:'info', msg_id, f'Retrying LLM request, {retries} / {max}')- def on_event(self, event: Event):+ def on_event(self, event: Event) -> None:asyncio.get_event_loop().run_until_complete(self._on_event(event))- async def _on_event(self, event: Event):+ async def _on_event(self, event: Event) -> None:"""Callback function for events that mainly come from the agent.Event is the base class for any agent action and observation.@@ -236,7 +236,7 @@ class Session:event_dict['source'] = EventSource.AGENTawait self.send(event_dict)- async def dispatch(self, data: dict):+ async def dispatch(self, data: dict) -> None:event = event_from_dict(data.copy())# This checks if the model supports imagesif isinstance(event, MessageAction) and event.image_urls:@@ -254,7 +254,7 @@ class Session:returnself.agent_session.event_stream.add_event(event, EventSource.USER)- async def send(self, data: dict[str, object]):+ async def send(self, data: dict[str, object]) -> None:if asyncio.get_running_loop() != self.loop:self.loop.create_task(self._send(data))return@@ -274,11 +274,11 @@ class Session:self.is_alive = Falsereturn False- async def send_error(self, message: str):+ async def send_error(self, message: str) -> None:"""Sends an error message to the client."""await self.send({'error': True, 'message': message})- async def _send_status_message(self, msg_type: str, id: str, message: str):+ async def _send_status_message(self, msg_type: str, id: str, message: str) -> None:"""Sends a status message to the client."""if msg_type == 'error':agent_session = self.agent_session@@ -293,7 +293,7 @@ class Session:{'status_update': True, 'type': msg_type, 'id': id, 'message': message})- def queue_status_message(self, msg_type: str, id: str, message: str):+ def queue_status_message(self, msg_type: str, id: str, message: str) -> None:"""Queues a status message to be sent asynchronously."""asyncio.run_coroutine_threadsafe(self._send_status_message(msg_type, id, message), self.loop