π OpenHands: AI-Driven Development
feat: show export trajectory button in SaaS mode for debugging (#9979)
Xingyao Wang3f395e3cee8c
diff --git a/frontend/__tests__/components/feedback-actions.test.tsx b/frontend/__tests__/components/feedback-actions.test.tsxindex ad61901729..c1a22558e0 100644--- a/frontend/__tests__/components/feedback-actions.test.tsx+++ b/frontend/__tests__/components/feedback-actions.test.tsx@@ -73,4 +73,73 @@ describe("TrajectoryActions", () => {expect(onExportTrajectory).toHaveBeenCalled();});++ describe("SaaS mode", () => {+ it("should only render export button when isSaasMode is true", () => {+ renderWithProviders(+ <TrajectoryActions+ onPositiveFeedback={onPositiveFeedback}+ onNegativeFeedback={onNegativeFeedback}+ onExportTrajectory={onExportTrajectory}+ isSaasMode={true}+ />,+ );++ const actions = screen.getByTestId("feedback-actions");++ // Should not render feedback buttons in SaaS mode+ expect(within(actions).queryByTestId("positive-feedback")).toBeNull();+ expect(within(actions).queryByTestId("negative-feedback")).toBeNull();++ // Should still render export button+ within(actions).getByTestId("export-trajectory");+ });++ it("should render all buttons when isSaasMode is false", () => {+ renderWithProviders(+ <TrajectoryActions+ onPositiveFeedback={onPositiveFeedback}+ onNegativeFeedback={onNegativeFeedback}+ onExportTrajectory={onExportTrajectory}+ isSaasMode={false}+ />,+ );++ const actions = screen.getByTestId("feedback-actions");+ within(actions).getByTestId("positive-feedback");+ within(actions).getByTestId("negative-feedback");+ within(actions).getByTestId("export-trajectory");+ });++ it("should render all buttons when isSaasMode is undefined (default behavior)", () => {+ renderWithProviders(+ <TrajectoryActions+ onPositiveFeedback={onPositiveFeedback}+ onNegativeFeedback={onNegativeFeedback}+ onExportTrajectory={onExportTrajectory}+ />,+ );++ const actions = screen.getByTestId("feedback-actions");+ within(actions).getByTestId("positive-feedback");+ within(actions).getByTestId("negative-feedback");+ within(actions).getByTestId("export-trajectory");+ });++ it("should call onExportTrajectory when export button is clicked in SaaS mode", async () => {+ renderWithProviders(+ <TrajectoryActions+ onPositiveFeedback={onPositiveFeedback}+ onNegativeFeedback={onNegativeFeedback}+ onExportTrajectory={onExportTrajectory}+ isSaasMode={true}+ />,+ );++ const exportButton = screen.getByTestId("export-trajectory");+ await user.click(exportButton);++ expect(onExportTrajectory).toHaveBeenCalled();+ });+ });});diff --git a/frontend/src/components/features/chat/chat-interface.tsx b/frontend/src/components/features/chat/chat-interface.tsxindex 23c7dc9992..2752620bbb 100644--- a/frontend/src/components/features/chat/chat-interface.tsx+++ b/frontend/src/components/features/chat/chat-interface.tsx@@ -232,17 +232,16 @@ export function ChatInterface() {<div className="flex flex-col gap-[6px] px-4 pb-4"><div className="flex justify-between relative">- {config?.APP_MODE !== "saas" && (- <TrajectoryActions- onPositiveFeedback={() =>- onClickShareFeedbackActionButton("positive")- }- onNegativeFeedback={() =>- onClickShareFeedbackActionButton("negative")- }- onExportTrajectory={() => onClickExportTrajectoryButton()}- />- )}+ <TrajectoryActions+ onPositiveFeedback={() =>+ onClickShareFeedbackActionButton("positive")+ }+ onNegativeFeedback={() =>+ onClickShareFeedbackActionButton("negative")+ }+ onExportTrajectory={() => onClickExportTrajectoryButton()}+ isSaasMode={config?.APP_MODE === "saas"}+ /><div className="absolute left-1/2 transform -translate-x-1/2 bottom-0">{curAgentState === AgentState.RUNNING && <TypingIndicator />}diff --git a/frontend/src/components/features/trajectory/trajectory-actions.tsx b/frontend/src/components/features/trajectory/trajectory-actions.tsxindex adb14fee66..0da8752ffe 100644--- a/frontend/src/components/features/trajectory/trajectory-actions.tsx+++ b/frontend/src/components/features/trajectory/trajectory-actions.tsx@@ -9,29 +9,35 @@ interface TrajectoryActionsProps {onPositiveFeedback: () => void;onNegativeFeedback: () => void;onExportTrajectory: () => void;+ isSaasMode?: boolean;}export function TrajectoryActions({onPositiveFeedback,onNegativeFeedback,onExportTrajectory,+ isSaasMode = false,}: TrajectoryActionsProps) {const { t } = useTranslation();return (<div data-testid="feedback-actions" className="flex gap-1">- <TrajectoryActionButton- testId="positive-feedback"- onClick={onPositiveFeedback}- icon={<ThumbsUpIcon width={15} height={15} />}- tooltip={t(I18nKey.BUTTON$MARK_HELPFUL)}- />- <TrajectoryActionButton- testId="negative-feedback"- onClick={onNegativeFeedback}- icon={<ThumbDownIcon width={15} height={15} />}- tooltip={t(I18nKey.BUTTON$MARK_NOT_HELPFUL)}- />+ {!isSaasMode && (+ <>+ <TrajectoryActionButton+ testId="positive-feedback"+ onClick={onPositiveFeedback}+ icon={<ThumbsUpIcon width={15} height={15} />}+ tooltip={t(I18nKey.BUTTON$MARK_HELPFUL)}+ />+ <TrajectoryActionButton+ testId="negative-feedback"+ onClick={onNegativeFeedback}+ icon={<ThumbDownIcon width={15} height={15} />}+ tooltip={t(I18nKey.BUTTON$MARK_NOT_HELPFUL)}+ />+ </>+ )}<TrajectoryActionButtontestId="export-trajectory"onClick={onExportTrajectory}