π OpenHands: AI-Driven Development
fix: hide Change Agent button on home page chat input (#798)
Hiep Le41e5281509f3
diff --git a/__tests__/components/features/chat/components/chat-input-actions.test.tsx b/__tests__/components/features/chat/components/chat-input-actions.test.tsxindex fa75384d62..fdf0264394 100644--- a/__tests__/components/features/chat/components/chat-input-actions.test.tsx+++ b/__tests__/components/features/chat/components/chat-input-actions.test.tsx@@ -159,4 +159,20 @@ describe("ChatInputActions", () => {expect(screen.getByTestId("change-agent-button-stub")).toBeInTheDocument();});++ it("hides the Change Agent button on the home page on a cloud backend", () => {+ setRegisteredBackends([cloudBackend]);+ setActiveSelection({ backendId: cloudBackend.id });++ renderWithProviders(+ <ActiveBackendProvider>+ <ChatInputActions disabled={false} />+ </ActiveBackendProvider>,+ { navigation: { conversationId: null } },+ );++ expect(+ screen.queryByTestId("change-agent-button-stub"),+ ).not.toBeInTheDocument();+ });});diff --git a/src/components/features/chat/components/chat-input-actions.tsx b/src/components/features/chat/components/chat-input-actions.tsxindex b50e7ac425..a44ead5795 100644--- a/src/components/features/chat/components/chat-input-actions.tsx+++ b/src/components/features/chat/components/chat-input-actions.tsx@@ -74,6 +74,10 @@ export function ChatInputActions({? (labelForAcpModel(conversation?.acp_server, conversation?.llm_model) ??conversation?.llm_model): conversation?.llm_model;+ // The change-agent button can never be enabled on the home page (no+ // conversation β no WebSocket β permanently disabled), so hide it there+ // entirely. It is still shown inside a conversation on cloud backends.+ const showChangeAgentButton = isCloud && Boolean(conversationId);const webSocketStatus = useUnifiedWebSocketStatus();const { curAgentState } = useAgentState();const { conversationMode, setConversationMode } = useConversationStore();@@ -111,7 +115,7 @@ export function ChatInputActions({!rightEl ||!addEl ||!modelEl ||- (isCloud && !codeEl) ||+ (showChangeAgentButton && !codeEl) ||typeof ResizeObserver === "undefined") {return;@@ -149,7 +153,7 @@ export function ChatInputActions({syncWidths();return () => observer.disconnect();- }, [isCloud]);+ }, [showChangeAgentButton]);const handlePauseAgent = () => {if (!conversationId) return;@@ -176,7 +180,7 @@ export function ChatInputActions({showModelInline: false,};- if (isCloud && remaining >= codeWidth) {+ if (showChangeAgentButton && remaining >= codeWidth) {next.showCodeInline = true;remaining -= codeWidth + INLINE_GAP;}@@ -187,7 +191,7 @@ export function ChatInputActions({return next;},- [isCloud, codeWidth, modelWidth],+ [showChangeAgentButton, codeWidth, modelWidth],);const leftBaseWidth =@@ -195,20 +199,24 @@ export function ChatInputActions({const fitWithoutOverflow = fitOptionalItems(leftBaseWidth);const allOptionalFit =- (!isCloud || fitWithoutOverflow.showCodeInline) &&+ (!showChangeAgentButton || fitWithoutOverflow.showCodeInline) &&fitWithoutOverflow.showModelInline;const fitWithOverflow = allOptionalFit? fitWithoutOverflow: fitOptionalItems(leftBaseWidth - OVERFLOW_BUTTON_WIDTH - INLINE_GAP);- const showCodeInline = !isCloud ? false : fitWithOverflow.showCodeInline;+ const showCodeInline = !showChangeAgentButton+ ? false+ : fitWithOverflow.showCodeInline;const showModelInline = fitWithOverflow.showModelInline;const showAddFileInline = true;const showAgentStatusInline = actionsRowWidth >= 360;const hasOverflowItems =- !showAddFileInline || (isCloud && !showCodeInline) || !showModelInline;+ !showAddFileInline ||+ (showChangeAgentButton && !showCodeInline) ||+ !showModelInline;React.useEffect(() => {if (!hasOverflowItems) {@@ -269,7 +277,7 @@ export function ChatInputActions({alignment="left"className="!static !top-auto !bottom-auto !left-auto !right-auto !mt-0 overflow-visible min-w-[200px]">- {isCloud && !showCodeInline && (+ {showChangeAgentButton && !showCodeInline && (<div className="relative group/overflow-agent"><ContextMenuListItemtestId="overflow-agent-button"@@ -417,7 +425,7 @@ export function ChatInputActions({handleFileIconClick={onAddFileClick}/></div>- {isCloud && (+ {showChangeAgentButton && (<div ref={codeRef} className={cn(!showCodeInline && "hidden")}><ChangeAgentButton /></div>