🙌 OpenHands: AI-Driven Development
fix: route hardcoded UI strings through i18n (#1306)
Hiep Le44dadb7ee267
diff --git a/__tests__/components/features/settings/settings-navigation.test.tsx b/__tests__/components/features/settings/settings-navigation.test.tsxindex 4ce3b4a70a..fcb2b9ac7f 100644--- a/__tests__/components/features/settings/settings-navigation.test.tsx+++ b/__tests__/components/features/settings/settings-navigation.test.tsx@@ -84,7 +84,7 @@ describe("SettingsNavigation", () => {);await userEvent.click(- screen.getByRole("button", { name: /close navigation menu/i }),+ screen.getByRole("button", { name: "SIDEBAR$CLOSE_MENU" }),);expect(onCloseMobileMenu).toHaveBeenCalledTimes(1);diff --git a/src/components/features/chat/chat-interface.tsx b/src/components/features/chat/chat-interface.tsxindex a80ed51ce0..131c089c08 100644--- a/src/components/features/chat/chat-interface.tsx+++ b/src/components/features/chat/chat-interface.tsx@@ -358,7 +358,7 @@ export function ChatInterface() {const sendErrorMessage =sendError instanceof Error? sendError.message- : "Failed to send message";+ : t(I18nKey.CHAT_INTERFACE$FAILED_TO_SEND_MESSAGE);markPendingMessageError(pendingId, sendErrorMessage);}};diff --git a/src/components/features/chat/git-control-bar.tsx b/src/components/features/chat/git-control-bar.tsxindex 94f846f6d1..cda4b3fda3 100644--- a/src/components/features/chat/git-control-bar.tsx+++ b/src/components/features/chat/git-control-bar.tsx@@ -193,7 +193,9 @@ export function GitControlBar({ onSuggestionsClick }: GitControlBarProps) {).catch((error) => {if (!pendingId) return;const errorMessage =- error instanceof Error ? error.message : "Failed to send message";+ error instanceof Error+ ? error.message+ : t(I18nKey.CHAT_INTERFACE$FAILED_TO_SEND_MESSAGE);markPendingMessageError(pendingId, errorMessage);});},diff --git a/src/components/features/chat/open-repository-modal.tsx b/src/components/features/chat/open-repository-modal.tsxindex 7702708c95..c2994e94f1 100644--- a/src/components/features/chat/open-repository-modal.tsx+++ b/src/components/features/chat/open-repository-modal.tsx@@ -116,7 +116,6 @@ export function OpenRepositoryModal({<GitProviderDropdownproviders={providers}value={selectedProvider}- placeholder="Select Provider"onChange={handleProviderChange}/>)}@@ -128,7 +127,6 @@ export function OpenRepositoryModal({value={selectedRepository?.id || null}repositoryName={selectedRepository?.full_name || null}onChange={handleRepositoryChange}- placeholder="Search repositories..."className="w-full"/>@@ -138,7 +136,6 @@ export function OpenRepositoryModal({selectedBranch={selectedBranch}onBranchSelect={handleBranchSelect}defaultBranch={selectedRepository?.main_branch || null}- placeholder="Select branch..."disabled={!selectedRepository}className="w-full"/>diff --git a/src/components/features/chat/pending-user-messages.tsx b/src/components/features/chat/pending-user-messages.tsxindex e9ccc1985b..c710f69116 100644--- a/src/components/features/chat/pending-user-messages.tsx+++ b/src/components/features/chat/pending-user-messages.tsx@@ -1,4 +1,6 @@import React from "react";+import { useTranslation } from "react-i18next";+import { I18nKey } from "#/i18n/declaration";import { useOptimisticUserMessageStore } from "#/stores/optimistic-user-message-store";import { useConversationStore } from "#/stores/conversation-store";import { useSendMessage } from "#/hooks/use-send-message";@@ -21,6 +23,7 @@ import { ChatMessage } from "./chat-message";* bubbles over.*/export function PendingUserMessages() {+ const { t } = useTranslation("openhands");const { conversationId } = useOptionalConversationId();const pendingMessages = useOptimisticUserMessageStore((state) => state.pendingMessages,@@ -72,11 +75,13 @@ export function PendingUserMessages() {);} catch (error) {const errorMessage =- error instanceof Error ? error.message : "Failed to send message";+ error instanceof Error+ ? error.message+ : t(I18nKey.CHAT_INTERFACE$FAILED_TO_SEND_MESSAGE);markPendingMessageError(id, errorMessage);}},- [send, markPendingMessageError, markPendingMessageSending],+ [send, markPendingMessageError, markPendingMessageSending, t],);const handleStop = React.useCallback(diff --git a/src/components/features/home/git-branch-dropdown/git-branch-dropdown.tsx b/src/components/features/home/git-branch-dropdown/git-branch-dropdown.tsxindex 8b76d97437..9af809bc15 100644--- a/src/components/features/home/git-branch-dropdown/git-branch-dropdown.tsx+++ b/src/components/features/home/git-branch-dropdown/git-branch-dropdown.tsx@@ -6,8 +6,10 @@ import React, {useEffect,} from "react";import { useCombobox } from "downshift";+import { useTranslation } from "react-i18next";import { Branch } from "#/types/git";import { Provider } from "#/types/settings";+import { I18nKey } from "#/i18n/declaration";import { useDebounce } from "#/hooks/use-debounce";import { cn } from "#/utils/utils";import { formControlFieldClassName } from "#/utils/form-control-classes";@@ -36,10 +38,11 @@ export function GitBranchDropdown({selectedBranch,onBranchSelect,defaultBranch,- placeholder = "Select branch...",+ placeholder,disabled = false,className,}: GitBranchDropdownProps) {+ const { t } = useTranslation("openhands");const [inputValue, setInputValue] = useState("");const [userManuallyCleared, setUserManuallyCleared] = useState(false);const debouncedInputValue = useDebounce(inputValue, 300);@@ -195,7 +198,8 @@ export function GitBranchDropdown({<input{...getInputProps({disabled: disabled || !repository,- placeholder,+ placeholder:+ placeholder ?? t(I18nKey.COMMON$SELECT_BRANCH_PLACEHOLDER),className: cn(formControlFieldClassName,"text-inherit shadow-none pl-7 pr-16 text-sm font-normal leading-5",diff --git a/src/components/features/home/git-provider-dropdown/git-provider-dropdown.tsx b/src/components/features/home/git-provider-dropdown/git-provider-dropdown.tsxindex a4b61ea609..c22ca7ed87 100644--- a/src/components/features/home/git-provider-dropdown/git-provider-dropdown.tsx+++ b/src/components/features/home/git-provider-dropdown/git-provider-dropdown.tsx@@ -1,6 +1,8 @@import React, { useState, useMemo, useEffect } from "react";import { useCombobox } from "downshift";+import { useTranslation } from "react-i18next";import { Provider } from "#/types/settings";+import { I18nKey } from "#/i18n/declaration";import { cn } from "#/utils/utils";import { DropdownItem } from "../shared/dropdown-item";import { GenericDropdownMenu } from "../shared/generic-dropdown-menu";@@ -27,7 +29,7 @@ export interface GitProviderDropdownProps {export function GitProviderDropdown({providers,value,- placeholder = "Select Provider",+ placeholder,className,errorMessage,disabled = false,@@ -37,6 +39,7 @@ export function GitProviderDropdown({toggleButtonClassName,itemClassName,}: GitProviderDropdownProps) {+ const { t } = useTranslation("openhands");const [inputValue, setInputValue] = useState("");const [localSelectedItem, setLocalSelectedItem] = useState<Provider | null>(value || null,@@ -170,7 +173,8 @@ export function GitProviderDropdown({<input{...getInputProps({disabled,- placeholder,+ placeholder:+ placeholder ?? t(I18nKey.COMMON$SELECT_PROVIDER_PLACEHOLDER),readOnly: true, // Make it non-searchable like the originalclassName: cn("w-29.5 h-6 py-0 border border-[var(--oh-border-input)] rounded shadow-none h-6 min-h-6 max-h-6 ",diff --git a/src/components/features/home/git-repo-dropdown/git-repo-dropdown.tsx b/src/components/features/home/git-repo-dropdown/git-repo-dropdown.tsxindex 3913f0326c..a9061a2ef0 100644--- a/src/components/features/home/git-repo-dropdown/git-repo-dropdown.tsx+++ b/src/components/features/home/git-repo-dropdown/git-repo-dropdown.tsx@@ -40,7 +40,7 @@ export function GitRepoDropdown({provider,value,repositoryName,- placeholder = "Search repositories...",+ placeholder,className,disabled = false,onChange,@@ -298,7 +298,8 @@ export function GitRepoDropdown({<input{...getInputProps({disabled,- placeholder,+ placeholder:+ placeholder ?? t(I18nKey.COMMON$SEARCH_REPOSITORIES_PLACEHOLDER),className: cn(formControlFieldClassName,"text-inherit shadow-none pl-7 pr-16 text-sm font-normal leading-5",diff --git a/src/components/features/home/repo-selection-form.tsx b/src/components/features/home/repo-selection-form.tsxindex 93e415b4bd..a119cb5f1a 100644--- a/src/components/features/home/repo-selection-form.tsx+++ b/src/components/features/home/repo-selection-form.tsx@@ -122,7 +122,6 @@ export function RepositorySelectionForm({<GitProviderDropdownproviders={providers}value={selectedProvider}- placeholder="Select Provider"className="max-w-[500px]"onChange={handleProviderSelection}disabled={isLoadingSettings}@@ -166,7 +165,6 @@ export function RepositorySelectionForm({selectedBranch={selectedBranch}onBranchSelect={handleBranchSelection}defaultBranch={defaultBranch}- placeholder="Select branch..."className="max-w-full"disabled={!selectedRepository || isLoadingSettings}/>@@ -245,7 +243,7 @@ export function RepositorySelectionForm({{onConfirm? t(I18nKey.BUTTON$CONFIRM): !isCreatingConversation- ? "Launch"+ ? t(I18nKey.BUTTON$LAUNCH): t(I18nKey.HOME$LOADING)}</BrandButton></div>diff --git a/src/components/features/home/workspace-selection-form.tsx b/src/components/features/home/workspace-selection-form.tsxindex 84d6a28455..613eddf126 100644--- a/src/components/features/home/workspace-selection-form.tsx+++ b/src/components/features/home/workspace-selection-form.tsx@@ -228,7 +228,7 @@ export function WorkspaceSelectionForm({{onConfirm? t(I18nKey.BUTTON$CONFIRM): !isCreatingConversation- ? "Launch"+ ? t(I18nKey.BUTTON$LAUNCH): t(I18nKey.HOME$LOADING)}</BrandButton>diff --git a/src/components/features/settings/settings-navigation.tsx b/src/components/features/settings/settings-navigation.tsxindex 02bb33c087..314ba283e9 100644--- a/src/components/features/settings/settings-navigation.tsx+++ b/src/components/features/settings/settings-navigation.tsx@@ -116,7 +116,7 @@ export function SettingsMobileDrawer({"cursor-pointer rounded-md p-0.5 hover:bg-tertiary md:hidden",navInteractiveTransitionClassName,)}- aria-label="Close navigation menu"+ aria-label={t(I18nKey.SIDEBAR$CLOSE_MENU)}><CloseIcon width={32} height={32} /></button>diff --git a/src/components/features/sidebar/sidebar.tsx b/src/components/features/sidebar/sidebar.tsxindex 677830ef83..fa053b5f2e 100644--- a/src/components/features/sidebar/sidebar.tsx+++ b/src/components/features/sidebar/sidebar.tsx@@ -120,9 +120,7 @@ export function Sidebar() {) {// We don't show toast errors for settings in the global error handler// because we have a special case for 404 errors- displayErrorToast(- "Something went wrong while fetching settings. Please reload the page.",- );+ displayErrorToast(t(I18nKey.SETTINGS$FETCH_ERROR));} else if (settingsErrorStatus === 404 &&!config?.feature_flags?.hide_llm_settings@@ -135,6 +133,7 @@ export function Sidebar() {settingsIsError,settingsErrorStatus,config?.feature_flags?.hide_llm_settings,+ t,]);const linkDisabled = settings?.email_verified === false;diff --git a/src/i18n/translation.json b/src/i18n/translation.jsonindex dbc0c151df..1373cbdeb0 100644--- a/src/i18n/translation.json+++ b/src/i18n/translation.json@@ -30343,5 +30343,90 @@"de": "Sonstiges:","uk": "Інше:","ca": "Altres:"+ },+ "COMMON$SELECT_PROVIDER_PLACEHOLDER": {+ "en": "Select Provider",+ "ja": "プロバイダーを選択",+ "zh-CN": "选择提供商",+ "zh-TW": "選擇供應商",+ "ko-KR": "제공자 선택",+ "no": "Velg leverandør",+ "it": "Seleziona provider",+ "pt": "Selecionar provedor",+ "es": "Seleccionar proveedor",+ "ar": "اختر المزود",+ "fr": "Sélectionner un fournisseur",+ "tr": "Sağlayıcı seçin",+ "de": "Anbieter auswählen",+ "uk": "Виберіть постачальника",+ "ca": "Selecciona el proveïdor"+ },+ "COMMON$SEARCH_REPOSITORIES_PLACEHOLDER": {+ "en": "Search repositories...",+ "ja": "リポジトリを検索...",+ "zh-CN": "搜索仓库...",+ "zh-TW": "搜尋存儲庫...",+ "ko-KR": "저장소 검색...",+ "no": "Søk i repositories...",+ "it": "Cerca repository...",+ "pt": "Pesquisar repositórios...",+ "es": "Buscar repositorios...",+ "ar": "البحث في المستودعات...",+ "fr": "Rechercher des dépôts...",+ "tr": "Depo ara...",+ "de": "Repositorys durchsuchen...",+ "uk": "Пошук репозиторіїв...",+ "ca": "Cerca repositoris..."+ },+ "COMMON$SELECT_BRANCH_PLACEHOLDER": {+ "en": "Select branch...",+ "ja": "ブランチを選択...",+ "zh-CN": "选择分支...",+ "zh-TW": "選擇分支...",+ "ko-KR": "브랜치 선택...",+ "no": "Velg gren...",+ "it": "Seleziona un ramo...",+ "pt": "Selecionar um branch...",+ "es": "Seleccionar una rama...",+ "ar": "اختر فرعًا...",+ "fr": "Sélectionner une branche...",+ "tr": "Bir dal seçin...",+ "de": "Branch auswählen...",+ "uk": "Виберіть гілку...",+ "ca": "Selecciona una branca..."+ },+ "CHAT_INTERFACE$FAILED_TO_SEND_MESSAGE": {+ "en": "Failed to send message",+ "ja": "メッセージの送信に失敗しました",+ "zh-CN": "消息发送失败",+ "zh-TW": "訊息傳送失敗",+ "ko-KR": "메시지 전송에 실패했습니다",+ "no": "Kunne ikke sende meldingen",+ "it": "Invio del messaggio non riuscito",+ "pt": "Falha ao enviar a mensagem",+ "es": "Error al enviar el mensaje",+ "ar": "فشل إرسال الرسالة",+ "fr": "Échec de l'envoi du message",+ "tr": "Mesaj gönderilemedi",+ "de": "Nachricht konnte nicht gesendet werden",+ "uk": "Не вдалося надіслати повідомлення",+ "ca": "No s'ha pogut enviar el missatge"+ },+ "SETTINGS$FETCH_ERROR": {+ "en": "Something went wrong while fetching settings. Please reload the page.",+ "ja": "設定の取得中に問題が発生しました。ページを再読み込みしてください。",+ "zh-CN": "获取设置时出现问题。请重新加载页面。",+ "zh-TW": "取得設定時發生問題。請重新載入頁面。",+ "ko-KR": "설정을 가져오는 중 문제가 발생했습니다. 페이지를 새로고침해 주세요.",+ "no": "Noe gikk galt under henting av innstillingene. Vennligst last inn siden på nytt.",+ "it": "Si è verificato un errore durante il recupero delle impostazioni. Ricarica la pagina.",+ "pt": "Ocorreu um erro ao buscar as configurações. Por favor, recarregue a página.",+ "es": "Algo salió mal al obtener la configuración. Por favor, recargue la página.",+ "ar": "حدث خطأ أثناء جلب الإعدادات. يرجى إعادة تحميل الصفحة.",+ "fr": "Une erreur s'est produite lors de la récupération des paramètres. Veuillez recharger la page.",+ "tr": "Ayarlar alınırken bir sorun oluştu. Lütfen sayfayı yenileyin.",+ "de": "Beim Abrufen der Einstellungen ist ein Fehler aufgetreten. Bitte laden Sie die Seite neu.",+ "uk": "Під час отримання налаштувань сталася помилка. Будь ласка, перезавантажте сторінку.",+ "ca": "S'ha produït un error en obtenir la configuració. Torneu a carregar la pàgina."}}