🙌 OpenHands: AI-Driven Development
docs: strengthen code review evidence policy (#17089)
Graham Neubig4524a919930d
diff --git a/.agents/skills/custom-codereview-guide.md b/.agents/skills/custom-codereview-guide.mdindex d0e7f2fdb7..da2c0bd1bd 100644--- a/.agents/skills/custom-codereview-guide.md+++ b/.agents/skills/custom-codereview-guide.md@@ -147,8 +147,18 @@ identity.- Require evidence proportional to the behavior changed. For UI behavior, use ascreenshot or video from the real app. For CLI, API, or scripts, require the- exact runtime command and observed result. Unit tests alone are not end-to-end- evidence.+ exact runtime command and observed result.+- Runtime and user-visible bug fixes require before-and-after evidence through+ the real production-facing path. The before evidence must reproduce the bug on+ the base branch or released version; the after evidence must repeat the same+ setup on the PR head and show the corrected behavior. Include exact commands,+ relevant output, and screenshots or video when the behavior is visual.+- For lifecycle fixes, evidence must also verify the resulting process or resource+ state—for example, the parent exit code and whether child services or listening+ ports remain after shutdown.+- Unit and integration tests are regression proof, not a substitute for live+ evidence. If required live evidence is missing, submit **COMMENT**, not+ **APPROVE**, and identify the exact production-facing verification still needed.- Prefer tests that exercise real logic and observable state. Do not reward mocksthat only prove another mock was called.- Keep tests focused: one meaningful assertion path per behavior, no duplicated@@ -158,6 +168,14 @@ identity.label when appropriate.- Never broaden live E2E triggers or secret exposure for convenience.+## Review Context Integrity++Before submitting the review, compare its summary and every finding against the+current PR title, changed-file manifest, linked issues, and acceptance criteria.+If the review describes files, behavior, issues, or release paths that are not in+that context, stop and re-read the PR rather than submitting stale or mismatched+feedback. Do not approve until this final context check passes.+## What Not to Comment OnDo not leave review comments for: