π OpenHands: AI-Driven Development
fix: wrap description in badge to match LLM Settings styling (#303)
Hiep Le4acc38da4d4f
diff --git a/__tests__/routes/skills-settings.test.tsx b/__tests__/routes/skills-settings.test.tsxnew file mode 100644index 0000000000..41f6a92cd5--- /dev/null+++ b/__tests__/routes/skills-settings.test.tsx@@ -0,0 +1,54 @@+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";+import { render, screen } from "@testing-library/react";+import { beforeEach, describe, expect, it, vi } from "vitest";+import SkillsSettingsScreen from "#/routes/skills-settings";+import SettingsService from "#/api/settings-service/settings-service.api";+import SkillsService from "#/api/skills-service";+import { MOCK_DEFAULT_USER_SETTINGS } from "#/mocks/handlers";+import { Settings } from "#/types/settings";+import { ActiveBackendProvider } from "#/contexts/active-backend-context";++function buildSettings(overrides: Partial<Settings> = {}): Settings {+ return {+ ...MOCK_DEFAULT_USER_SETTINGS,+ ...overrides,+ agent_settings: {+ ...MOCK_DEFAULT_USER_SETTINGS.agent_settings,+ ...overrides.agent_settings,+ },+ };+}++function renderSkillsSettingsScreen() {+ return render(<SkillsSettingsScreen />, {+ wrapper: ({ children }) => (+ <QueryClientProvider+ client={+ new QueryClient({+ defaultOptions: { queries: { retry: false } },+ })+ }+ >+ <ActiveBackendProvider>{children}</ActiveBackendProvider>+ </QueryClientProvider>+ ),+ });+}++describe("SkillsSettingsScreen", () => {+ beforeEach(() => {+ vi.restoreAllMocks();+ });++ it("renders the description text inside the description badge", async () => {+ vi.spyOn(SettingsService, "getSettings").mockResolvedValue(buildSettings());+ vi.spyOn(SkillsService, "getSkills").mockResolvedValue([]);++ renderSkillsSettingsScreen();++ const badge = await screen.findByTestId(+ "skills-settings-description-badge",+ );+ expect(badge).toHaveTextContent("SETTINGS$SKILLS_DESCRIPTION");+ });+});diff --git a/src/routes/skills-settings.tsx b/src/routes/skills-settings.tsxindex 56c41b2d46..4b77ce2ebe 100644--- a/src/routes/skills-settings.tsx+++ b/src/routes/skills-settings.tsx@@ -6,6 +6,8 @@ import { useSkills } from "#/hooks/query/use-skills";import { BrandButton } from "#/components/features/settings/brand-button";import { SettingsSwitch } from "#/components/features/settings/settings-switch";import { I18nKey } from "#/i18n/declaration";+import { Typography } from "#/ui/typography";+import InfoCircleIcon from "#/icons/info-circle.svg?react";import {displayErrorToast,displaySuccessToast,@@ -63,7 +65,15 @@ function SkillsSettingsScreen() {return (<div data-testid="skills-settings-screen" className="flex flex-col h-full">- <p className="text-xs mb-4">{t(I18nKey.SETTINGS$SKILLS_DESCRIPTION)}</p>+ <div+ data-testid="skills-settings-description-badge"+ className="flex items-center gap-2 bg-[rgba(31,31,31,0.4)] border border-[#242424] rounded-full px-2.5 py-1 mt-4 mb-4 self-start"+ >+ <InfoCircleIcon width={12} height={12} className="text-[#8c8c8c]" />+ <Typography.Text className="text-[11px] font-medium text-[#8c8c8c] leading-5">+ {t(I18nKey.SETTINGS$SKILLS_DESCRIPTION)}+ </Typography.Text>+ </div><div className="flex-1 overflow-auto custom-scrollbar-always">{isLoading && (