π OpenHands: AI-Driven Development
Fix CI to check for missing translations (#8486)
Graham Neubig4c38113cb7e9
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.ymlindex 539d265ca5..6a79ac06ed 100644--- a/.github/workflows/lint.yml+++ b/.github/workflows/lint.yml@@ -30,11 +30,12 @@ jobs:run: |cd frontendnpm install --frozen-lockfile- - name: Lint and TypeScript compilation+ - name: Lint, TypeScript compilation, and translation checksrun: |cd frontendnpm run lintnpm run make-i18n && tsc+ npm run check-translation-completeness# Run lint on the python codelint-python:diff --git a/tests/unit/frontend/test_translation_completeness.py b/tests/unit/frontend/test_translation_completeness.pynew file mode 100644index 0000000000..8b6f8666fa--- /dev/null+++ b/tests/unit/frontend/test_translation_completeness.py@@ -0,0 +1,33 @@+"""Test that the translation completeness check works correctly."""++import os+import subprocess+import unittest+++class TestTranslationCompleteness(unittest.TestCase):+ """Test that the translation completeness check works correctly."""++ def test_translation_completeness_check_runs(self):+ """Test that the translation completeness check script can be executed."""+ frontend_dir = os.path.join(os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__)))), "frontend")+ script_path = os.path.join(frontend_dir, "scripts", "check-translation-completeness.cjs")++ # Verify the script exists+ self.assertTrue(os.path.exists(script_path), f"Script not found at {script_path}")++ # Verify the script is executable+ self.assertTrue(os.access(script_path, os.X_OK), f"Script at {script_path} is not executable")++ # Run the script (it may fail due to missing translations, but we just want to verify it runs)+ try:+ subprocess.run(+ ["node", script_path],+ cwd=frontend_dir,+ check=False,+ capture_output=True,+ text=True+ )+ # We don't assert on the return code because it might fail due to missing translations+ except Exception as e:+ self.fail(f"Failed to run translation completeness check: {e}")\ No newline at end of file