Skip to content

🙌 OpenHands: AI-Driven Development

fix(i18n): translate hardcoded settings strings (#14286)

Vasco Schiavo4f8fd0cc5f83
diff --git a/frontend/src/components/features/settings/mcp-settings/mcp-server-form.tsx b/frontend/src/components/features/settings/mcp-settings/mcp-server-form.tsx
index 2e6367896a..f9dbd2345d 100644
--- a/frontend/src/components/features/settings/mcp-settings/mcp-server-form.tsx
+++ b/frontend/src/components/features/settings/mcp-settings/mcp-server-form.tsx
@@ -325,7 +325,7 @@ export function MCPServerForm({
testId="timeout-input"
name="timeout"
type="number"
- label="Timeout (seconds)"
+ label={t(I18nKey.SETTINGS$MCP_TIMEOUT_LABEL)}
className="w-full max-w-[680px]"
showOptionalTag
defaultValue={server?.timeout?.toString() || ""}
diff --git a/frontend/src/i18n/declaration.ts b/frontend/src/i18n/declaration.ts
index 63fba0df8f..fb4ef76858 100644
--- a/frontend/src/i18n/declaration.ts
+++ b/frontend/src/i18n/declaration.ts
@@ -991,6 +991,8 @@ export enum I18nKey {
COMMON$STOPPING = "COMMON$STOPPING",
SETTINGS$GIT_USERNAME = "SETTINGS$GIT_USERNAME",
SETTINGS$GIT_EMAIL = "SETTINGS$GIT_EMAIL",
+ SETTINGS$GIT_USERNAME_PLACEHOLDER = "SETTINGS$GIT_USERNAME_PLACEHOLDER",
+ SETTINGS$GIT_EMAIL_PLACEHOLDER = "SETTINGS$GIT_EMAIL_PLACEHOLDER",
PROJECT_MANAGEMENT$TITLE = "PROJECT_MANAGEMENT$TITLE",
PROJECT_MANAGEMENT$VALIDATE_INTEGRATION_ERROR = "PROJECT_MANAGEMENT$VALIDATE_INTEGRATION_ERROR",
PROJECT_MANAGEMENT$LINK_BUTTON_LABEL = "PROJECT_MANAGEMENT$LINK_BUTTON_LABEL",
@@ -1037,6 +1039,7 @@ export enum I18nKey {
SETTINGS$MCP_ERROR_TIMEOUT_MAX_EXCEEDED = "SETTINGS$MCP_ERROR_TIMEOUT_MAX_EXCEEDED",
SETTINGS$MCP_SERVER_TYPE = "SETTINGS$MCP_SERVER_TYPE",
SETTINGS$MCP_API_KEY_PLACEHOLDER = "SETTINGS$MCP_API_KEY_PLACEHOLDER",
+ SETTINGS$MCP_TIMEOUT_LABEL = "SETTINGS$MCP_TIMEOUT_LABEL",
SETTINGS$MCP_COMMAND_ARGUMENTS = "SETTINGS$MCP_COMMAND_ARGUMENTS",
SETTINGS$MCP_COMMAND_ARGUMENTS_HELP = "SETTINGS$MCP_COMMAND_ARGUMENTS_HELP",
SETTINGS$MCP_ENVIRONMENT_VARIABLES = "SETTINGS$MCP_ENVIRONMENT_VARIABLES",
diff --git a/frontend/src/i18n/translation.json b/frontend/src/i18n/translation.json
index 2f898b4a59..dda9c190db 100644
--- a/frontend/src/i18n/translation.json
+++ b/frontend/src/i18n/translation.json
@@ -16846,6 +16846,40 @@
"uk": "Електронна пошта Git",
"ca": "Correu electrònic de Git"
},
+ "SETTINGS$GIT_USERNAME_PLACEHOLDER": {
+ "en": "Username for git commits",
+ "ja": "Gitコミット用のユーザー名",
+ "zh-CN": "Git提交的用户名",
+ "zh-TW": "Git提交的使用者名稱",
+ "ko-KR": "Git 커밋용 사용자 이름",
+ "no": "Brukernavn for git-commits",
+ "it": "Nome utente per i commit Git",
+ "pt": "Nome de usuário para commits Git",
+ "es": "Nombre de usuario para commits de Git",
+ "ar": "اسم المستخدم لإيداعات Git",
+ "fr": "Nom d'utilisateur pour les commits Git",
+ "tr": "Git commit'leri için kullanıcı adı",
+ "de": "Benutzername für Git-Commits",
+ "uk": "Ім'я користувача для git-комітів",
+ "ca": "Nom d'usuari per als commits de Git"
+ },
+ "SETTINGS$GIT_EMAIL_PLACEHOLDER": {
+ "en": "Email for git commits",
+ "ja": "Gitコミット用のメールアドレス",
+ "zh-CN": "Git提交的电子邮件",
+ "zh-TW": "Git提交的電子郵件",
+ "ko-KR": "Git 커밋용 이메일",
+ "no": "E-post for git-commits",
+ "it": "Email per i commit Git",
+ "pt": "Email para commits Git",
+ "es": "Correo electrónico para commits de Git",
+ "ar": "البريد الإلكتروني لإيداعات Git",
+ "fr": "Email pour les commits Git",
+ "tr": "Git commit'leri için e-posta",
+ "de": "E-Mail für Git-Commits",
+ "uk": "Електронна пошта для git-комітів",
+ "ca": "Correu electrònic per als commits de Git"
+ },
"PROJECT_MANAGEMENT$TITLE": {
"en": "Project Management",
"ja": "プロジェクト管理",
@@ -17628,6 +17662,23 @@
"uk": "Введіть API ключ (необов'язково)",
"ca": "Introduïu la clau d'API (opcional)"
},
+ "SETTINGS$MCP_TIMEOUT_LABEL": {
+ "en": "Timeout (seconds)",
+ "ja": "タイムアウト(秒)",
+ "zh-CN": "超时(秒)",
+ "zh-TW": "超時(秒)",
+ "ko-KR": "타임아웃(초)",
+ "no": "Timeout (sekunder)",
+ "it": "Timeout (secondi)",
+ "pt": "Timeout (segundos)",
+ "es": "Timeout (segundos)",
+ "ar": "المهلة الزمنية (ثوانٍ)",
+ "fr": "Timeout (secondes)",
+ "tr": "Zaman aşımı (saniye)",
+ "de": "Timeout (Sekunden)",
+ "uk": "Таймаут (секунди)",
+ "ca": "Temps d'espera (segons)"
+ },
"SETTINGS$MCP_COMMAND_ARGUMENTS": {
"en": "Command Arguments",
"ja": "コマンド引数",
diff --git a/frontend/src/routes/app-settings.tsx b/frontend/src/routes/app-settings.tsx
index bfba036fc2..7d22165607 100644
--- a/frontend/src/routes/app-settings.tsx
+++ b/frontend/src/routes/app-settings.tsx
@@ -321,7 +321,7 @@ function AppSettingsScreen() {
label={t(I18nKey.SETTINGS$GIT_USERNAME)}
defaultValue={settings.git_user_name || ""}
onChange={checkIfGitUserNameHasChanged}
- placeholder="Username for git commits"
+ placeholder={t(I18nKey.SETTINGS$GIT_USERNAME_PLACEHOLDER)}
className="w-full max-w-[680px]"
/>
<SettingsInput
@@ -331,7 +331,7 @@ function AppSettingsScreen() {
label={t(I18nKey.SETTINGS$GIT_EMAIL)}
defaultValue={settings.git_user_email || ""}
onChange={checkIfGitUserEmailHasChanged}
- placeholder="Email for git commits"
+ placeholder={t(I18nKey.SETTINGS$GIT_EMAIL_PLACEHOLDER)}
className="w-full max-w-[680px]"
/>
</div>