Skip to content

πŸ™Œ OpenHands: AI-Driven Development

refactor: extract automations menu-item-content sub-components (#1378)

Hiep Le56383b650d8e
diff --git a/__tests__/components/automations/kebab-menu.test.tsx b/__tests__/components/automations/kebab-menu.test.tsx
new file mode 100644
index 0000000000..686c6bfa1d
--- /dev/null
+++ b/__tests__/components/automations/kebab-menu.test.tsx
@@ -0,0 +1,20 @@
+import { render, screen, fireEvent } from "@testing-library/react";
+import { describe, it, expect, vi } from "vitest";
+import { KebabMenu } from "#/components/features/automations/kebab-menu";
+
+describe("KebabMenu", () => {
+ it("opens the menu and invokes an item's onClick when selected", async () => {
+ const onClick = vi.fn();
+ render(
+ <KebabMenu items={[{ label: "Delete", icon: <span />, onClick }]} />,
+ );
+
+ // Open the menu, then select the item (rendered via KebabMenuItemContent).
+ fireEvent.click(
+ screen.getByRole("button", { name: "AUTOMATIONS$ACTIONS_MENU" }),
+ );
+ fireEvent.click(await screen.findByText("Delete"));
+
+ expect(onClick).toHaveBeenCalledTimes(1);
+ });
+});
diff --git a/src/components/features/automations/automation-view-toggle.tsx b/src/components/features/automations/automation-view-toggle.tsx
index fdcfbde370..e914c9c1c5 100644
--- a/src/components/features/automations/automation-view-toggle.tsx
+++ b/src/components/features/automations/automation-view-toggle.tsx
@@ -1,13 +1,13 @@
import { useEffect, useLayoutEffect, useRef, useState } from "react";
import ReactDOM from "react-dom";
-import { Check, Grid2x2, Rows3 } from "lucide-react";
+import { Grid2x2, Rows3 } from "lucide-react";
import { useTranslation } from "react-i18next";
import { ContextMenuListItem } from "#/components/features/context-menu/context-menu-list-item";
import { I18nKey } from "#/i18n/declaration";
import { ContextMenu } from "#/ui/context-menu";
import { cn } from "#/utils/utils";
-import { dropdownMenuRowIconWrapperClassName } from "#/utils/dropdown-classes";
import type { AutomationViewMode } from "./automation-view-mode";
+import { ViewMenuItemContent } from "./view-menu-item-content";
interface AutomationViewToggleProps {
view: AutomationViewMode;
@@ -35,26 +35,6 @@ const VIEW_OPTIONS: {
},
];
-function ViewMenuItemContent({
- icon: Icon,
- label,
- isSelected,
-}: {
- icon: typeof Grid2x2;
- label: string;
- isSelected: boolean;
-}) {
- return (
- <span className="flex min-w-0 w-full items-center gap-2">
- <span className={dropdownMenuRowIconWrapperClassName} aria-hidden>
- <Icon />
- </span>
- <span className="min-w-0 flex-1 truncate">{label}</span>
- {isSelected ? <Check className="size-4 shrink-0" aria-hidden /> : null}
- </span>
- );
-}
-
export function AutomationViewToggle({
view,
onChange,
diff --git a/src/components/features/automations/kebab-menu-item-content.tsx b/src/components/features/automations/kebab-menu-item-content.tsx
new file mode 100644
index 0000000000..e8882a379f
--- /dev/null
+++ b/src/components/features/automations/kebab-menu-item-content.tsx
@@ -0,0 +1,24 @@
+import { cn } from "#/utils/utils";
+import { dropdownMenuRowIconWrapperClassName } from "#/utils/dropdown-classes";
+
+interface KebabMenuItemContentProps {
+ icon: React.ReactNode;
+ label: string;
+}
+
+export function KebabMenuItemContent({
+ icon,
+ label,
+}: KebabMenuItemContentProps) {
+ return (
+ <span className="flex min-w-0 w-full items-center gap-2">
+ <span
+ className={cn("[&_svg]:size-4", dropdownMenuRowIconWrapperClassName)}
+ aria-hidden
+ >
+ {icon}
+ </span>
+ <span className="min-w-0 flex-1 truncate">{label}</span>
+ </span>
+ );
+}
diff --git a/src/components/features/automations/kebab-menu.tsx b/src/components/features/automations/kebab-menu.tsx
index ce0339da06..9a5e29c1e5 100644
--- a/src/components/features/automations/kebab-menu.tsx
+++ b/src/components/features/automations/kebab-menu.tsx
@@ -4,10 +4,9 @@ import { useTranslation } from "react-i18next";
import KebabVerticalIcon from "#/icons/kebab-vertical.svg?react";
import { ContextMenuListItem } from "#/components/features/context-menu/context-menu-list-item";
import { I18nKey } from "#/i18n/declaration";
-import { cn } from "#/utils/utils";
import { ContextMenu } from "#/ui/context-menu";
-import { dropdownMenuRowIconWrapperClassName } from "#/utils/dropdown-classes";
import { automationIconActionButtonClassName } from "./automation-action-button-classes";
+import { KebabMenuItemContent } from "./kebab-menu-item-content";
export interface KebabMenuItem {
label: string;
@@ -16,25 +15,6 @@ export interface KebabMenuItem {
disabled?: boolean;
}
-interface KebabMenuItemContentProps {
- icon: React.ReactNode;
- label: string;
-}
-
-function KebabMenuItemContent({ icon, label }: KebabMenuItemContentProps) {
- return (
- <span className="flex min-w-0 w-full items-center gap-2">
- <span
- className={cn("[&_svg]:size-4", dropdownMenuRowIconWrapperClassName)}
- aria-hidden
- >
- {icon}
- </span>
- <span className="min-w-0 flex-1 truncate">{label}</span>
- </span>
- );
-}
-
interface KebabMenuProps {
items: KebabMenuItem[];
}
diff --git a/src/components/features/automations/view-menu-item-content.tsx b/src/components/features/automations/view-menu-item-content.tsx
new file mode 100644
index 0000000000..87b5e358f2
--- /dev/null
+++ b/src/components/features/automations/view-menu-item-content.tsx
@@ -0,0 +1,22 @@
+import { Check, Grid2x2 } from "lucide-react";
+import { dropdownMenuRowIconWrapperClassName } from "#/utils/dropdown-classes";
+
+export function ViewMenuItemContent({
+ icon: Icon,
+ label,
+ isSelected,
+}: {
+ icon: typeof Grid2x2;
+ label: string;
+ isSelected: boolean;
+}) {
+ return (
+ <span className="flex min-w-0 w-full items-center gap-2">
+ <span className={dropdownMenuRowIconWrapperClassName} aria-hidden>
+ <Icon />
+ </span>
+ <span className="min-w-0 flex-1 truncate">{label}</span>
+ {isSelected ? <Check className="size-4 shrink-0" aria-hidden /> : null}
+ </span>
+ );
+}