π OpenHands: AI-Driven Development
fix(frontend): show friendly message for budget/credit errors in V1 conversations (#12401)
Graham Neubig57929b73eeb0
diff --git a/frontend/__tests__/conversation-websocket-handler.test.tsx b/frontend/__tests__/conversation-websocket-handler.test.tsxindex b10dbbcc7b..2784c9d726 100644--- a/frontend/__tests__/conversation-websocket-handler.test.tsx+++ b/frontend/__tests__/conversation-websocket-handler.test.tsx@@ -20,6 +20,7 @@ import {createMockMessageEvent,createMockUserMessageEvent,createMockConversationErrorEvent,+ createMockAgentErrorEvent,createMockBrowserObservationEvent,createMockBrowserNavigateActionEvent,createMockExecuteBashActionEvent,@@ -315,6 +316,36 @@ describe("Conversation WebSocket Handler", () => {});});+ it("should show friendly i18n message for budget/credit errors", async () => {+ // Create a mock AgentErrorEvent with budget-related error message+ const mockBudgetErrorEvent = createMockAgentErrorEvent({+ error:+ "litellm.BadRequestError: Litellm_proxyException - ExceededBudget: User=xxx over budget.",+ });++ // Set up MSW to send the budget error event when connection is established+ mswServer.use(+ wsLink.addEventListener("connection", ({ client, server }) => {+ server.connect();+ client.send(JSON.stringify(mockBudgetErrorEvent));+ }),+ );++ // Render components that use both WebSocket and error message store+ renderWithWebSocketContext(<ErrorMessageStoreComponent />);++ // Initially should show "none"+ expect(screen.getByTestId("error-message")).toHaveTextContent("none");++ // Wait for connection and error event processing+ // Should show the i18n key instead of raw error message+ await waitFor(() => {+ expect(screen.getByTestId("error-message")).toHaveTextContent(+ "STATUS$ERROR_LLM_OUT_OF_CREDITS",+ );+ });+ });+it("should set error message store on WebSocket connection errors", async () => {// Simulate a connect-then-fail sequence (the MSW server auto-connects by default).// This should surface an error message because the app has previously connected.diff --git a/frontend/src/contexts/conversation-websocket-context.tsx b/frontend/src/contexts/conversation-websocket-context.tsxindex 3e026db7eb..7f68b00abc 100644--- a/frontend/src/contexts/conversation-websocket-context.tsx+++ b/frontend/src/contexts/conversation-websocket-context.tsx@@ -340,10 +340,14 @@ export function ConversationWebSocketProvider({// Track credit limit reached if AgentErrorEvent has budget-related errorif (isAgentErrorEvent(event)) {+ // Use friendly i18n message for budget/credit errors instead of raw errorif (isBudgetOrCreditError(event.error)) {+ setErrorMessage(I18nKey.STATUS$ERROR_LLM_OUT_OF_CREDITS);trackCreditLimitReached({conversationId: conversationId || "unknown",});+ } else {+ setErrorMessage(event.error);}}@@ -459,7 +463,12 @@ export function ConversationWebSocketProvider({// Handle AgentErrorEvent specificallyif (isAgentErrorEvent(event)) {- setErrorMessage(event.error);+ // Use friendly i18n message for budget/credit errors instead of raw error+ if (isBudgetOrCreditError(event.error)) {+ setErrorMessage(I18nKey.STATUS$ERROR_LLM_OUT_OF_CREDITS);+ } else {+ setErrorMessage(event.error);+ }}// Clear optimistic user message when a user message is confirmed