π OpenHands: AI-Driven Development
fix(lint): theme critic result text and scores (#18535)
Engel Nyst72a8d9c6aa43
diff --git a/__tests__/components/conversation-events/chat/event-message-components/critic-result-display.test.tsx b/__tests__/components/conversation-events/chat/event-message-components/critic-result-display.test.tsxindex 5fcc2f6812..50fe3004c0 100644--- a/__tests__/components/conversation-events/chat/event-message-components/critic-result-display.test.tsx+++ b/__tests__/components/conversation-events/chat/event-message-components/critic-result-display.test.tsx@@ -86,33 +86,6 @@ describe("CriticResultDisplay", () => {expect(screen.getByText("βββββ")).toBeInTheDocument();});- it("renders green color for high score", () => {- renderWithProviders(- <CriticResultDisplay criticResult={makeCriticResult({ score: 0.8 })} />,- );-- const stars = screen.getByText("β β β β β");- expect(stars.className).toContain("text-green-400");- });-- it("renders yellow color for medium score", () => {- renderWithProviders(- <CriticResultDisplay criticResult={makeCriticResult({ score: 0.5 })} />,- );-- const stars = screen.getByText("β β β ββ");- expect(stars.className).toContain("text-yellow-400");- });-- it("renders red color for low score", () => {- renderWithProviders(- <CriticResultDisplay criticResult={makeCriticResult({ score: 0.2 })} />,- );-- const stars = screen.getByText("β ββββ");- expect(stars.className).toContain("text-red-400");- });-it("renders label text", () => {renderWithProviders(<CriticResultDisplay criticResult={makeCriticResult()} />,diff --git a/__tests__/themes/color-themes.test.tsx b/__tests__/themes/color-themes.test.tsxindex 34c96c32f6..f5ae5e1578 100644--- a/__tests__/themes/color-themes.test.tsx+++ b/__tests__/themes/color-themes.test.tsx@@ -182,6 +182,23 @@ describe("color themes", () => {).toBeGreaterThanOrEqual(4.5);}+ // Critic scores and small supporting text render directly on the chat canvas.+ for (const role of [+ "--oh-feedback-success",+ "--oh-feedback-warning",+ "--oh-feedback-error",+ "--oh-text-tertiary",+ "--oh-contrast",+ ]) {+ expect(+ contrast(+ luminance(resolve(role)),+ luminance(resolve("--oh-color-base")),+ ),+ `${role} against the critic canvas surface`,+ ).toBeGreaterThanOrEqual(4.5);+ }+// @spec TN-001 β Toast text stays readable on the toast surfaceexpect(contrast(diff --git a/src/components/conversation-events/chat/event-message-components/critic-result-display.tsx b/src/components/conversation-events/chat/event-message-components/critic-result-display.tsxindex 709f16f509..2664868bd3 100644--- a/src/components/conversation-events/chat/event-message-components/critic-result-display.tsx+++ b/src/components/conversation-events/chat/event-message-components/critic-result-display.tsx@@ -33,18 +33,18 @@ function getStarRating(normalizedScore: number): {* Get the color class for the star rating based on score.*/function getScoreColorClass(score: number): string {- if (score >= 0.6) return "text-green-400";- if (score >= 0.4) return "text-yellow-400";- return "text-red-400";+ if (score >= 0.6) return "text-feedback-success";+ if (score >= 0.4) return "text-feedback-warning";+ return "text-feedback-error";}/*** Get the color class for an issue probability.*/function getIssueColorClass(probability: number): string {- if (probability >= 0.7) return "text-red-400 font-semibold";- if (probability >= 0.5) return "text-yellow-400";- return "text-neutral-400";+ if (probability >= 0.7) return "text-feedback-error font-semibold";+ if (probability >= 0.5) return "text-feedback-warning";+ return "text-text-tertiary";}function isSettingsRecord(value: unknown): value is Record<string, unknown> {@@ -77,7 +77,7 @@ function FeatureItem({ feature }: { feature: CriticFeature }) {return (<span className="inline-flex items-center gap-1">- <span className="text-neutral-200">{feature.display_name}</span>+ <span className="text-contrast">{feature.display_name}</span><span className={colorClass}>({percentage}%)</span></span>);@@ -97,10 +97,10 @@ function FeatureCategory({return (<div className="flex flex-wrap items-center gap-x-1 text-xs">- <span className="font-semibold text-neutral-300">{label}</span>+ <span className="font-semibold text-text-tertiary">{label}</span>{features.map((feature, i) => (<React.Fragment key={feature.name}>- {i > 0 && <span className="text-neutral-500">Β·</span>}+ {i > 0 && <span className="text-text-tertiary">Β·</span>}<FeatureItem feature={feature} /></React.Fragment>))}@@ -196,9 +196,9 @@ export function CriticResultDisplay({(categorized.other ?? []).length > 0);return (- <div className="border-l-2 border-neutral-600 pl-2 my-2 py-1.5 text-sm">+ <div className="border-l-2 border-border pl-2 my-2 py-1.5 text-sm"><div className="flex items-center gap-1">- <span className="font-semibold text-neutral-300 text-xs">+ <span className="font-semibold text-text-tertiary text-xs">{t(I18nKey.CRITIC$SUCCESS_LIKELIHOOD_LABEL)}</span><span@@ -208,7 +208,7 @@ export function CriticResultDisplay({{"β ".repeat(filled)}{"β".repeat(empty)}</span>- <span className="text-neutral-500 text-xs">({percentage}%)</span>+ <span className="text-text-tertiary text-xs">({percentage}%)</span>{hasDetails && (<button@@ -222,9 +222,9 @@ export function CriticResultDisplay({}>{expanded ? (- <ArrowUp className="h-3 w-3 inline fill-neutral-400" />+ <ArrowUp className="h-3 w-3 inline fill-text-tertiary" />) : (- <ArrowDown className="h-3 w-3 inline fill-neutral-400" />+ <ArrowDown className="h-3 w-3 inline fill-text-tertiary" />)}</button>)}@@ -236,7 +236,7 @@ export function CriticResultDisplay({{showIterativeRefinementHint && (<p- className="mt-1.5 text-xs leading-5 text-neutral-500"+ className="mt-1.5 text-xs leading-5 text-text-tertiary"data-testid="critic-iterative-refinement-hint">{t(I18nKey.CRITIC$ITERATIVE_REFINEMENT_HINT)}