π OpenHands: AI-Driven Development
fix(mcp): workaround for ASGI error caused by duplicate http start in mcp (#9891)
llamantino739044087b5d
diff --git a/openhands/runtime/mcp/proxy/manager.py b/openhands/runtime/mcp/proxy/manager.pyindex 5a4bb69ae1..8cb793bad0 100644--- a/openhands/runtime/mcp/proxy/manager.py+++ b/openhands/runtime/mcp/proxy/manager.py@@ -8,6 +8,7 @@ including initialization, configuration, and mounting to FastAPI applications.import loggingfrom typing import Any, Optional+from anyio import get_cancelled_exc_classfrom fastapi import FastAPIfrom fastmcp import FastMCPfrom fastmcp.utilities.logging import get_logger as fastmcp_get_logger@@ -89,9 +90,29 @@ class MCPProxyManager:if not self.proxy:raise ValueError('FastMCP Proxy is not initialized')+ def close_on_double_start(app):+ async def wrapped(scope, receive, send):+ start_sent = False++ async def check_send(message):+ nonlocal start_sent+ if message['type'] == 'http.response.start':+ if start_sent:+ raise get_cancelled_exc_class()(+ 'closed because of double http.response.start (mcp issue https://github.com/modelcontextprotocol/python-sdk/issues/883)'+ )+ start_sent = True+ await send(message)++ await app(scope, receive, check_send)++ return wrapped+# Get the SSE app# mcp_app = self.proxy.http_app(path='/shttp')- mcp_app = self.proxy.http_app(path='/sse', transport='sse')+ mcp_app = close_on_double_start(+ self.proxy.http_app(path='/sse', transport='sse')+ )app.mount('/mcp', mcp_app)# Remove any existing mounts at root path